From 000032396cf3df674b784df3702bd2be905552c4 Mon Sep 17 00:00:00 2001 From: Dmitry Rozhkov Date: Thu, 20 Jul 2017 09:42:41 +0300 Subject: [PATCH] roscpp: add missing header for writev() resolves #532 Signed-off-by: Dmitry Rozhkov --- ...roscpp-add-missing-header-for-writev.patch | 39 +++++++++++++++++++ recipes-ros/ros-comm/roscpp_1.11.21.bb | 2 + 2 files changed, 41 insertions(+) create mode 100644 recipes-ros/ros-comm/roscpp/0001-roscpp-add-missing-header-for-writev.patch diff --git a/recipes-ros/ros-comm/roscpp/0001-roscpp-add-missing-header-for-writev.patch b/recipes-ros/ros-comm/roscpp/0001-roscpp-add-missing-header-for-writev.patch new file mode 100644 index 0000000..e5cf5af --- /dev/null +++ b/recipes-ros/ros-comm/roscpp/0001-roscpp-add-missing-header-for-writev.patch @@ -0,0 +1,39 @@ +From 4fbb9f952726a12b1938ea7af9e88ae8b234395e Mon Sep 17 00:00:00 2001 +From: Dmitry Rozhkov +Date: Wed, 19 Jul 2017 11:17:11 +0300 +Subject: [PATCH] [roscpp] add missing header for writev(). + +After an update of gcc and glibc roscpp started to fail builds with the error: + + /home/rojkov/work/ros/build/tmp-glibc/work/i586-oe-linux/roscpp/1.11.21-r0/ros_comm-1.11.21/clients/roscpp/src/libros/transport/transport_udp.cpp:579:25: error: 'writev' was not declared in this scope + ssize_t num_bytes = writev(sock_, iov, 2); + ^~~~~~ + +According to POSIX.1-2001 the function writev() is declared in sys/uio.h. + +The patch includes the missing header for POSIX compliant systems. + +Upstream-Status: Accepted [https://github.com/ros/ros_comm/pull/1105] + +Signed-off-by: Dmitry Rozhkov +--- + clients/roscpp/src/libros/transport/transport_udp.cpp | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/clients/roscpp/src/libros/transport/transport_udp.cpp b/clients/roscpp/src/libros/transport/transport_udp.cpp +index c7d8298..47d969e 100644 +--- a/clients/roscpp/src/libros/transport/transport_udp.cpp ++++ b/clients/roscpp/src/libros/transport/transport_udp.cpp +@@ -48,6 +48,9 @@ + #elif defined(__ANDROID__) + // For readv() and writev() on ANDROID + #include ++#elif defined(_POSIX_VERSION) ++ // For readv() and writev() ++ #include + #endif + + namespace ros +-- +2.9.3 + diff --git a/recipes-ros/ros-comm/roscpp_1.11.21.bb b/recipes-ros/ros-comm/roscpp_1.11.21.bb index 8edfdc0..04e3b61 100644 --- a/recipes-ros/ros-comm/roscpp_1.11.21.bb +++ b/recipes-ros/ros-comm/roscpp_1.11.21.bb @@ -10,6 +10,8 @@ DEPENDS = "cpp-common message-generation rosconsole roscpp-serialization roscpp- require ros-comm.inc +SRC_URI += "file://0001-roscpp-add-missing-header-for-writev.patch;striplevel=3" + ROS_PKG_SUBDIR = "clients" CXXFLAGS_append = " -I${OECMAKE_BUILDPATH}/devel/include"