The description is not indented after line breaks. All other
information, i.e., the dependencies and SRCURI, are indented with
four spaces after line breaks. Shell scripts are indented with
multiples of four spaces.
In recipes-ros, I located and checked for tabulators and spacing
with these bash commands:
egrep '^ [^ ]+' . --exclude *.patch -R
egrep '^ [^ ]+' . --exclude *.patch -R
egrep '^ [^ ]+' . --exclude *.patch -R
egrep '^ [ ]+[^ ]+' . --exclude *.patch -R
While going through the recipes and manually improving the layout,
I also adjusted the descriptions to use maximal 100 characters
per line.
Currently, it is not clear if the additional files are required in
the normal package or the dev package. Hence, we do not touch them
(they are not added to any package or deleted after the installation)
until the right operation is clear.
Until then, the console-bridge emits the warning
WARNING: QA Issue: console-bridge: Files/directories were installed but not shipped
/usr/share
/usr/share/console_bridge
/usr/share/console_bridge/package.xml
/usr/share/console_bridge/cmake
/usr/share/console_bridge/cmake/console_bridge-config.cmake
The console-bridge is a cmake installation, but not a catkin package.
In its current state, the recipe compiles and installs, but the
class_loader package fails and complains with
| catkin_package() CATKIN_DEPENDS on 'console_bridge', which has been found
| in
| '(...)/build/tmp-eglibc/sysroots/qemux86-64/usr/share/console_bridge/cmake/console_bridge-config.cmake',
| but it is not a catkin package
This commit provides the current state for further discussion and
joint investigation.
Lukas Bulwahn