fix #141 - use host network to match GitHub Actions runners (#142)

This commit is contained in:
Casey Lee 2020-03-09 17:43:24 -07:00 committed by GitHub
parent bd6f232b20
commit 143676fcfb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 35 additions and 19 deletions

View File

@ -24,16 +24,17 @@ import (
// NewContainerInput the input for the New function
type NewContainerInput struct {
Image string
Entrypoint []string
Cmd []string
WorkingDir string
Env []string
Binds []string
Mounts map[string]string
Name string
Stdout io.Writer
Stderr io.Writer
Image string
Entrypoint []string
Cmd []string
WorkingDir string
Env []string
Binds []string
Mounts map[string]string
Name string
Stdout io.Writer
Stderr io.Writer
NetworkMode string
}
// FileEntry is a file to copy to a container
@ -221,8 +222,9 @@ func (cr *containerReference) create() common.Executor {
}
resp, err := cr.cli.ContainerCreate(ctx, config, &container.HostConfig{
Binds: input.Binds,
Mounts: mounts,
Binds: input.Binds,
Mounts: mounts,
NetworkMode: container.NetworkMode(input.NetworkMode),
}, nil, input.Name)
if err != nil {
return errors.WithStack(err)

View File

@ -107,10 +107,10 @@ func (rc *RunContext) startJobContainer() common.Executor {
"act-toolcache": "/toolcache",
"act-actions": "/actions",
},
Binds: binds,
Stdout: logWriter,
Stderr: logWriter,
NetworkMode: "host",
Binds: binds,
Stdout: logWriter,
Stderr: logWriter,
})
return common.NewPipelineExecutor(

View File

@ -177,9 +177,10 @@ func (sc *StepContext) newStepContainer(ctx context.Context, image string, cmd [
"act-toolcache": "/toolcache",
"act-actions": "/actions",
},
Binds: binds,
Stdout: logWriter,
Stderr: logWriter,
NetworkMode: fmt.Sprintf("container:%s", rc.jobContainerName()),
Binds: binds,
Stdout: logWriter,
Stderr: logWriter,
})
return stepContainer
}

13
pkg/runner/testdata/issue-141/main.yaml vendored Normal file
View File

@ -0,0 +1,13 @@
name: "Create cluster using KinD"
on: push
jobs:
kind:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: engineerd/setup-kind@v0.3.0
- name: Testing
run: |
kubectl cluster-info
kubectl get pods -n kube-system