From 17652ce80e49feecef967adcb12797ee55424f86 Mon Sep 17 00:00:00 2001 From: Ryan Date: Wed, 22 Sep 2021 19:43:58 +0000 Subject: [PATCH] Remove ubuntu-16.04 and add missing links for nix/go (#821) * fix: remove ubuntu-16.04 * fix: add missing links for nix/go * fix: remove specific platform versions --- IMAGES.md | 12 ++++-------- README.md | 24 ++++++++++-------------- cmd/platforms.go | 11 +++-------- cmd/root.go | 4 ++-- 4 files changed, 19 insertions(+), 32 deletions(-) diff --git a/IMAGES.md b/IMAGES.md index d3044d47..a3424404 100644 --- a/IMAGES.md +++ b/IMAGES.md @@ -8,12 +8,10 @@ **Note 2: `node` `-slim` images don't have `python` installed, if you want to use actions or software that is depending on `python`, you need to specify image manually** -| Image | Size | -| ------------------------------------ | -------------------------------------------------------- | -| [`node:12-buster`][hub/_/node] | ![`buster-size`][hub/_/node/12-buster/size] | -| [`node:12-buster-slim`][hub/_/node] | ![`micro-buster-size`][hub/_/node/12-buster-slim/size] | -| [`node:12-stretch`][hub/_/node] | ![`stretch-size`][hub/_/node/12-stretch/size] | -| [`node:12-stretch-slim`][hub/_/node] | ![`micro-stretch-size`][hub/_/node/12-stretch-slim/size] | +| Image | Size | +| ----------------------------------- | ------------------------------------------------------ | +| [`node:12-buster`][hub/_/node] | ![`buster-size`][hub/_/node/12-buster/size] | +| [`node:12-buster-slim`][hub/_/node] | ![`micro-buster-size`][hub/_/node/12-buster-slim/size] | **Note: `catthehacker/ubuntu` images are based on Ubuntu root filesystem** @@ -46,8 +44,6 @@ Feel free to make a pull request with your image added here [hub/_/node]: https://hub.docker.com/r/_/node [hub/_/node/12-buster/size]: https://img.shields.io/docker/image-size/_/node/12-buster [hub/_/node/12-buster-slim/size]: https://img.shields.io/docker/image-size/_/node/12-buster-slim -[hub/_/node/12-stretch/size]: https://img.shields.io/docker/image-size/_/node/12-stretch -[hub/_/node/12-stretch-slim/size]: https://img.shields.io/docker/image-size/_/node/12-stretch-slim [ghcr/catthehacker/ubuntu]: https://github.com/catthehacker/docker_images/pkgs/container/ubuntu [hub/nektos/act-environments-ubuntu]: https://hub.docker.com/r/nektos/act-environments-ubuntu [hub/nektos/act-environments-ubuntu/18.04/size]: https://img.shields.io/docker/image-size/nektos/act-environments-ubuntu/18.04 diff --git a/README.md b/README.md index 248b86ae..345a8bb2 100644 --- a/README.md +++ b/README.md @@ -71,7 +71,9 @@ scoop install act yay -S act ``` -### Nix (Linux/macOS) +### [Nix](https://nixos.org) (Linux/macOS) + +[Nix recipe](https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/misc/act/default.nix) Global install: @@ -85,7 +87,7 @@ or through `nix-shell`: nix-shell -p act ``` -### Go (Linux/Windows/macOS/any other platform supported by Go) +### [Go](https://golang.org) (Linux/Windows/macOS/any other platform supported by Go) If you have Go 1.16+, you can install latest released version of `act` directly from source by running: @@ -227,22 +229,16 @@ export DOCKER_HOST=$(docker context inspect --format '{{.Endpoints.docker.Host}} GitHub Actions offers managed [virtual environments](https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners) for running workflows. In order for `act` to run your workflows locally, it must run a container for the runner defined in your workflow file. Here are the images that `act` uses for each runner type and size: -| GitHub Runner | Micro Docker Image | Medium Docker Image | Large Docker Image | -| --------------- | ------------------------------- | --------------------------------------------------------- | ---------------------------------------------------------- | -| `ubuntu-latest` | [`node:12-buster-slim`][micro] | [`ghcr.io/catthehacker/ubuntu:act-latest`][docker_images] | [`ghcr.io/catthehacker/ubuntu:full-latest`][docker_images] | -| `ubuntu-20.04` | [`node:12-buster-slim`][micro] | [`ghcr.io/catthehacker/ubuntu:act-20.04`][docker_images] | [`ghcr.io/catthehacker/ubuntu:full-20.04`][docker_images] | -| `ubuntu-18.04` | [`node:12-buster-slim`][micro] | [`ghcr.io/catthehacker/ubuntu:act-18.04`][docker_images] | [`ghcr.io/catthehacker/ubuntu:full-18.04`][docker_images] | -| `ubuntu-16.04` | [`node:12-stretch-slim`][micro] | [`ghcr.io/catthehacker/ubuntu:act-16.04`][docker_images] | `unavailable` | +| GitHub Runner | Micro Docker Image | Medium Docker Image | Large Docker Image | +| --------------- | ------------------------------ | --------------------------------------------------------- | ---------------------------------------------------------- | +| `ubuntu-latest` | [`node:12-buster-slim`][micro] | [`ghcr.io/catthehacker/ubuntu:act-latest`][docker_images] | [`ghcr.io/catthehacker/ubuntu:full-latest`][docker_images] | +| `ubuntu-20.04` | [`node:12-buster-slim`][micro] | [`ghcr.io/catthehacker/ubuntu:act-20.04`][docker_images] | [`ghcr.io/catthehacker/ubuntu:full-20.04`][docker_images] | +| `ubuntu-18.04` | [`node:12-buster-slim`][micro] | [`ghcr.io/catthehacker/ubuntu:act-18.04`][docker_images] | [`ghcr.io/catthehacker/ubuntu:full-18.04`][docker_images] | [micro]: https://hub.docker.com/_/buildpack-deps [docker_images]: https://github.com/catthehacker/docker_images -Below platforms are currently **unsupported and won't work** (see issue [#97](https://github.com/nektos/act/issues/97)) - -- `windows-latest` -- `windows-2019` -- `macos-latest` -- `macos-10.15` +Windows and macOS based platforms are currently **unsupported and won't work** (see issue [#97](https://github.com/nektos/act/issues/97)) ## Please see [IMAGES.md](./IMAGES.md) for more information about the Docker images that can be used with `act` diff --git a/cmd/platforms.go b/cmd/platforms.go index d7e9d54f..1e8bb5c5 100644 --- a/cmd/platforms.go +++ b/cmd/platforms.go @@ -6,14 +6,9 @@ import ( func (i *Input) newPlatforms() map[string]string { platforms := map[string]string{ - "ubuntu-latest": "node:12-buster-slim", - "ubuntu-20.04": "node:12-buster-slim", - "ubuntu-18.04": "node:12-buster-slim", - "ubuntu-16.04": "node:12-stretch-slim", - "windows-latest": "", - "windows-2019": "", - "macos-latest": "", - "macos-10.15": "", + "ubuntu-latest": "node:12-buster-slim", + "ubuntu-20.04": "node:12-buster-slim", + "ubuntu-18.04": "node:12-buster-slim", } for _, p := range i.platforms { diff --git a/cmd/root.go b/cmd/root.go index d37b33e0..07dce507 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -310,9 +310,9 @@ func defaultImageSurvey(actrc string) error { case "Large": option = "-P ubuntu-latest=ghcr.io/catthehacker/ubuntu:full-latest\n-P ubuntu-latest=ghcr.io/catthehacker/ubuntu:full-20.04\n-P ubuntu-18.04=ghcr.io/catthehacker/ubuntu:full-18.04\n" case "Medium": - option = "-P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-latest\n-P ubuntu-20.04=ghcr.io/catthehacker/ubuntu:act-20.04\n-P ubuntu-18.04=ghcr.io/catthehacker/ubuntu:act-18.04\n-P ubuntu-16.04=ghcr.io/catthehacker/ubuntu:act-16.04\n" + option = "-P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-latest\n-P ubuntu-20.04=ghcr.io/catthehacker/ubuntu:act-20.04\n-P ubuntu-18.04=ghcr.io/catthehacker/ubuntu:act-18.04\n" case "Micro": - option = "-P ubuntu-latest=node:12-buster-slim\n-P ubuntu-20.04=node:12-buster-slim\n-P ubuntu-18.04=node:12-buster-slim\n-P ubuntu-16.04=node:12-stretch-slim\n" + option = "-P ubuntu-latest=node:12-buster-slim\n-P ubuntu-20.04=node:12-buster-slim\n-P ubuntu-18.04=node:12-buster-slim\n" } f, err := os.Create(actrc)