p85947160
/
Gitee-Jenkins-Plugin
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[Issue-448] added simple log info if not authorized

This commit is contained in:
Radoslaw Grebski 2016-11-21 20:34:10 +01:00
parent 3e240880c4
commit 9a9c29fc57
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/com/dabsquared/gitlabjenkins/webhook/build/BuildWebHookAction.java
View File

@ -1,8 +1,7 @@
package com.dabsquared.gitlabjenkins.webhook.build;
import com.dabsquared.gitlabjenkins.GitLabPushTrigger;
import com.dabsquared.gitlabjenkins.connection.GitLabConnectionConfig;
import com.dabsquared.gitlabjenkins.webhook.WebHookAction;
import java.util.logging.Logger;
import hudson.model.Item;
import hudson.model.Job;
import hudson.security.Messages;
@ -12,11 +11,17 @@ import jenkins.model.Jenkins;
import org.acegisecurity.Authentication;
import org.apache.commons.lang.StringUtils;
import org.kohsuke.stapler.StaplerResponse;
import com.dabsquared.gitlabjenkins.GitLabPushTrigger;
import com.dabsquared.gitlabjenkins.connection.GitLabConnectionConfig;
import com.dabsquared.gitlabjenkins.webhook.WebHookAction;
/**
* @author Xinran Xiao
*/
abstract class BuildWebHookAction implements WebHookAction {
private final static Logger LOGGER = Logger.getLogger(BuildWebHookAction.class.getName());
abstract void processForCompatibility();
abstract void execute();
@ -54,6 +59,7 @@ abstract class BuildWebHookAction implements WebHookAction {
if (((GitLabConnectionConfig) Jenkins.getInstance().getDescriptor(GitLabConnectionConfig.class)).isUseAuthenticatedEndpoint()) {
if (!Jenkins.getActiveInstance().getACL().hasPermission(authentication, permission)) {
String message = Messages.AccessDeniedException2_MissingPermission(authentication.getName(), permission.group.title+"/"+permission.name);
LOGGER.finest("Unauthorized (Did you forget to add API Token to the web hook ?)");
throw HttpResponses.errorWithoutStack(403, message);
}
}