p96705831
/
platform_build
forked from openkylin/platform_build
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
platform_build/core/executable_prefer_symlink.mk

45 lines
1.7 KiB
Makefile
Raw Normal View History

executable_prefer_symlink: add makefile for creating symlink to prefer version For a 64bit target, we can have support for both 32bit and 64bit version binary(like app_process, dalvikvm), and there are some commands like am/pm will call these commands to implement it's function. In some targets it will prefer to use the 32bit version, and in other targets it will prefer to use the 64bit version. So this change is to add the common work for creating the symlink to the prefer version binary,and avoid the change on the caller commands side like am/pm. In this change, it uses TARGET_PREFER_32_BIT_APPS to decide linking to 32bit version or 64bit version. Change-Id: I96f041c0e0ededd953feead30ec63ad63e945a6f Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
2014-05-07 12:41:24 +08:00
# include this makefile to create the LOCAL_MODULE symlink to the primary version binary.
# but this requires the primary version name specified via LOCAL_MODULE_STEM_32 or LOCAL_MODULE_STEM_64,
# and different with the LOCAL_MODULE value
#
# Note: now only limited to the binaries that will be installed under system/bin directory
my_symlink := $(addprefix $(TARGET_OUT)/bin/, $(LOCAL_MODULE))
Fix executable symlinks. 32 bit targets will leave TARGET_PREFER_{32,64}_BIT_APPS unset so adjust accordingly. Also clean up an explanatory comment. Change-Id: I1f6faa640e4e862631fff49f7c565766ef2c567f
2014-05-15 01:26:48 +08:00
# Create link to the one used depending on the target
# configuration. Note that we require the TARGET_IS_64_BIT
# check because 32 bit targets may not define TARGET_PREFER_32_BIT_APPS
# et al. since those variables make no sense in that context.
ifeq ($(TARGET_IS_64_BIT),true)
Fix issue in symlinking 64 bit executables. We were not inspecting the value of TARGET_SUPPORTS_{32,64}_BIT_APPS so we'd sometimes create the wrong symlink if TARGET_IS_64_BIT was true. bug: 15661143 Change-Id: I2a6eb3278445fcd14bc9dc9312f41f972ea77971
2014-06-17 23:36:08 +08:00
ifeq ($(TARGET_SUPPORTS_64_BIT_APPS)|$(TARGET_SUPPORTS_32_BIT_APPS),true|true)
# We support both 32 and 64 bit apps, so we will have to
# base our decision on whether the target prefers one or the
# other.
ifneq ($(TARGET_PREFER_32_BIT_APPS),true)
$(my_symlink): PRIVATE_SRC_BINARY_NAME := $(LOCAL_MODULE_STEM_32)
else
$(my_symlink): PRIVATE_SRC_BINARY_NAME := $(LOCAL_MODULE_STEM_64)
endif
else ifeq ($(TARGET_SUPPORTS_64_BIT_APPS),true)
# We support only 64 bit apps.
executable_prefer_symlink: add makefile for creating symlink to prefer version For a 64bit target, we can have support for both 32bit and 64bit version binary(like app_process, dalvikvm), and there are some commands like am/pm will call these commands to implement it's function. In some targets it will prefer to use the 32bit version, and in other targets it will prefer to use the 64bit version. So this change is to add the common work for creating the symlink to the prefer version binary,and avoid the change on the caller commands side like am/pm. In this change, it uses TARGET_PREFER_32_BIT_APPS to decide linking to 32bit version or 64bit version. Change-Id: I96f041c0e0ededd953feead30ec63ad63e945a6f Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
2014-05-07 12:41:24 +08:00
$(my_symlink): PRIVATE_SRC_BINARY_NAME := $(LOCAL_MODULE_STEM_64)
else
Fix issue in symlinking 64 bit executables. We were not inspecting the value of TARGET_SUPPORTS_{32,64}_BIT_APPS so we'd sometimes create the wrong symlink if TARGET_IS_64_BIT was true. bug: 15661143 Change-Id: I2a6eb3278445fcd14bc9dc9312f41f972ea77971
2014-06-17 23:36:08 +08:00
# We support only 32 bit apps.
executable_prefer_symlink: add makefile for creating symlink to prefer version For a 64bit target, we can have support for both 32bit and 64bit version binary(like app_process, dalvikvm), and there are some commands like am/pm will call these commands to implement it's function. In some targets it will prefer to use the 32bit version, and in other targets it will prefer to use the 64bit version. So this change is to add the common work for creating the symlink to the prefer version binary,and avoid the change on the caller commands side like am/pm. In this change, it uses TARGET_PREFER_32_BIT_APPS to decide linking to 32bit version or 64bit version. Change-Id: I96f041c0e0ededd953feead30ec63ad63e945a6f Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
2014-05-07 12:41:24 +08:00
$(my_symlink): PRIVATE_SRC_BINARY_NAME := $(LOCAL_MODULE_STEM_32)
endif
Fix executable symlinks. 32 bit targets will leave TARGET_PREFER_{32,64}_BIT_APPS unset so adjust accordingly. Also clean up an explanatory comment. Change-Id: I1f6faa640e4e862631fff49f7c565766ef2c567f
2014-05-15 01:26:48 +08:00
else
$(my_symlink): PRIVATE_SRC_BINARY_NAME := $(LOCAL_MODULE_STEM_32)
endif
executable_prefer_symlink: add makefile for creating symlink to prefer version For a 64bit target, we can have support for both 32bit and 64bit version binary(like app_process, dalvikvm), and there are some commands like am/pm will call these commands to implement it's function. In some targets it will prefer to use the 32bit version, and in other targets it will prefer to use the 64bit version. So this change is to add the common work for creating the symlink to the prefer version binary,and avoid the change on the caller commands side like am/pm. In this change, it uses TARGET_PREFER_32_BIT_APPS to decide linking to 32bit version or 64bit version. Change-Id: I96f041c0e0ededd953feead30ec63ad63e945a6f Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
2014-05-07 12:41:24 +08:00
$(my_symlink): $(LOCAL_INSTALLED_MODULE) $(LOCAL_MODULE_MAKEFILE)
@echo "Symlink: $@ -> $(PRIVATE_SRC_BINARY_NAME)"
@mkdir -p $(dir $@)
@rm -rf $@
$(hide) ln -sf $(PRIVATE_SRC_BINARY_NAME) $@
# We need this so that the installed files could be picked up based on the
# local module name
ALL_MODULES.$(LOCAL_MODULE).INSTALLED += $(my_symlink)
my_symlink :=