diff --git a/tools/releasetools/common.py b/tools/releasetools/common.py index 74192f79b..52e7aed71 100644 --- a/tools/releasetools/common.py +++ b/tools/releasetools/common.py @@ -18,6 +18,7 @@ import getopt import getpass import imp import os +import platform import re import sha import shutil @@ -57,6 +58,22 @@ def Run(args, **kwargs): return subprocess.Popen(args, **kwargs) +def CloseInheritedPipes(): + """ Gmake in MAC OS has file descriptor (PIPE) leak. We close those fds + before doing other work.""" + if platform.system() != "Darwin": + return + for d in range(3, 1025): + try: + stat = os.fstat(d) + if stat is not None: + pipebit = stat[0] & 0x1000 + if pipebit != 0: + os.close(d) + except OSError: + pass + + def LoadInfoDict(zip): """Read and parse the META/misc_info.txt key/value pairs from the input target files and return a dict.""" diff --git a/tools/releasetools/img_from_target_files b/tools/releasetools/img_from_target_files index f10af492e..78fd1418b 100755 --- a/tools/releasetools/img_from_target_files +++ b/tools/releasetools/img_from_target_files @@ -181,6 +181,7 @@ def main(argv): if __name__ == '__main__': try: + common.CloseInheritedPipes() main(sys.argv[1:]) except common.ExternalError, e: print diff --git a/tools/releasetools/ota_from_target_files b/tools/releasetools/ota_from_target_files index aa691b45c..cd10d7cf3 100755 --- a/tools/releasetools/ota_from_target_files +++ b/tools/releasetools/ota_from_target_files @@ -781,6 +781,7 @@ def main(argv): if __name__ == '__main__': try: + common.CloseInheritedPipes() main(sys.argv[1:]) except common.ExternalError, e: print