p96705831
/
platform_build
forked from openkylin/platform_build
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

build speedup: Do not use shell 'find' function to look for NOTICE files. 

The GNU Make wildcard function can be used to look for a specific file and
is _much_ faster than invoking the find command through $(shell ...).

Since notice_files.mk is included by base_rules.mk for each and every module
in the build tree, this represents a considerable speed-up. For example, when
building the full-eng product from the AOSP tree, the no-op "make" goes from
21 seconds to 16 seconds with this patch applied.

Change-Id: Ideb1bb74d5bfbb650834fa4b6e151ff24dcd0150
This commit is contained in:
David 'Digit' Turner 2011-03-29 14:27:27 +02:00
parent 57c7019693
commit 3e0e611e76
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/notice_files.mk
View File

@ -2,9 +2,9 @@
## Track NOTICE files
###########################################################
notice_file:=$(shell find $(LOCAL_PATH) -maxdepth 1 -name NOTICE)
notice_file:=$(strip $(wildcard $(LOCAL_PATH)/NOTICE))
ifneq ($(strip $(notice_file)),)
ifdef notice_file
# This relies on the name of the directory in PRODUCT_OUT matching where
# it's installed on the target - i.e. system, data, etc. This does