From 854487739933f7ff33980df0c65d2bcd03b049f9 Mon Sep 17 00:00:00 2001 From: Doug Zongker Date: Tue, 9 Sep 2014 14:59:20 -0700 Subject: [PATCH] select default search_path by platform Bug: 17443175 Change-Id: I2b8b0a3b56e667b749ac167a6d09dc973ecf8419 --- core/Makefile | 2 +- tools/releasetools/common.py | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/core/Makefile b/core/Makefile index 506488662..d39ac9c17 100644 --- a/core/Makefile +++ b/core/Makefile @@ -1416,7 +1416,7 @@ endif $(hide) zipinfo -1 $@ | awk 'BEGIN { FS="BOOT/RAMDISK/" } /^BOOT\/RAMDISK\// {print $$2}' | $(HOST_OUT_EXECUTABLES)/fs_config -C -S $(SELINUX_FC) > $(zip_root)/META/boot_filesystem_config.txt $(hide) zipinfo -1 $@ | awk 'BEGIN { FS="RECOVERY/RAMDISK/" } /^RECOVERY\/RAMDISK\// {print $$2}' | $(HOST_OUT_EXECUTABLES)/fs_config -C -S $(SELINUX_FC) > $(zip_root)/META/recovery_filesystem_config.txt $(hide) (cd $(zip_root) && zip -q ../$(notdir $@) META/*filesystem_config.txt) - $(hide) ./build/tools/releasetools/add_img_to_target_files $@ + $(hide) ./build/tools/releasetools/add_img_to_target_files -p $(HOST_OUT) $@ .PHONY: target-files-package target-files-package: $(BUILT_TARGET_FILES_PACKAGE) diff --git a/tools/releasetools/common.py b/tools/releasetools/common.py index bcadea26e..92d912bd6 100644 --- a/tools/releasetools/common.py +++ b/tools/releasetools/common.py @@ -42,7 +42,13 @@ if not hasattr(os, "SEEK_SET"): class Options(object): pass OPTIONS = Options() -OPTIONS.search_path = "out/host/linux-x86" + +DEFAULT_SEARCH_PATH_BY_PLATFORM = { + "linux2": "out/host/linux-x86", + "darwin": "out/host/darwin-x86", + } +OPTIONS.search_path = DEFAULT_SEARCH_PATH_BY_PLATFORM.get(sys.platform, None) + OPTIONS.signapk_path = "framework/signapk.jar" # Relative to search_path OPTIONS.extra_signapk_args = [] OPTIONS.java_path = "java" # Use the one on the path by default. @@ -651,8 +657,9 @@ def ParseOptions(argv, if extra_option_handler is None or not extra_option_handler(o, a): assert False, "unknown option \"%s\"" % (o,) - os.environ["PATH"] = (os.path.join(OPTIONS.search_path, "bin") + - os.pathsep + os.environ["PATH"]) + if OPTIONS.search_path: + os.environ["PATH"] = (os.path.join(OPTIONS.search_path, "bin") + + os.pathsep + os.environ["PATH"]) return args