From 85ccf735e2d261b5b302635505ea1db85975c597 Mon Sep 17 00:00:00 2001 From: Ben Cheng Date: Wed, 28 Aug 2013 11:00:54 -0700 Subject: [PATCH] Re-tighten default compiler options. Remove "-Wno-unused-parameter -Wno-unused-but-set-parameter" added for GCC 4.8 experiment. BUG: 10495043 (cherry picked from internal master 1cea0755f400c1d183d22679d5b931c3a04ae4a4) Change-Id: Ifa221709b1351a9268c06872e2b667138995c3da --- core/combo/TARGET_linux-arm.mk | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/core/combo/TARGET_linux-arm.mk b/core/combo/TARGET_linux-arm.mk index c31fe5938..48f48981c 100644 --- a/core/combo/TARGET_linux-arm.mk +++ b/core/combo/TARGET_linux-arm.mk @@ -109,14 +109,13 @@ android_config_h := $(call select-android-config-h,linux-arm) TARGET_ANDROID_CONFIG_CFLAGS := -include $(android_config_h) -I $(dir $(android_config_h)) TARGET_GLOBAL_CFLAGS += $(TARGET_ANDROID_CONFIG_CFLAGS) -# This warning causes dalvik not to build with gcc 4.6+ and -Werror. -# We cannot turn it off blindly since the option is not available -# in gcc-4.4.x. We also want to disable sincos optimization globally -# by turning off the builtin sin function. +# The "-Wunused-but-set-variable" option often breaks projects that enable +# "-Wall -Werror" due to a commom idiom "ALOGV(mesg)" where ALOGV is turned +# into no-op in some builds while mesg is defined earlier. So we explicitly +# disable "-Wunused-but-set-variable" here. ifneq ($(filter 4.6 4.6.% 4.7 4.7.% 4.8, $(TARGET_GCC_VERSION)),) TARGET_GLOBAL_CFLAGS += -Wno-unused-but-set-variable -fno-builtin-sin \ - -fno-strict-volatile-bitfields \ - -Wno-unused-parameter -Wno-unused-but-set-parameter + -fno-strict-volatile-bitfields endif # This is to avoid the dreaded warning compiler message: