p96705831
/
platform_build
forked from openkylin/platform_build
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add more BUILD_BROKEN_* logic 

Make the values tristate, so that we can differentiate set vs not in
scripts that parse the logs.

Also add some placeholders for warnings that I expect to turn into
errors.

Test: Set BUILD_BROKEN_PHONY_TARGETS to "foo"
Change-Id: I3f7e1e0f85dcef84d6461fc40bdd83dc5bf75ff7
This commit is contained in:
Dan Willemsen 2018-06-21 09:46:01 -07:00
parent 6d3acda913
commit 94bff7ae22
2 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/config.mk
View File

@ -208,8 +208,10 @@ endif
# ###############################################################
# Broken build defaults
# ###############################################################
# Assume that all boards have duplicate rules right now.
BUILD_BROKEN_DUP_RULES := true
BUILD_BROKEN_ANDROIDMK_EXPORTS :=
BUILD_BROKEN_DUP_COPY_HEADERS :=
BUILD_BROKEN_DUP_RULES :=
BUILD_BROKEN_PHONY_TARGETS :=
# ###############################################################
# Include sub-configuration files

17
core/envsetup.mk
View File

@ -272,6 +272,23 @@ ifneq ($(MALLOC_IMPL),)
endif
board_config_mk :=
###########################################
# Handle BUILD_BROKEN_* settings
vars := \
BUILD_BROKEN_ANDROIDMK_EXPORTS \
BUILD_BROKEN_DUP_COPY_HEADERS \
BUILD_BROKEN_DUP_RULES \
BUILD_BROKEN_PHONY_TARGETS
$(foreach var,$(vars),$(eval $(var) := $$(strip $$($(var)))))
$(foreach var,$(vars), \
$(if $(filter-out true false,$($(var))), \
$(error Valid values of $(var) are "true", "false", and "". Not "$($(var))")))
.KATI_READONLY := $(vars)
###########################################
# Now we can substitute with the real value of TARGET_COPY_OUT_VENDOR
ifeq ($(TARGET_COPY_OUT_VENDOR),$(_vendor_path_placeholder))