From 7a02001fa90603922da024c279c7b5af08b400d9 Mon Sep 17 00:00:00 2001 From: Sundong Ahn Date: Thu, 1 Feb 2018 17:17:01 +0900 Subject: [PATCH] Change the naming policy of system_$(VER) The module name of system_$(VER) prebuilt file is system_sdk_v$(VER). But this is inconsistent with sdk_v$(LOCAL_SDK_VERSION) in prebuilts/sdk. So, system_sdk_v$(VER) is changed to sdk_vsystem_$(VER) to use the same naming policy. Bug: 72031391 Test: build Change-Id: I379c0f9aa0de7407489eeec2b07ee7727e81d69d --- core/droiddoc.mk | 22 ++++++---------------- core/java_common.mk | 18 +++++------------- 2 files changed, 11 insertions(+), 29 deletions(-) diff --git a/core/droiddoc.mk b/core/droiddoc.mk index 04eb78eea..25b591c32 100644 --- a/core/droiddoc.mk +++ b/core/droiddoc.mk @@ -75,22 +75,12 @@ ifneq ($(LOCAL_SDK_VERSION),) LOCAL_JAVA_LIBRARIES := core.current.stubs $(LOCAL_JAVA_LIBRARIES) $(full_target): PRIVATE_BOOTCLASSPATH := $(call java-lib-files, core.current.stubs) else - ifneq (,$(call has-system-sdk-version,$(LOCAL_SDK_VERSION))) - ifeq (,$(TARGET_BUILD_APPS)) - LOCAL_JAVA_LIBRARIES := system_sdk_v$(call get-numeric-sdk-version,$(LOCAL_SDK_VERSION)) $(LOCAL_JAVA_LIBRARIES) - $(full_target): PRIVATE_BOOTCLASSPATH := $(call java-lib-files, system_sdk_v$(call get-numeric-sdk-version,$(LOCAL_SDK_VERSION))) - else - LOCAL_JAVA_LIBRARIES := sdk_v$(LOCAL_SDK_VERSION) $(LOCAL_JAVA_LIBRARIES) - $(full_target): PRIVATE_BOOTCLASSPATH := $(call java-lib-files, sdk_v$(LOCAL_SDK_VERSION)) - endif - else - # core_ is subset of . Instead of defining a prebuilt lib for core_, - # use the stub for when building for apps. - _version := $(patsubst core_%,%,$(LOCAL_SDK_VERSION)) - LOCAL_JAVA_LIBRARIES := sdk_v$(_version) $(LOCAL_JAVA_LIBRARIES) - $(full_target): PRIVATE_BOOTCLASSPATH := $(call java-lib-files, sdk_v$(_version)) - _version := - endif + # core_ is subset of . Instead of defining a prebuilt lib for core_, + # use the stub for when building for apps. + _version := $(patsubst core_%,%,$(LOCAL_SDK_VERSION)) + LOCAL_JAVA_LIBRARIES := sdk_v$(_version) $(LOCAL_JAVA_LIBRARIES) + $(full_target): PRIVATE_BOOTCLASSPATH := $(call java-lib-files, sdk_v$(_version)) + _version := endif else LOCAL_JAVA_LIBRARIES := core-oj core-libart ext framework $(LOCAL_JAVA_LIBRARIES) diff --git a/core/java_common.mk b/core/java_common.mk index 2c141f74d..3a5c5c63c 100644 --- a/core/java_common.mk +++ b/core/java_common.mk @@ -261,19 +261,11 @@ ifndef LOCAL_IS_HOST_MODULE else ifeq ($(LOCAL_SDK_VERSION)$(TARGET_BUILD_APPS),core_current) full_java_bootclasspath_libs := $(call java-lib-header-files,core.current.stubs) else - ifneq (,$(call has-system-sdk-version,$(LOCAL_SDK_VERSION))) - ifeq (,$(TARGET_BUILD_APPS)) - full_java_bootclasspath_libs := $(call java-lib-header-files,system_sdk_v$(call get-numeric-sdk-version,$(LOCAL_SDK_VERSION))) - else - full_java_bootclasspath_libs := $(call java-lib-header-files,sdk_v$(LOCAL_SDK_VERSION)) - endif - else - # core_ is subset of . Instead of defining a prebuilt lib for core_, - # use the stub for when building for apps. - _version := $(patsubst core_%,%,$(LOCAL_SDK_VERSION)) - full_java_bootclasspath_libs := $(call java-lib-header-files,sdk_v$(_version)) - _version := - endif + # core_ is subset of . Instead of defining a prebuilt lib for core_, + # use the stub for when building for apps. + _version := $(patsubst core_%,%,$(LOCAL_SDK_VERSION)) + full_java_bootclasspath_libs := $(call java-lib-header-files,sdk_v$(_version)) + _version := endif # current, system_current, system_${VER}, test_current or core_current endif # LOCAL_SDK_VERSION