From bee0dec6c4c65787ce340d0610591d879f13da1a Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Wed, 5 Apr 2017 14:16:49 -0700 Subject: [PATCH] Encode special characters in email addresses. Now accept email addresses with '+' character. Bug: 33166666 Test: checkowners.py -v -c `find . -name OWNERS` Change-Id: I7792551e6be74e942906a75344233439d4bfeca3 --- tools/checkowners.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/checkowners.py b/tools/checkowners.py index 8f450e7a4..b8749550d 100755 --- a/tools/checkowners.py +++ b/tools/checkowners.py @@ -5,6 +5,7 @@ import argparse import re import sys +import urllib import urllib2 parser = argparse.ArgumentParser(description='Check OWNERS file syntax') @@ -29,7 +30,8 @@ def echo(msg): def find_address(address): if address not in checked_addresses: - request = gerrit_server + '/accounts/?suggest&q=' + address + request = (gerrit_server + '/accounts/?n=1&o=ALL_EMAILS&q=email:' + + urllib.quote(address)) echo('Checking email address: ' + address) result = urllib2.urlopen(request).read() expected = '"email": "' + address + '"'