From 8f9487431ce392f3df5181c3d77f86ea8effbae6 Mon Sep 17 00:00:00 2001 From: Dmitriy Ivanov Date: Fri, 17 Apr 2015 11:00:15 -0700 Subject: [PATCH] Remove LOCAL_JNI_SHARED_LIBRARIES_ZIP_OPTIONS Use LOCAL_PAGE_ALIGN_JNI_SHARED_LIBRARIES instead. Change-Id: Id30529fbc1652d066e0008813352848b5e404ab9 --- core/clear_vars.mk | 1 - core/definitions.mk | 5 +++-- core/package_internal.mk | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/core/clear_vars.mk b/core/clear_vars.mk index 51cdc5b16..ea68402a5 100644 --- a/core/clear_vars.mk +++ b/core/clear_vars.mk @@ -96,7 +96,6 @@ LOCAL_COMPRESS_MODULE_SYMBOLS:= LOCAL_STRIP_MODULE:= LOCAL_JNI_SHARED_LIBRARIES:= LOCAL_JNI_SHARED_LIBRARIES_ABI:= -LOCAL_JNI_SHARED_LIBRARIES_ZIP_OPTIONS:= LOCAL_PREBUILT_JNI_LIBS:= LOCAL_JAR_MANIFEST:= LOCAL_INSTRUMENTATION_FOR:= diff --git a/core/definitions.mk b/core/definitions.mk index 4f0daae5f..6114395f9 100644 --- a/core/definitions.mk +++ b/core/definitions.mk @@ -1903,7 +1903,8 @@ $(hide) mkdir -p $(addprefix $(dir $@)lib/,$(PRIVATE_JNI_SHARED_LIBRARIES_ABI)) $(foreach abi,$(PRIVATE_JNI_SHARED_LIBRARIES_ABI),\ $(call _add-jni-shared-libs-to-package-per-abi,$(abi),\ $(patsubst $(abi):%,%,$(filter $(abi):%,$(PRIVATE_JNI_SHARED_LIBRARIES))))) -$(hide) (cd $(dir $@) && zip -r $(PRIVATE_JNI_SHARED_LIBRARIES_ZIP_OPTIONS) $(notdir $@) lib) +$(hide) (cd $(dir $@) && zip -r \ + $(if $(filter true, $(PRIVATE_PAGE_ALIGN_JNI_SHARED_LIBRARIES)),-0,) $(notdir $@) lib) $(hide) rm -rf $(dir $@)lib endef @@ -1937,7 +1938,7 @@ define align-package $(hide) mv $@ $@.unaligned $(hide) $(ZIPALIGN) \ -f \ - $(if $(findstring true, $(PRIVATE_PAGE_ALIGN_JNI_SHARED_LIBRARIES)),-p ,) \ + $(if $(filter true, $(PRIVATE_PAGE_ALIGN_JNI_SHARED_LIBRARIES)),-p,) \ 4 \ $@.unaligned $@.aligned $(hide) mv $@.aligned $@ diff --git a/core/package_internal.mk b/core/package_internal.mk index 016e23fb5..d52997b7f 100644 --- a/core/package_internal.mk +++ b/core/package_internal.mk @@ -369,7 +369,6 @@ $(LOCAL_BUILT_MODULE): $(AAPT) | $(ZIPALIGN) $(LOCAL_BUILT_MODULE): PRIVATE_JNI_SHARED_LIBRARIES := $(jni_shared_libraries_with_abis) # PRIVATE_JNI_SHARED_LIBRARIES_ABI is a list of ABI names. $(LOCAL_BUILT_MODULE): PRIVATE_JNI_SHARED_LIBRARIES_ABI := $(jni_shared_libraries_abis) -$(LOCAL_BUILT_MODULE): PRIVATE_JNI_SHARED_LIBRARIES_ZIP_OPTIONS := $(LOCAL_JNI_SHARED_LIBRARIES_ZIP_OPTIONS) $(LOCAL_BUILT_MODULE): PRIVATE_PAGE_ALIGN_JNI_SHARED_LIBRARIES := $(LOCAL_PAGE_ALIGN_JNI_SHARED_LIBRARIES) ifneq ($(TARGET_BUILD_APPS),) # Include all resources for unbundled apps.