p96705831
/
platform_build
forked from openkylin/platform_build
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add performance* to default global tidy checks. 

* This enables 5 performance related checks:
    performance-faster-string-find
    performance-for-range-copy
    performance-implicit-cast-in-loop
    performance-unnecessary-copy-initialization
    performance-unnecessary-value-param
* Recognize these new warnings in warn.py.

Bug: http://b/27779618
Change-Id: I7af3fdc262dd44db90d3b62eb37c5eac5a2eaa01
Test: build with WITH_TIDY=1 and run warn.py with build.log
This commit is contained in:
Chih-Hung Hsieh 2016-07-26 14:27:03 -07:00
parent 900e9e6392
commit c868293abc
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/clang/tidy.mk
View File

@ -15,10 +15,12 @@
#
# Most Android source files are not clang-tidy clean yet.
# Global tidy checks include only google* and misc-macro-parentheses,
# but not google-readability* or google-runtime-references.
# Global tidy checks include only google*, performance*,
# and misc-macro-parentheses, but not google-readability*
# or google-runtime-references.
DEFAULT_GLOBAL_TIDY_CHECKS := \
-*,google*,-google-readability*,-google-runtime-references,misc-macro-parentheses
-*,google*,performance*,misc-macro-parentheses \
,-google-readability*,-google-runtime-references
# Disable style rules usually not followed by external projects.
# Every word in DEFAULT_LOCAL_TIDY_CHECKS list has the following format:

15
tools/warn.py
View File

@ -1773,6 +1773,21 @@ warnpatterns = [
{ 'category':'C/C++', 'severity':severity.TIDY, 'members':[], 'option':'',
'description':'clang-tidy misc',
'patterns':[r".*: .+\[misc-.+\]$"] },
{ 'category':'C/C++', 'severity':severity.TIDY, 'members':[], 'option':'',
'description':'clang-tidy performance-faster-string-find',
'patterns':[r".*: .+\[performance-faster-string-find\]$"] },
{ 'category':'C/C++', 'severity':severity.TIDY, 'members':[], 'option':'',
'description':'clang-tidy performance-for-range-copy',
'patterns':[r".*: .+\[performance-for-range-copy\]$"] },
{ 'category':'C/C++', 'severity':severity.TIDY, 'members':[], 'option':'',
'description':'clang-tidy performance-implicit-cast-in-loop',
'patterns':[r".*: .+\[performance-implicit-cast-in-loop\]$"] },
{ 'category':'C/C++', 'severity':severity.TIDY, 'members':[], 'option':'',
'description':'clang-tidy performance-unnecessary-copy-initialization',
'patterns':[r".*: .+\[performance-unnecessary-copy-initialization\]$"] },
{ 'category':'C/C++', 'severity':severity.TIDY, 'members':[], 'option':'',
'description':'clang-tidy performance-unnecessary-value-param',
'patterns':[r".*: .+\[performance-unnecessary-value-param\]$"] },
{ 'category':'C/C++', 'severity':severity.TIDY, 'members':[], 'option':'',
'description':'clang-tidy CERT',
'patterns':[r".*: .+\[cert-.+\]$"] },