mirrors
/
redis
mirror of https://mirror.osredm.com/root/redis.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix test failure due to differing reply format of XREADGROUP under RESP3 in MULTI (#13255) 

This test was introducted by #13251.
Normally we auto transform the reply format of XREADGROUP to array under
RESP3 (see trasformer_funcs).
But when we execute XREADGROUP command in multi it can't work, which
cause the new test failed.
The solution is to verity the reply of XREADGROUP in advance rather than
in MULTI.

Failed validate schema CI:
https://github.com/redis/redis/actions/runs/9025128323/job/24800285684

---------

Co-authored-by: guybe7 <guy.benoish@redislabs.com>
This commit is contained in:
debing.sun 2024-05-14 20:08:32 +08:00 committed by GitHub
parent 8a05f0092b
commit ffbdf2f6f3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unit/type/stream-cgroups.tcl
View File

@ -1398,11 +1398,10 @@ start_server {
$master del mystream
$master xadd mystream 1-0 a b c d e f
$master xgroup create mystream mygroup 0
$master xreadgroup group mygroup ryan count 1 streams mystream >
assert_equal [$master xreadgroup group mygroup ryan count 1 streams mystream >] {{mystream {{1-0 {a b c d e f}}}}}
$master multi
$master xreadgroup group mygroup ryan count 1 streams mystream 0
set reply [$master exec]
assert_equal $reply {{{mystream {{1-0 {a b c d e f}}}}}}
$master exec
}
}