6d69d5eac3
Fix libvirt_proxy.c warnings from gcc-4.4
...
libvirt_proxy.c: In function 'proxyReadClientSocket':
libvirt_proxy.c:659: error: dereferencing pointer 'req' does break strict-aliasing rules
libvirt_proxy.c:657: error: dereferencing pointer 'req' does break strict-aliasing rules
libvirt_proxy.c:655: error: dereferencing pointer 'req' does break strict-aliasing rules
...
2009-02-13 19:11:37 +00:00
9fec27be49
Fix bridge.c warnings with gcc-4.4
...
bridge.c: In function 'brSetInetAddr':
bridge.c:665: error: dereferencing pointer '({anonymous})' does break strict-aliasing rules
bridge.c:665: note: initialized from here
bridge.c:666: error: dereferencing pointer '({anonymous})' does break strict-aliasing rules
bridge.c:666: note: initialized from here
Fix qemud.c warnings with gcc-4.4
qemud.c: In function ‘remoteListenTCP’:
qemud.c:675: error: dereferencing pointer ‘sa.72’ does break strict-aliasing rules
qemud.c:675: note: initialized from here
qemud.c:678: error: dereferencing pointer ‘sa.73’ does break strict-aliasing rules
qemud.c:678: note: initialized from here
2009-02-13 19:10:55 +00:00
7d2b7ad520
Fix migrate for Xen 3.3
2009-02-13 18:23:23 +00:00
f98b9e05d8
test:///default driver: don't dereference NULL "def"
...
* src/test.c (testNetworkCreate, testNetworkDefine): Since "def" is
set to NULL immediately after any vir*AssignDef call (to indicate we
no longer own it and to ensure no clean-up path mistakenly frees it),
dereference via net->def->, not def->.
2009-02-13 18:11:03 +00:00
6efe591e66
usleep to wait for domain logfile to fill up
2009-02-13 11:35:16 +00:00
e9c920ba67
fix return status when domain didn't show up
2009-02-11 20:33:11 +00:00
98352a103b
libvirtd: new config-file option: unix_sock_dir
...
Before this change, the unix socket directory was hard-coded
to be e.g., /var/run/libvirt for euid==0 and ~/.libvirt otherwise.
With this change, you may now specify that directory in libvirtd's
config file via a line like this: unix_sock_dir = "/var/run/libvirt".
This is essential for running tests that do not impinge on any
existing libvirtd process, and in running tests in parallel.
* qemud/libvirtd.conf (unix_sock_dir): Add comment and example.
* qemud/qemud.h (struct qemud_server) [logDir]: Change type
from char[PATH_MAX] to char*.
* qemud/qemud.c (unix_sock_dir): New global
(remoteReadConfigFile): Set the global.
(qemudInitPaths): Use the global, unix_sock_dir, if non-NULL.
One minor improvement: unlink both sockets or none, never
just one of them.
(qemudCleanup): Free logDir.
(main): Use the new global rather than hard-coding "/run/libvirt".
* qemud/libvirtd.aug (sock_acl_entry): Add "unix_sock_dir".
2009-02-09 17:52:38 +00:00
3557096d44
don't print uninitialized in debug diagnostic
...
* qemud/mdns.c (libvirtd_mdns_timeout_new): Don't use local, t,
uninitialized.
2009-02-09 15:38:06 +00:00
b92d7e761c
avoid two test failures induced by today's error-reporting changes
...
* tests/cpuset: Adjust expected diagnostic to match new behavior.
* tests/undefine: Likewise.
2009-02-09 15:31:34 +00:00
f84c166013
Improve error reporting in virsh
2009-02-09 14:24:06 +00:00
fa7f51b813
introduce virSaveLastError(), virFreeError()
2009-02-09 14:16:23 +00:00
1290b28f59
Limit virsh history entries to 500 (Jim Paris)
2009-02-09 10:24:27 +00:00
0437e75291
Don't ignore errors to save domain status
2009-02-07 21:36:06 +00:00
9a86716446
Fix 100% libvirt CPU usage when --timeout is set
2009-02-06 14:43:52 +00:00
31135bff29
src/domain_conf.c: Check the last error, not the last
...
connection error, which may not have been set.
2009-02-05 19:29:37 +00:00
003f354917
xenstore: Use virMacAddrCompare() for case-insensitive comparison
2009-02-05 18:14:00 +00:00
b8b4fd4c7d
report error for some xend operations on shutdown domain
2009-02-05 17:24:51 +00:00
bc68ae8060
robustify sexpr parser for NICs
2009-02-05 17:17:33 +00:00
3909c7d3ed
syntax-check: enable prohibit_nonreentrant
...
* .x-sc_prohibit_nonreentrant: Add src/console.c and virterror.c.
* Makefile.cfg (local-checks-to-skip): Don't exempt
sc_prohibit_nonreentrant.
* Makefile.nonreentrant: Don't exempt strerror.
2009-02-05 16:28:41 +00:00
bafd7389e4
remove remainder of offending strerror uses
...
* qemud/qemud.c (GET_CONF_STR): Use virStrerror, not strerror.
* qemud/remote.c (remoteDispatchDomainBlockPeek): Likewise.
(remoteDispatchDomainMemoryPeek, remoteDispatchAuthSaslInit): Likewise.
(remoteDispatchAuthPolkit): Likewise.
* src/lxc_container.c (lxcContainerAvailable): Likewise.
* src/network_driver.c (networkStartNetworkDaemon): Likewise.
(networkShutdownNetworkDaemon): Likewise.
* src/qemu_conf.c (qemudExtractVersion, qemudNetworkIfaceConnect):
* src/storage_conf.c (virStoragePoolLoadAllConfigs): Likewise.
* src/storage_driver.c (storagePoolUndefine): Likewise.
* src/uml_driver.c (umlStartup, umlStartVMDaemon): Likewise.
* src/util.c (virFileReadAll): Likewise.
* src/uuid.c (virUUIDGenerate): Likewise.
* src/xen_internal.c (get_cpu_flags): Likewise.
2009-02-05 16:28:30 +00:00
d22a844b46
don't include raw errno in diagnostics
...
* src/uml_driver.c (umlStartVMDaemon): Don't print raw errno value.
* qemud/remote.c (remoteDispatchAuthSaslInit): Likewise.
2009-02-05 16:28:15 +00:00
d2758fa13e
qemud.c: use virStrerror, not strerror
2009-02-05 16:28:03 +00:00
1e31bfb055
iptables.c: Use virStrerror, not strerror.
...
* src/iptables.c: Include "virterror_internal.h".
Use virStrerror, not strerror.
* src/iptables.c (notifyRulesUpdated): Use %s rather than
string-concatenation that made sc_unmarked_diagnostics report
a false-positive.
2009-02-05 16:27:51 +00:00
dcfa920aff
use virReportOOMError rather than more verbose equivalent
...
* src/qemu_driver.c (qemudDomainSave, qemudDomainRestore)
(qemudDomainAttachPciDiskDevice)
(qemudDomainAttachUsbMassstorageDevice):
2009-02-05 16:27:40 +00:00
e60430be53
qemu_driver.c: s/strerror/virStrerror.../
...
Perform most changs automatically, with this:
perl -pi -e 's/\bstrerror *\((.+?)\)/virStrerror($1, ebuf, sizeof ebuf)/'
Then, declare ebuf, as needed
2009-02-05 16:27:28 +00:00
b0d49913d5
remove duplicate *SetCloseExec and *SetNonBlock functions
...
* src/qemu_driver.c: Use virSetCloseExec and virSetNonBlock,
rather than qemuSet* functions. Suggested by Daniel P. Berrange.
* src/util.c (virSetCloseExec): Publicize.
* src/util.h (virSetCloseExec): Declare
* src/libvirt_private.syms: Add virSetCloseExec.
2009-02-05 16:27:17 +00:00
22c9bf6d8b
ChangeLog: correct date formats one last time
2009-02-05 16:25:32 +00:00
caea9c00e3
qemu_driver.c: use virReportSystemError in place of some qemudLog uses
...
...thus eliminating many uses of strerror.
(kvmGetMaxVCPUs): Rather than merely warning, diagnose an error
and return -1 upon failure to open KVM_DEVICE. Suggested by
Daniel P. Berrange.
2009-02-05 16:11:25 +00:00
7bc569dda9
publicize virStrerror
...
* src/virterror.c (virStrerror): Remove "static".
* src/virterror_internal.h (virStrerror): Declare it.
* src/libvirt_private.syms: Add virStrerror;
2009-02-05 16:10:07 +00:00
a9aa76bad5
remove useless code
...
* src/bridge.c (brAddTap): Remove redundant errno=ENOMEM assignment
after failed strdup.
* src/cgroup.c (virCgroupFree): Remove redundant *group=NULL assignment
after VIR_FREE(*group).
* src/lxc_driver.c (lxcShutdown): Likewise.
* src/xen_unified.c (xenUnifiedClose): Likewise.
* src/xm_internal.c (xenXMDomainConfigFormat): Rewrite disk-
and net-config-setting code to be clearer.
2009-02-05 16:03:11 +00:00
7faa50d1db
lxc_container: Don't dereference NULL upon failure
...
* src/lxc_container.c (lxcContainerPivotRoot): Free and zero
oldroot *after* printing the diagnostic, both for virFileMakePath
and pivot_root failure.
2009-02-05 15:28:19 +00:00
41549b3888
ChangeLog: reformat recent date/name/email lines
2009-02-03 21:12:22 +00:00
6778ad0f07
avoid a format-related warning
...
* src/qemu_driver.c (qemudStartVMDaemon): Use "%s".
2009-02-03 13:09:18 +00:00
dff2114795
build: enable redundant-const check
...
* Makefile.cfg (local-checks-to-skip): Remove sc_redundant_const.
* src/lxc_controller.c: Remove redundant "const"(s).
* src/storage_backend_fs.c: Likewise.
* src/util.h: Likewise.
* src/xen_internal.c: Likewise.
* tests/qparamtest.c: Likewise.
2009-02-03 13:08:59 +00:00
08f87e3d03
syntax-check: enable more checks
...
* Makefile.cfg (local-checks-to-skip): Don't skip sc_m4_quote_check.
Don't skip sc_prohibit_nonreentrant.
* Makefile.nonreentrant (NON_REENTRANT): Comment out until we've
remove all remaining uses of strerror.
2009-02-03 13:08:36 +00:00
c18ccff446
cleanup: remove useless if-before-VIR_FREE
...
* Makefile.cfg (useless_free_options): Also check for VIR_FREE.
* src/iptables.c (iptRulesFree): Remove useless if-before-VIR_FREE.
* src/remote_internal.c (remoteAuthSASL): Likewise.
* src/test.c (testOpenFromFile): Likewise.
2009-02-03 13:08:07 +00:00
d26c3387df
tests: diagnose more open failures
...
* tests/qemuxml2argvtest.c: Revert the change,
"tests: diagnose open failure" of 2009-01-30.
* tests/testutils.c (virtTestLoadFile): Diagnose failure here.
2009-02-02 20:35:14 +00:00
66929686c4
fix more printf("%s", NULL) cases
2009-02-02 18:41:56 +00:00
e69b20d616
Don't hardcode ssh port 22, use VIR_FREE, initialize pointers to NULL not 0.
2009-01-31 13:49:11 +00:00
4a5dfb847b
Release of 0.6.0
...
* configure.in docs/* NEWS: release of 0.6.0
* po/*: regenerated and updated brazilian and polish localizations
daniel
2009-01-31 11:46:29 +00:00
42fea976df
* docs/news.html*: update with infos for 0.6.0
...
* docs/*: regenerated some data too
daniel
2009-01-31 09:14:58 +00:00
cf1b0f868b
tests: diagnose open failure
...
* tests/qemuxml2argvtest.c (testCompareXMLToArgvFiles): Diagnose
failure to open an input file.
2009-01-30 21:59:35 +00:00
f92e9f599b
Fix empty declaration in enum declaration
2009-01-30 21:52:22 +00:00
f34ba729ff
Added missing shared disk test case
2009-01-30 21:49:12 +00:00
a119a98081
fix qemud version reporting when qemu is not installed
...
* src/qemu_conf.c (uname_normalize): New function, factored out of...
(qemudBuildCommandLine): ...here. Use the new function.
(qemudExtractVersion): Use it here, rather than hard-coding "i686".
2009-01-30 19:57:20 +00:00
a6ef2e0055
Fix ifname= passing to QEMU for type=ethernet network config
2009-01-30 17:17:58 +00:00
67e7416119
Support disk caching mode config
2009-01-30 17:15:39 +00:00
3cb55cb51f
Fix crash using bogus arch in QEMU
2009-01-30 17:12:28 +00:00
896761e5c7
Fix numerous bugs in QEMU domain startup
2009-01-30 17:07:29 +00:00
05436ab7ff
Fix valgrind crash in LXC & avoid probing unneccessarily
2009-01-30 16:51:33 +00:00
Mark McLoughlin