openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity
1,193 Commits 7 Branches 581 Tags 800 MiB
Commit Graph

1193 Commits

Author SHA1 Message Date
Daniel P. Berrange 7ae13660cf Don't set MAC on TAP devs. Pass TAP device name to QEMU 2008-03-14 20:30:03 +00:00
Daniel Veillard 8885191702 * po/*: updated translations 
Daniel
 2008-03-14 15:57:02 +00:00
Daniel Veillard 62b4c870aa typo 
* src/bridge.c: fix a typo in a comment
Daniel
 2008-03-14 15:31:08 +00:00
Daniel Veillard a7892ee000 String fixes #436620 
* qemud/qemud.c src/virsh.c: fixing some user facing strings
  problems pointed out by Francesco Tombolini should fix #436620
Daniel
 2008-03-14 15:21:15 +00:00
Daniel Veillard 384f26525f Small cleanup, Daniel 2008-03-14 11:14:41 +00:00
Richard W.M. Jones 3e59e29859 Fix typo "informations" -> "information" (Atsushi SAKAI and 
Saori FUKUTA).
 2008-03-14 11:08:03 +00:00
Daniel Veillard adbf991a1d * src/libvirt.c: virDomainSetSchedulerParameters need to be 
blocked on read-only connections, patch from Saori Fukuta
Daniel
 2008-03-13 09:27:46 +00:00
Daniel Veillard dc232cdf1b * src/bridge.c src/virsh.c: typo fixes from Atsushi SAKAI 
daniel
 2008-03-13 09:21:41 +00:00
Daniel Veillard af1c7f96a8 * src/qemu_conf.c src/qemu_driver.c: patch from Cole Robinson 
fixing CD Rom change on live QEmu/KVM domains.
Daniel
 2008-03-13 09:17:45 +00:00
Daniel P. Berrange 77ed8ded7b Remove unused variable 2008-03-11 16:01:23 +00:00
Daniel P. Berrange 8d2d44ad05 Remove use of polkit-grant. Keep stdio open when running polkit-auth 2008-03-11 14:49:04 +00:00
Daniel P. Berrange c3501d4792 Don't force Xen connections to readonly when non-root 2008-03-11 14:25:49 +00:00
Daniel P. Berrange 028e4a6116 Don't run cleannup code for parent process in daemon mode 2008-03-11 14:22:12 +00:00
Daniel Veillard f5ade63437 * docs/libvir.html docs/storage.html: apply documentation fixes 
and typos cleanup from Atsushi Sakai
Daniel
 2008-03-07 11:13:02 +00:00
Daniel Veillard d4cbf4c624 * src/xend_internal.c: applied patch from Cole Robinson to not 
loose the boot tag when defining a fully virtualized xen domain
Daniel
 2008-03-07 09:23:30 +00:00
Richard W.M. Jones 2a4c20437d Make iSCSI login actually work 
* src/storage_backend_iscsi.c: Make iSCSI login actually work
	  (Chris Lalancette).
 2008-03-04 20:02:34 +00:00
Richard W.M. Jones 4d6a8a1c0a Report error when vcpupin is given bad vCPU number. 
* src/virsh.c: Report error when vcpupin is given bad vCPU number
	  (Shigeki Sakamoto).
 2008-03-04 19:59:56 +00:00
Jim Meyering 0075d7e74a fix typo in comment 2008-03-03 23:06:02 +00:00
Jim Meyering 869f8d0e7d Also ignore leading zeros when comparing MAC addresses. 
* src/util.c: Include <ctype.h>.
(TOLOWER): Define.
(__virMacAddrCompare): Rewrite to also ignore leading zeros.
 2008-03-03 20:39:52 +00:00
Daniel Veillard 65c4379c53 * src/capabilities.c: Cole Robinson pointed out a well formedness 
problem when generating the capabilities in the test driver.
Daniel
 2008-03-03 20:21:21 +00:00
Jim Meyering 4090a0870c Don't use first byte of string as a pointer. 
* src/qemu_conf.c (qemudReportError): Use the pointer, errorMessage,
not its first byte, errorMessage[0].
 2008-03-03 18:11:16 +00:00
Jim Meyering f9e94c2e13 Avoid segfault upon early libvirtd failure. 
* qemud/qemud.c (main): Don't call qemudCleanup on an
uninitialized pointer.
 2008-03-03 18:10:19 +00:00
Daniel Veillard 6a17c6c652 Release of 0.4.1 
* NEWS configure.in libvirt.spec.in docs/* include/libvirt/libvirt.h
  po/*: preparing release of libvirt-0.4.1
Daniel
 2008-03-03 14:42:37 +00:00
Jim Meyering 6272a7d0c2 Plug saslUsernameWhitelist leak. 
* qemud/qemud.c (qemudCleanup): Free the array as well as
the strings in it.
 2008-03-03 13:17:05 +00:00
Jim Meyering cd6eefd3e8 Plug skipped-qemudCleanup leak. 
* qemud/qemud.c (main): Call qemudCleanup also upon failure.
Otherwise, an error return would skip it and induce leaks.
 2008-03-03 13:16:31 +00:00
Jim Meyering ba8459e859 Plug remoteReadConfigFile leak. 
* qemud/qemud.c (remoteReadConfigFile): Be careful to free
"conf" after a successful virConfReadFile.
 2008-03-03 13:15:57 +00:00
Jim Meyering 1de5bace80 Plug two leaks: host.migrateTrans and arch.name 
* src/capabilities.c (virCapabilitiesFree): Free host.migrateTrans.
(virCapabilitiesFreeGuest): Free arch.name member.
 2008-03-03 13:15:14 +00:00
Jim Meyering 47a4c0fa0b Plug virCapabilities*GuestDomain leak. 
* src/capabilities.c (virCapabilitiesFreeGuestDomain): Free dom->type.
(virCapabilitiesAddGuestDomain): Remove duplicate strdup stmt.
 2008-03-03 13:14:26 +00:00
Daniel Veillard 3e1aaf27fe missing comments for _virDomainBlockStats fields 
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in:
  missing comments for _virDomainBlockStats fields
* docs/*: rebuilt docs
Daniel
 2008-03-03 06:18:06 +00:00
Daniel Veillard 39947cec85 fix a broken line split 
* qemud/Makefile.am: fix a broken line split
Daniel
 2008-02-29 17:02:41 +00:00
Richard W.M. Jones bb8340c18d Many typos fixed (Atsushi SAKAI). 2008-02-29 12:53:10 +00:00
Jim Meyering ba52fcbcdf Rewrite test-coverage rules to accommodate multiple .o files per .c. 
* src/Makefile.am (cov): Rewrite rule to merge gcov results corresponding
to two .o files: the libvirt_la- one, and the libvirt_test_la- one.
(tst): Remove unused rule.
* configure.in (LV_LIBTOOL_OBJDIR): Define and AC_SUBST.
 2008-02-28 17:07:37 +00:00
Jim Meyering 9262d88e28 Avoid link errors with "configure --disable-shared". 
* src/Makefile.am: Create a convenience library, libvirt_test.la,
and don't restrict access to *its* symbols.
* tests/Makefile.am (LDADDS): Add ../src/libvirt_test.la, so that
"configure --disable-shared" no longer provokes link errors.
(LIBVIRT): Remove definition.
(LDADDS): Remove use.
($(LIBVIRT)): Remove rule.
(LDADDS): Use the new convenience library instead.
(CLEANFILES): Define.
* docs/examples/index.py (dump_Makefile): Append $(COVERAGE_LDFLAGS),
to the LDADDS definition, to avoid link error with the combination of
--enable-test-coverage and --disable-shared.
* docs/examples/Makefile.am: Regenerate.
* docs/examples/index.html: Likewise.
* qemud/Makefile.am (libvirtd_LDFLAGS): Append $(COVERAGE_LDFLAGS).
* src/libvirt_sym.version: Remove some SP-before-TAB.
 2008-02-28 17:06:32 +00:00
Daniel Veillard 004ff90483 Fix qemudReportError. 
* src/qemu_conf.c: applied patch from Cole Robinson to use virErrorMsg
  in qemudReportError.
Daniel
 2008-02-28 11:17:49 +00:00
Richard W.M. Jones 26e12450bb Typo. 2008-02-28 11:01:17 +00:00
Daniel P. Berrange 9699e372c2 Set MAC address on TUN device for Xenner compatability 2008-02-28 01:23:14 +00:00
Jim Meyering 46b427a310 Make qemud/'s rpcgen rules work. 
* qemud/Makefile.am (SUFFIXES): Define to .x before implicit rule.
 2008-02-27 19:12:58 +00:00
Richard W.M. Jones 92a1e14b0b virMacAddrCompare for comparing MAC addresses 
* src/util.c, src/util.h, src/libvirt_sym.version: Added
	  virMacAddrCompare utility function for comparing MAC
	  addresses.
	* src/virsh.c, src/xm_internal.c: Use virMacAddrCompare
	  to compare addresses.  (Shigeki Sakamoto and Richard Jones).
 2008-02-27 16:14:44 +00:00
Jim Meyering fa4ab3325b Avoid "make distcheck" failure. 
* src/Makefile.am (virsh_SOURCES): Add util-lib.h.
 2008-02-27 15:17:45 +00:00
Jim Meyering d7cdc28431 Fix a "make syntax-check" failure. 
* src/capabilities.c: Include <config.h> from the .c file,
* src/capabilities.h: ... not from the .h file.
 2008-02-27 14:40:19 +00:00
Richard W.M. Jones b4882504ea Fix typos (Atsushi SAKAI). 2008-02-27 10:37:19 +00:00
Daniel P. Berrange 63bc5dd3e1 Add formal internal capabilities API and update drivers to use it 2008-02-27 04:35:08 +00:00
Richard W.M. Jones 727c5601ec Implement virDomainBlockStats for QEMU/KVM. 
* src/qemu_driver.c: Implement virDomainBlockStats for QEMU/KVM
	  using QEMU/KVM 'info blockstats' command (Richard Jones).
	* src/qemu_driver.c, src/qemu_conf.h: const-correctness
	  fixes (Jim Meyering).
 2008-02-26 18:41:43 +00:00
Richard W.M. Jones 242fe3d401 No address attribute in Xen domain XML. 
* src/xm_internal.c: handle the case where <mac/> clause
	  in Xen domain interface has no address attribute
	  (Shigeki Sakamoto).
 2008-02-26 18:31:57 +00:00
Daniel Veillard ea47a7d4e4 Oops trailing blank, Daniel 2008-02-26 07:06:48 +00:00
Daniel Veillard 36c6bfa63d * src/driver.h src/libvirt.c src/openvz_driver.c src/qemu_driver.c 
src/remote_internal.c src/test.c src/util.c src/util.h
  src/xen_unified.c: added probe interface at the driver level,
  use that to improve default hypervisor selection in the absence
  of a given URI when connecting
Daniel
 2008-02-26 07:05:18 +00:00
Daniel Veillard 9b1cd481b8 fix compilation against static libraries 
* src/Makefile.am src/util-lib.h: fix done with Jim to allow
  compilation of virsh with the static libraries.
Daniel
 2008-02-25 13:55:56 +00:00
Jim Meyering e497deb89e Avoid new "make syntax-check" failures. 
* .x-sc_avoid_write: Exempt src/util-lib.c, too.
* Makefile.maint (sc_unmarked_diagnostics): Filter out false positives.
* src/storage_backend_fs.c (virStorageBackendFileSystemVolCreate):
Use safewrite, not write.
* src/storage_backend_logical.c (virStorageBackendLogicalBuildPool): Likewise.
 2008-02-25 10:00:16 +00:00
Jim Meyering b1b23f76be avoid format string warnings 
Avoid warnings like this:
file:nnn:format not a string literal and no format arguments

* qemud/qemud.c: Insert a "%s" format argument.
* qemud/remote.c: Likewise.
* src/iptables.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/storage_backend.c: Likewise.
* src/storage_backend_fs.c: Likewise.
* src/storage_backend_iscsi.c Likewise.
* src/storage_backend_logical.c: Likewise.
* src/storage_conf.c: Likewise.
* src/storage_driver.c: Likewise.
 2008-02-22 16:26:13 +00:00
Jim Meyering b59d9c85f1 Use safewrite in place of write, in many cases. 
Also add "make syntax-check" rules to ensure no new uses sneak in.

There are many uses of write like this:

    if (write (fd, xml, towrite) != towrite)
        return -1;

The problem is that the syscall can succeed, yet write less than
the requested number of bytes, so the caller should retry
rather than simply failing.

This patch changes most of them to use util.c's safewrite wrapper,
which encapsulates the process.  Also, there were a few cases in
which the retry loop was open-coded, and I replaced those, too.

* Makefile.maint (sc_avoid_write): New rule, to avoid recurrence.
* .x-sc_avoid_write: New file.  Record two legitimate exemptions.
* qemud/qemud.c (sig_handler, qemudClientWriteBuf): Use safewrite, not write.
* src/conf.c (__virConfWriteFile): Likewise.
* src/qemu_conf.c (qemudSaveConfig, qemudSaveNetworkConfig): Likewise.
* src/qemu_driver.c (qemudWaitForMonitor, qemudStartVMDaemon)
(qemudVMData, PROC_IP_FORWARD): Likewise.
* proxy/libvirt_proxy.c: Include "util.h".
(proxyWriteClientSocket): Use safewrite.
* src/test.c (testDomainSave, testDomainCoreDump): Likewise.
* src/proxy_internal.c (virProxyWriteClientSocket): Likewise.
* src/virsh.c: Include "util-lib.h".
(vshOutputLogFile): Use safewrite.
* src/console.c: Include "util-lib.h".
(vshRunConsole): Use safewrite.
 2008-02-22 15:55:04 +00:00