Ingo Molnar 58d5d0d8dd x86: fix deadlock, make pgd_lock irq-safe ... lockdep just caught this one: ================================= [ INFO: inconsistent lock state ] 2.6.24 #38 --------------------------------- inconsistent {in-softirq-W} -> {softirq-on-W} usage. swapper/1 [HC0[0]:SC0[0]:HE1:SE1] takes: (pgd_lock){-+..}, at: [<ffffffff8022a9ea>] mm_init+0x1da/0x250 {in-softirq-W} state was registered at: [<ffffffffffffffff>] 0xffffffffffffffff irq event stamp: 394559 hardirqs last enabled at (394559): [<ffffffff80267f0a>] get_page_from_freelist+0x30a/0x4c0 hardirqs last disabled at (394558): [<ffffffff80267d25>] get_page_from_freelist+0x125/0x4c0 softirqs last enabled at (393952): [<ffffffff80232f8e>] __do_softirq+0xce/0xe0 softirqs last disabled at (393945): [<ffffffff8020c57c>] call_softirq+0x1c/0x30 other info that might help us debug this: no locks held by swapper/1. stack backtrace: Pid: 1, comm: swapper Not tainted 2.6.24 #38 Call Trace: [<ffffffff8024e1fb>] print_usage_bug+0x18b/0x190 [<ffffffff8024f55d>] mark_lock+0x53d/0x560 [<ffffffff8024fffa>] __lock_acquire+0x3ca/0xed0 [<ffffffff80250ba8>] lock_acquire+0xa8/0xe0 [<ffffffff8022a9ea>] ? mm_init+0x1da/0x250 [<ffffffff809bcd10>] _spin_lock+0x30/0x70 [<ffffffff8022a9ea>] mm_init+0x1da/0x250 [<ffffffff8022aa99>] mm_alloc+0x39/0x50 [<ffffffff8028b95a>] bprm_mm_init+0x2a/0x1a0 [<ffffffff8028d12b>] do_execve+0x7b/0x220 [<ffffffff80209776>] sys_execve+0x46/0x70 [<ffffffff8020c214>] kernel_execve+0x64/0xd0 [<ffffffff8020901e>] ? _stext+0x1e/0x20 [<ffffffff802090ba>] init_post+0x9a/0xf0 [<ffffffff809bc5f6>] ? trace_hardirqs_on_thunk+0x35/0x3a [<ffffffff8024f75a>] ? trace_hardirqs_on+0xba/0xd0 [<ffffffff8020c1a8>] ? child_rip+0xa/0x12 [<ffffffff8020bcbc>] ? restore_args+0x0/0x44 [<ffffffff8020c19e>] ? child_rip+0x0/0x12 turns out that pgd_lock has been used on 64-bit x86 in an irq-unsafe way for almost two years, since commit 8c914cb704. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>		2008-02-06 22:39:45 +01:00
..
Makefile	x86_64: move mm	2007-10-11 11:17:18 +02:00
Makefile_32	x86: unify fault_32|64.c	2008-01-30 13:34:11 +01:00
Makefile_64	x86: unify fault_32|64.c	2008-01-30 13:34:11 +01:00
discontig_32.c	x86: make NUMA work on 32-bit	2008-01-30 13:33:25 +01:00
extable.c	x86: unify extable_{32|64}.c	2008-01-30 13:31:41 +01:00
fault.c	x86: fix deadlock, make pgd_lock irq-safe	2008-02-06 22:39:45 +01:00
highmem_32.c	x86: kmap_atomic() debugging	2008-01-30 13:30:47 +01:00
hugetlbpage.c	x86: demacro asm-x86/pgalloc_32.h	2008-01-30 13:33:39 +01:00
init_32.c	x86: use _ASM_EXTABLE macro in arch/x86/mm/init_32.c	2008-02-04 16:47:58 +01:00
init_64.c	x86: mark the .rodata section also NX	2008-02-06 22:39:45 +01:00
ioremap.c	x86: no CPA on iounmap	2008-02-04 16:48:05 +01:00
k8topology_64.c	x86: add PCI IDs to k8topology_64.c	2008-01-30 13:34:12 +01:00
mmap.c	x86: unify mmap_{32|64}.c	2008-01-30 13:31:10 +01:00
numa_64.c	x86: print out node_data addr and bootmap_start addr	2008-02-04 16:47:56 +01:00
pageattr-test.c	x86: delay CPA self-test and repeat it	2008-02-06 22:39:45 +01:00
pageattr.c	x86: remove suprious ifdefs from pageattr.c	2008-02-06 22:39:45 +01:00
pgtable_32.c	add mm argument to pte/pmd/pud/pgd_free	2008-02-05 09:44:18 -08:00
srat_64.c	x86: fix section mismatch warning in srat_64.c	2008-01-30 13:33:37 +01:00