linux/sound/firewire/motu
Takashi Sakamoto 3fd80b2003 ALSA: firewire-motu: use the same size of period for PCM substream in AMDTP streams
In current implementation, when opening a PCM substream, it's needed to
check whether the opposite PCM substream runs. This is to assign
effectual constraints (e.g. sampling rate) to opened PCM substream.

The number of PCM substreams and MIDI substreams on AMDTP streams in
domain is recorded in own structure. Usage of this count is an
alternative of the above check. This is better because the count is
incremented in pcm.hw_params earlier than pcm.trigger.

This idea has one issue because it's incremented for MIDI substreams as
well. In current implementation, for a case that any MIDI substream run
and a PCM substream is going to start, PCM application to start the PCM
substream can decide hardware parameters by restart packet streaming.
Just checking the substream count can brings regression.

Now AMDTP domain structure has a member for the size of PCM period in
PCM substream which starts AMDTP streams in domain. When the value has
zero and the substream count is greater than 1, it means that any MIDI
substream starts AMDTP streams in domain. Usage of the value can resolve
the above issue.

This commit replaces the check with the substream count and the value for
the size of PCM period.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20191007110532.30270-17-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2019-10-17 12:02:46 +02:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
amdtp-motu-trace.h ASoC: Updates for v5.3 2019-07-08 14:45:34 +02:00
amdtp-motu.c ALSA: firewire-motu: more code refactoring for MOTU data block processing layer 2019-07-22 16:05:13 +02:00
motu-hwdep.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
motu-midi.c ALSA: firewire-motu: register the size of PCM period to AMDTP domain 2019-10-17 12:02:43 +02:00
motu-pcm.c ALSA: firewire-motu: use the same size of period for PCM substream in AMDTP streams 2019-10-17 12:02:46 +02:00
motu-proc.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
motu-protocol-v2.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
motu-protocol-v3.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
motu-stream.c ALSA: firewire-motu: register the size of PCM period to AMDTP domain 2019-10-17 12:02:43 +02:00
motu-transaction.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
motu.c ALSA: firewire-motu: add support for MOTU 4pre 2019-08-30 07:34:28 +02:00
motu.h ALSA: firewire-motu: register the size of PCM period to AMDTP domain 2019-10-17 12:02:43 +02:00