am skip reason: Change-Id I5bbb2d2b733bbd6b868898285683ba5ff45be10b with SHA-1 243688ea1b is in history
Change-Id: I840c08b59f1cfabfe823f6814273abe7e7aa16f3
am skip reason: Change-Id I163223caed38161ce1fa7b96dc3772194c32c3e2 with SHA-1 97b53b83e4 is in history
Change-Id: If94fdbe0881259ea0212bb794bebc39abc881bf3
am skip reason: Change-Id I13df3115f9e225f7324b6725eaeb16a78cc2538a with SHA-1 afa9fa104d is in history
Change-Id: If85da3292291c60cf41d628b7cd76763ed836929
am skip reason: Change-Id I825c6df09058fb3a45db196661959eb332aca2f3 with SHA-1 c988c8e202 is in history
Change-Id: I0c15f9380a1f13704cb294203e8f7a4a29fca8ad
am skip reason: Change-Id If5427afb2470a7dffbd418e1c405af508577ad93 with SHA-1 255a570e6d is in history
Change-Id: I704849f1cf04ab8fffb5b0e8f2a0e8a4e5a8ac3b
am skip reason: Change-Id I7e169bd9b6e51b88e35bdf8673a5056337f778c1 with SHA-1 b28369a982 is in history
Change-Id: I5bc9597568346cbcefc683bf6e0e000259abfd7b
am skip reason: Change-Id Ie83c1ffbb71fd5d7a08d350571dad3e3209b1431 with SHA-1 f34f6d8538 is in history
Change-Id: I6dc31683fc0d71eb00990ae43795c9ed30a4adb6
Needed for follow up changes.
Test: m checkapi
Bug: 155164730
Merged-In: I163223caed38161ce1fa7b96dc3772194c32c3e2
Change-Id: I163223caed38161ce1fa7b96dc3772194c32c3e2
(cherry picked from commit 97b53b83e4)
Previously, the only way for a module type to create modules (other
than defining its own mutator) was to register a LoadHook. However,
that is called before defaults are applied so any properties used in
that hook cannot take advantage of defaults, e.g. java_sdk_library
cannot use defaults to set its sdk_version property and have that
affect its child modules.
This change adds a new SetDefaultableHook() to DefaultableModule to
register a hook that is called after any defaults have been applied.
Also adds some tests to ensure that errors in the visibility property
introduced in a DefaultableHook are reported in the gather phase of
visibility processing.
A follow up change will switch java_sdk_library to use that instead
of the AddLoadHook() mechanism.
Bug: 155295806
Test: m checkapi
Merged-In: I13df3115f9e225f7324b6725eaeb16a78cc2538a
Change-Id: I13df3115f9e225f7324b6725eaeb16a78cc2538a
(cherry picked from commit afa9fa104d)
A follow up change will add a mechanism for a module to register a hook
that is called after any defaults have been applied. That is intended
for use by modules like java_sdk_library that create child modules that
are dependent upon properties that could be supplied by defaults.
Creating those child modules after prebuilts mutators are run will
cause problems if those child modules clash with prebuilts modules.
Moving the prebuilts mutators after the defaults mutators will fix
that.
Tests are currently being run with the mutators in different orders so
this change also cleans that up so they are consistent with the actual
code that is being run.
Bug: 155295806
Test: m checkbuild
Merged-In: I825c6df09058fb3a45db196661959eb332aca2f3
Change-Id: I825c6df09058fb3a45db196661959eb332aca2f3
(cherry picked from commit c988c8e202)
Refactors the existing code to wrap a getter with a structure in order
to simplify adding additional per-property information. Adds an
emptyValue field to contain the empty value appropriate for the field
type.
Bug: 155628860
Test: m nothing
Merged-In: I7e169bd9b6e51b88e35bdf8673a5056337f778c1
Change-Id: I7e169bd9b6e51b88e35bdf8673a5056337f778c1
(cherry picked from commit b28369a982)
This allows additional metadata to be associated with a set of
properties that will be used in a follow up change to filter
properties that are ignored in some variants (e.g. host variants).
Bug: 155628860
Test: m nothing
Merged-In: Ie83c1ffbb71fd5d7a08d350571dad3e3209b1431
Change-Id: Ie83c1ffbb71fd5d7a08d350571dad3e3209b1431
(cherry picked from commit f34f6d8538)
am skip reason: Change-Id Ia8383b9d1272bb12c8a83948753a0e4b0d98a650 with SHA-1 cdfcec98bb is in history
Change-Id: I509ac95c14a376e99859c1bb5d27bf1246d3d787
This makes it consistent with android_app. Also, most android_app_import
modules with JNI libs target a single arch.
(This is a cherry-pick change.)
Test: TreeHugger
Bug: 154281342
Change-Id: I5bbb2d2b733bbd6b868898285683ba5ff45be10b
Merged-In: I5bbb2d2b733bbd6b868898285683ba5ff45be10b
- We can pass all targets at once to build-aml-prebuilts.sh.
- Less noise from build-mainline-modules.sh.
- Default to the same out directory in both build scripts.
- Addressed post-submit comments on https://r.android.com/1170907.
- Various minor cleanups.
Test: build/soong/scripts/build-mainline-modules.sh
Change-Id: Id21ef80c2334462836e217032fc5bf63b7cd04e1
am skip reason: Change-Id Ia1a5510b57d58748b4655473d4585636deb7f45e with SHA-1 194c43f5a7 is in history
Change-Id: Ia811f37681c1bcbd594ecc2fa3669440094213e9
They are now explicit in the Bionic blueprints, and brought in through
dependencies on libc (which in turn is usually implicit through the
default system_shared_libs value). Modules that may break are cc_object
which don't depend on system_shared_libs, and those that explicitly set
system_shared_libs:[] but still assumes libc headers. In either case
the fix should be to add header_libs:["libc_headers"].
Test: Build and boot
Test: m checkbuild (on aosp_taimen and aosp_x86_64)
Bug: 153590472
Change-Id: I3217d8f36e49a987f5377866c8647f9dcccc37ce
Refactors the existing code to wrap a getter with a structure in order
to simplify adding additional per-property information. Adds an
emptyValue field to contain the empty value appropriate for the field
type.
Bug: 155628860
Test: m nothing
Change-Id: I7e169bd9b6e51b88e35bdf8673a5056337f778c1
This allows additional metadata to be associated with a set of
properties that will be used in a follow up change to filter
properties that are ignored in some variants (e.g. host variants).
Bug: 155628860
Test: m nothing
Change-Id: Ie83c1ffbb71fd5d7a08d350571dad3e3209b1431
am skip reason: Change-Id Ie6568cb8a82d5cca9a3dc91b5a068abf4b0632dc with SHA-1 480e25b74f is in history
Change-Id: Ica60e5a7c4e6a5717e03978e11c21484131b9bab
Jaewoong Jung