Commit Graph

22529 Commits

Author SHA1 Message Date
TreeHugger Robot 3176077614 Merge changes I38874b8b,I627ed7c6 into ub-launcher3-rvc-dev am: a29a69943a
Change-Id: I324727deb4c83401e9c1ed13d2c8b0add146ac7e
2020-04-24 20:15:50 +00:00
TreeHugger Robot a29a69943a Merge changes I38874b8b,I627ed7c6 into ub-launcher3-rvc-dev
* changes:
  Adds ripple effect for successful Back gestures in tutorial.
  Adds feedback to Home and Back tutorials.
2020-04-24 19:58:48 +00:00
Tracy Zhou 8908dc2c63 Merge changes from topic "grid-size-migration" into ub-launcher3-rvc-dev am: 879d3ade68
Change-Id: I0a8688f66bbe3312b22305639b62ac0c5e7e1b0c
2020-04-24 19:40:14 +00:00
Tracy Zhou 879d3ade68 Merge changes from topic "grid-size-migration" into ub-launcher3-rvc-dev
* changes:
  fix GridBackupTableTest in comply with grid size migration
  Turn on V2 migration algorithm feature flag
2020-04-24 19:26:44 +00:00
TreeHugger Robot b1b9f73f49 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev am: acafb3a287
Change-Id: Ifa261e649504c28b8b206b5b2cf7ab7b446bdb95
2020-04-24 19:11:18 +00:00
TreeHugger Robot acafb3a287 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev 2020-04-24 18:58:30 +00:00
Andy Wickham e992fab187 Adds ripple effect for successful Back gestures in tutorial.
Emanates from where the gesture was started.

Demo: https://drive.google.com/open?id=1oaXOSUiZP6Hi7J6W4H2NIFVVu0tQfKWm
Bug: 148542211
Change-Id: I38874b8b731864cbfdf963a5e44a59c8c3d30c51
2020-04-24 18:16:43 +00:00
Andy Wickham 64a91132c5 Adds feedback to Home and Back tutorials.
Back feedback:
 - Too far from edge of screen
 - Cancelled (reversed gesture, swiped upwards, etc.)
 - Inside nav bar region
 - Demo: https://drive.google.com/open?id=1pc_hr7i-iZmgF37CN8oijPjhOvvsJoEG

Home feedback:
 - Too far from edge of screen
 - Paused too long (Overview detected)
 - Swiped sideways instead of up
 - Demo: https://drive.google.com/open?id=1NGYAlqV2wJtM2DOJ1pZM-r8N1SYVtMos

Bug: 148542211
Test: Manual
Change-Id: I627ed7c6e9b005d35794e4ae568529b5613cbf70
2020-04-24 18:15:23 +00:00
Andy Wickham 6b6287f414 Detects nav bar gestures to progress through Home tutorial.
Home gesture also exits Back and Home tutorials on the
completion screens (as does back gesture).

Test: Manually verified Back and Home tutorial flows.
Bug: 148542211
Change-Id: I8026745e875e9ccb8cfd60bc438213b2d896254d
2020-04-24 18:13:05 +00:00
Vinit Nayak 00e9da0a48 Merge "Rotate Overview Task Action Menu" into ub-launcher3-rvc-dev am: 49d3fe598c
Change-Id: I9ead961382546616e3d1907ce587022884447c35
2020-04-24 17:58:27 +00:00
Vinit Nayak 49d3fe598c Merge "Rotate Overview Task Action Menu" into ub-launcher3-rvc-dev 2020-04-24 17:48:01 +00:00
TreeHugger Robot 8f70fd555a Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into ub-launcher3-rvc-dev am: 7e0a1ac606
Change-Id: I54c35b48f16ab77ddb39f33bf74d335e007f16c4
2020-04-24 15:23:06 +00:00
TreeHugger Robot 7e0a1ac606 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into ub-launcher3-rvc-dev 2020-04-24 15:06:28 +00:00
Adam Cohen 683714434b Merge "Cleanup reorder animations to not require layout on every frame" into ub-launcher3-rvc-dev am: 59d305fefe
Change-Id: I4739ae2a8bbd72ff1afd7be0ffc25056a89189d3
2020-04-24 03:03:25 +00:00
Adam Cohen 59d305fefe Merge "Cleanup reorder animations to not require layout on every frame" into ub-launcher3-rvc-dev 2020-04-24 02:50:23 +00:00
Ming-Shin Lu 4f07525417 Fix AlwaysOnTop stack may covered by RemoteAnimation
Now with hierarachical animation, the layer of
RecentsAnimation / RemoteAnimation are controlled by system.

Now Launcher side don't need to have other way to set layer for ZBoost
case, so remove setLayer & withLayer related logics for cleaning up.

Fix: 151024899
Test: manual, launch google map app -> enter PiP mode,
      swipe up to overview screen or launch activity from shortcut,
      make sure the PiP window is not covered by other apps.

Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
(cherry picked from commit 99f7da7dd2)
2020-04-24 02:18:16 +00:00
Adam Cohen 1d13c0bf13 Cleanup reorder animations to not require layout on every frame
=> Extending on previous CL to separate multiple translation properties
   and avoiding expensive layout pass

Test: manual

Change-Id: I058da7367fb320b9f432bef9482be2966d3a7d42
2020-04-24 01:28:39 +00:00
Tracy Zhou 27b7bfa44e Merge "Special handling when a db for one grid option is not setup yet" into ub-launcher3-rvc-dev am: f4e5a1a119
Change-Id: Idddef9cab7fe08066b670ac2edda2fa4b4c04169
2020-04-23 18:10:36 +00:00
Tracy Zhou f4e5a1a119 Merge "Special handling when a db for one grid option is not setup yet" into ub-launcher3-rvc-dev 2020-04-23 17:47:29 +00:00
vadimt 1c2005151e Checking that there are no more than 2 live activities at any moment am: 0703464556
Change-Id: Ia2d09a1359a5af2b9688c130ffc1874f807d0bc9
2020-04-23 17:35:42 +00:00
vadimt 0703464556 Checking that there are no more than 2 live activities at any moment
This is tightening the makeshift strictmode criteria.

Starting with this moment, we will know that there is
no memory growth during tests execution, which is a big deal.

Big: 139137636

Change-Id: I5edc84524463bd1736d727496ad0fc031bb9624c
2020-04-23 16:35:09 +00:00
Pinyao Ting 26c4e23e9a fix GridBackupTableTest in comply with grid size migration
Bug: 154166808
Test: GridBackupTableTest
Change-Id: I7af35ceed7edb77ac0d9c443d7eccbcef19ae476
2020-04-23 09:18:46 -07:00
Tracy Zhou 219426f870 Turn on V2 migration algorithm feature flag
This flag is behind grid options master flag, so it won't go to all dogfood users yet.
I will turn on grid options flag after enough bug bash, hopefully at the end of this week.

Bug: 154154093
Test: N/A
Change-Id: I608af1cd3c5613f7cc33a940a145309ac90a6c00
2020-04-23 09:18:46 -07:00
TreeHugger Robot 413e570969 Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev am: d73d39b45a
Change-Id: I4d12fe2a1af697ba44e0b3c5b8516e2a11d16911
2020-04-23 03:37:22 +00:00
TreeHugger Robot d73d39b45a Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev 2020-04-23 03:22:31 +00:00
vadimt b3e8ae8230 Makeshift analog of Strictmode leak detector
Strictmode leak detector is still a goal, but we might not be able to
achieve it in R. Strictmode has several framework-side bugs that perhaps
hide Launcher-side strictmode violations, while the time to fix
everything is limited, and new leaks get introduced all the time.

For now, implementing a check that is slightly more relaxed than
Strictmode, but still ensures the absence of leaks. I’ll keep
eliminating Strictmode violations as well as keep strengthening the
makeshift checker conditions until we’ll be able to enable Strictmode in
continuous testing.

I’m disabling Strictmode checks for now so that they don’t generate
unnecessary hprof dumps, but leaving the code dealing with strictmode.

Bug: 139137636
Change-Id: Ib10136b0d4e9892f70a19cd052ae5a54cf0a4efb
2020-04-22 19:00:12 -07:00
TreeHugger Robot 7065c49cfe Merge "Always return RecentsView to translation 0 on drag end" into ub-launcher3-rvc-dev am: 8d5a000071
Change-Id: Ie0dd431ea42c4dc1134d11dd12de624224884e10
2020-04-23 01:41:38 +00:00
TreeHugger Robot 8d5a000071 Merge "Always return RecentsView to translation 0 on drag end" into ub-launcher3-rvc-dev 2020-04-23 01:25:06 +00:00
Tracy Zhou ed5f3082b0 Special handling when a db for one grid option is not setup yet
- Init KEY_MIGRATION_SRC_WORKSPACE_SIZE and KEY_MIGRATION_SRC_HOTSEAT_COUNT
- Load default workspace only when default db is created, not when peeking into dbs of other grid options during grid preview / migration

Fixes: 154184711
Test: run grid preview and migration right after a cleared cache Pixel Launcher
Change-Id: I86c7072b8c4a9da76e289c55ab440071f192fc38
2020-04-22 18:13:42 -07:00
TreeHugger Robot 345dd7a13c Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev am: 1bb37acb5d
Change-Id: I64d45689b9b7be921d07ef9cfef5363610bfb5af
2020-04-23 00:22:18 +00:00
TreeHugger Robot 1bb37acb5d Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev 2020-04-23 00:04:35 +00:00
TreeHugger Robot 183f6b2956 Merge "Stop computing scroll if handler is invalidated" into ub-launcher3-rvc-dev am: cea3ed48e5
Change-Id: I90c97b7f14cdf8f41520a7fa1154284c01598194
2020-04-22 23:50:22 +00:00
TreeHugger Robot a9eb592600 Merge "[Overview Actions] Update the navigation mode immediately when switch." into ub-launcher3-rvc-dev am: 2309597c9a
Change-Id: If0632eefa72d771728a790df47e1ec24a4fe6c50
2020-04-22 23:50:15 +00:00
Tony Wickham 6a6301c569 Always return RecentsView to translation 0 on drag end
After reaching overview, we let the user translate RecentsView
if they continue dragging around. But when they let go, we need
to return RecentsView to translation 0 since that's no longer
part of the state machine.

Change-Id: I30b51485339a3b6c3dd52bda113b1a05b6e885fa
2020-04-22 18:42:40 -05:00
TreeHugger Robot cea3ed48e5 Merge "Stop computing scroll if handler is invalidated" into ub-launcher3-rvc-dev 2020-04-22 23:39:11 +00:00
TreeHugger Robot 2309597c9a Merge "[Overview Actions] Update the navigation mode immediately when switch." into ub-launcher3-rvc-dev 2020-04-22 23:34:00 +00:00
Tony Wickham 22757e840c Don't allow swiping from overview to all apps in 3 button mode
Bug: 154761926
Change-Id: I155faec27f3b96e2f11aaec318d6846a893885e6
2020-04-22 23:13:48 +00:00
TreeHugger Robot 23a5c8009b Merge "Fixing recentsView getting translated in NavBarToHomeTouchController" into ub-launcher3-rvc-dev am: 3e60577fa1
Change-Id: Ib0b9ae6621726361d6143b07b9be1c895bf3eec8
2020-04-22 23:00:13 +00:00
Becky Qiu 72c53af896 [Overview Actions] Update the navigation mode immediately when switch.
This would fix the issue that overview actions UI visibility was not set correctly.

Test: local
Bug: 152047880
Change-Id: Ia335c5c8947b39e580403090f461f87e78645af1
2020-04-22 15:57:34 -07:00
TreeHugger Robot 3e60577fa1 Merge "Fixing recentsView getting translated in NavBarToHomeTouchController" into ub-launcher3-rvc-dev 2020-04-22 22:42:46 +00:00
Hyunyoung Song 8ecef53da7 Merge "Updates folder creation logging." into ub-launcher3-rvc-dev am: 16a626cc1a
Change-Id: I3fb230e47cbd6622ef02957b2bddbc78a94d1e6b
2020-04-22 22:10:02 +00:00
Hyunyoung Song 16a626cc1a Merge "Updates folder creation logging." into ub-launcher3-rvc-dev 2020-04-22 22:05:19 +00:00
TreeHugger Robot 555f62bc68 Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev am: b615875716
Change-Id: I70c5848103e02a685f68f843ccd2ce122d157dc6
2020-04-22 22:02:20 +00:00
TreeHugger Robot 62cc754083 Merge "Assistive chip: Adjusting chip UI" into ub-launcher3-rvc-dev am: 65a0cc72ae
Change-Id: Id4f3e6d1103abdc566f2c4f210ce38597cc1a53b
2020-04-22 22:02:12 +00:00
TreeHugger Robot b615875716 Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev 2020-04-22 21:51:42 +00:00
TreeHugger Robot 65a0cc72ae Merge "Assistive chip: Adjusting chip UI" into ub-launcher3-rvc-dev 2020-04-22 21:50:02 +00:00
Sunny Goyal de4815bdad Fixing recentsView getting translated in NavBarToHomeTouchController
Bug: 154657409
Change-Id: I4d7f3cac52b563370d612dd29d5e7322645b5cbe
2020-04-22 14:23:55 -07:00
TreeHugger Robot 46e018fd5c Merge "Fixing animation player not overshooting spring animation; tuning springs" into ub-launcher3-rvc-dev am: cf3bed973c
Change-Id: I507741080a49e0d432e31573125bcf494f60d866
2020-04-22 21:16:28 +00:00
Vinit Nayak e553e380d0 Rotate Overview Task Action Menu
Fixes: 153371258
Test: Tap on icon in portrait,
landscape and seascape. Open menu
then rotate phone.

Change-Id: I38b018371561b502fe211a3c2ddea4ff7fde4274
2020-04-22 14:16:05 -07:00
TreeHugger Robot cf3bed973c Merge "Fixing animation player not overshooting spring animation; tuning springs" into ub-launcher3-rvc-dev 2020-04-22 20:52:35 +00:00