Commit Graph

16278 Commits

Author SHA1 Message Date
Sunny Goyal 32359e6b85 Some quick scrub fixes
> Skipping quick scrub, if its already in progress, or is waiting on previous task launch
> Restoring to proper state is the task animation is cancelled before launcher gets onStop
> Crash when using quickscrub before last list has loaded

Bug: 77289180
Bug: 77856587
Bug: 79919440
Change-Id: I8db127bf9539cfc8f47c1e86c5030637845749d4
2018-05-18 14:10:41 -07:00
Tony Wickham f9d38098ca Merge "Fix a couple issues with swiping up from home" into ub-launcher3-edmonton 2018-05-18 16:50:47 +00:00
Winson Chung fdf9315b8e Fix thresholds with deferred-start swipe up gestures
- We were previously using the drag threshold (10dp) for both gesture start
  and drag start, when we should be using the touch threshold (24dp) for
  the deferred gesture start to ensure it coincides with the touch threshold
  for the buttons in the nav bar.

Bug: 79970627
Test: Swipe up over the back button, ensure that we don't both start the
      animation and also trigger back press

Change-Id: Ib4b2a3e2492da144485f87be5477eabf3e96e843
2018-05-18 09:13:17 -07:00
TreeHugger Robot f3cc505e86 Merge "Fade back button in and out tied with the overview/shelf (2/3)" into ub-launcher3-edmonton 2018-05-18 00:58:47 +00:00
Matthew Ng 8b92fe336b Fade back button in and out tied with the overview/shelf (2/3)
Back button changes opacity when moving the shelf during swipe up
between home screen and overview. The alpha changes depending on the
progress of the swipe up animation. When going from app to home and vice
versa, the fade animation does not tie with the swipe up progress. The
fade animation also masks the back button drawable when ime visibility
changes.

Change-Id: I51e42930640ba711e81880b385bb722d7ee8ad33
Fixes: 74581837
Fixes: 76900236
Test: swipe up from home screen to overview
2018-05-18 00:48:51 +00:00
Tony Wickham 7de574175b Fix a couple issues with swiping up from home
- Don't update the animation to go from 0 to 1; instead, update the
  interpolator to clamp to the remaining progress (b/79773309)
- Fix NPE that can happen in a race between the atomic animation
  ending and the non-atomic animation canceling/ending

Change-Id: I313251dc5cbd7b931b043fc3e840bb4ab368a790
2018-05-17 16:30:46 -07:00
TreeHugger Robot f85d083980 Merge "Only remove task if it was uninstalled or removed from the recents list" into ub-launcher3-edmonton 2018-05-17 22:18:12 +00:00
Winson Chung 0e2aa7a264 Only remove task if it was uninstalled or removed from the recents list
- Was missing additional checks and unconditionally removing the task
  whenever the task was removed from the active tasks in AM. Instead, check
  that the app still exists both in the system and in the recents list
  before removing.

Bug: 79698015
Test: a) get incoming call, go to overview, end call and ensure removed
      b) install app, open app, go to overview, uninstall app and ensure removed

Change-Id: I8901cb232ef7ff0759923d6a98f65df4e4adf88b
2018-05-17 14:53:55 -07:00
TreeHugger Robot 48059dc706 Merge "Fixes a crash when turning off workprofile while the workprofile tab is active." into ub-launcher3-edmonton 2018-05-17 15:51:40 +00:00
Mario Bertschler d460c084eb Fixes a crash when turning off workprofile while the workprofile tab is
active.

Bug: 79735930

Change-Id: Iafaddf827e648c9d39df78393a96f90dfc86fcca
2018-05-17 10:12:28 +02:00
Mehdi Alizadeh 64d19820f6 Merge "Use overlay settings for Swipe Up gesture default" into ub-launcher3-edmonton 2018-05-17 00:30:21 +00:00
TreeHugger Robot 8dcdcd9843 Merge "Fixing taskView not centered properly in available width" into ub-launcher3-edmonton 2018-05-16 23:53:20 +00:00
Tony Wickham b2ddf10041 Update interpolators and durations for state animations
When we enter overview (overview appears, workspace disappears):
- Workspace scales down from 1f to .8f with OvershootInterpolator(1.2f) at 200 ms
- Workspace fades from 1f to 0 with OvershootInterpolator(1.2f) at 200 ms
- Overview scales down from 1.33f to 1f with OvershootInterpolator(1.2f) at 200 ms
- Overview fades from 0 to 1f with OvershootInterpolator(1.2f) at 200 ms

When we exit overview (overview disappears, workspace appears):
- Workspace scales up from .92f to .1f with DecelerateInterpolator() at 200 ms
- Workspace fades from 0 to 1f with AccelerateInterpolator() at 200 ms
- Overview scales up from 1f to 1.1f with AccelerateInterpolator() at 180ms
- Overview fades from 1f to 0 with DecelerateInterpolator(1.7f) at 200 ms

Parallax while the finger moves: Workspace translates half the distance as the shelf

Bug: 79776746
Change-Id: I319d982cf202bcd6dbbcd68ffc5c0c7853629c7e
2018-05-16 15:59:31 -07:00
TreeHugger Robot 07b8b0b1f0 Merge "Fix bug where Workspace page alpha stays 0 in SpringLoaded mode." into ub-launcher3-edmonton 2018-05-16 22:51:44 +00:00
Sunny Goyal d62e14e539 Fixing taskView not centered properly in available width
Bug: 79756414
Change-Id: Iec6b22f96f883d61f430599e34ff9ebe91d91924
2018-05-16 15:46:13 -07:00
Mehdi Alizadeh 25a8e6f063 Use overlay settings for Swipe Up gesture default
Implements the following logic:

if config_swipe_up_gesture_setting_available is false, always use the
default value in config_swipe_up_gesture_default and ignore
Settings.Secure

if config_swipe_up_gesture_setting_available is true, use
config_swipe_up_gesture_default as the default value for
Settings.Secure, and respect Settings.Secure if user makes any changes.

Bug: 78641268
Test: Manual test
Change-Id: I586083b6655ccb3c94f08a911ed0de80f4738d62
2018-05-16 15:36:00 -07:00
Jon Miranda 8d994cd6d5 Fix bug where Workspace page alpha stays 0 in SpringLoaded mode.
The page alpha gets set to 0 by updatePageAlphaValues sometime between
Workspace calling goToState(SPRING_LOADED) and onStartStateTransition.

By the time the transition is over, Workspace is no longer in a modal state
and so alpha never gets restored via updatePageAlphaValues.

Bug: 76449277
Change-Id: I95241395594dd9084763cc3bc51bc55319cadb73
2018-05-16 15:32:54 -07:00
Tony Wickham 2c27df5b5d Merge "Set status bar icons to dark at correct all apps progress" into ub-launcher3-edmonton 2018-05-16 22:23:50 +00:00
Vadim Tryshev e628c474ea Fixing Recents sometimes restoring in Clear-all-reveal position.
This happened if a task was added between openings of Recents.

Bug: 72222505
Test: Manual
Change-Id: Id4cc8e7cbdb493973d329466369b62e4ac8ee0b3
2018-05-16 15:00:52 -07:00
Tony Wickham 77bf622c01 Merge "Make fling thresholds consistent" into ub-launcher3-edmonton 2018-05-16 21:55:41 +00:00
TreeHugger Robot 3c25046da8 Merge "Logging Square button presses opening Recents" into ub-launcher3-edmonton 2018-05-16 21:40:11 +00:00
Tony Wickham ec62522682 Set status bar icons to dark at correct all apps progress
Bug: 79866102
Change-Id: I8c97896319406c8360a2f60d213868ad59dafe19
2018-05-16 14:27:49 -07:00
Hyunyoung Song 27289bbe40 First task should launch when tapped.
Broken from previous CL.
Bug: 79539824

Change-Id: I9c4b00731afeeb815d2c7f3dcaf4ae4f029dec30
2018-05-16 14:03:20 -07:00
Tony Wickham 0f640b6c1b Make fling thresholds consistent
There are 3 places we can block a fling:
- Swiping from home to all apps (through overview)
- Swiping from an app to all apps (through overview)
- Dismissing a task (in the same gesture that started by swiping down)

In all of these cases, we block the fling when crossing the threshold
to a new state (e.g. OVERVIEW), but unblock if the user pauses their
drag. With this change, the logic is consistent:
- Unblock the fling after pausing a short amount of time
- If a fling was blocked, increase the settling duration based on
  velocity

Bug: 78089840
Bug: 78658678
Change-Id: I5ef52b74229418b867b26c3c6d3db2cf6e48914b
2018-05-16 13:47:20 -07:00
TreeHugger Robot 0d1db51ce8 Merge "Fixing wrong accessibility focus when opening a floating view" into ub-launcher3-edmonton 2018-05-16 20:25:07 +00:00
TreeHugger Robot c212649c13 Merge "Fixing task location calculation in seascape" into ub-launcher3-edmonton 2018-05-16 20:22:37 +00:00
Sunny Goyal de75321542 Fixing wrong accessibility focus when opening a floating view
> Using common logic for announcing a floating view for widgets and folders

Bug: 79091095
Bug: 79748886
Change-Id: Ibb3fe48e68e724f50d69f51a03d3b35ad0baf625
2018-05-16 13:11:00 -07:00
TreeHugger Robot 6ae02c6a61 Merge "Fix app open animation when in overview mode." into ub-launcher3-edmonton 2018-05-16 20:05:01 +00:00
Sunny Goyal 9638caf6e4 Merge "Dumping the excoded view hierarchy instead of the default activity dump" into ub-launcher3-edmonton 2018-05-16 19:57:05 +00:00
Jon Miranda bbe666631f Fix app open animation when in overview mode.
* Avoids scrim hard line by animating the RecentsViewContainer and
  AllAppsTransitionController progress.

Bug: 79689563
Change-Id: If467e07667ae4d6eeac663608f77bec0eb7ef82f
2018-05-16 12:51:23 -07:00
TreeHugger Robot 0b1174ddbe Merge "Adding Clear All to accessibility chevron on Recents" into ub-launcher3-edmonton 2018-05-16 19:12:00 +00:00
Vadim Tryshev 3f51631b80 Adding Clear All to accessibility chevron on Recents
For motivation, see email thread "Tweaks to for the reverted order of
accessibility swiping"

This doesn't add the action to the fallback Recents, so it will require
more work.

Bug: 79165501
Test: Manual
Change-Id: I99d608ccc13cc1742dc4d427e763125788e8edd2
2018-05-16 12:00:33 -07:00
Hyunyoung Song 1241e61a45 Improve Task user event logging
Bug: 79539824
Bug: 79541772

(1) Added page index of the TASK that is being launched
(2) Covers all three cases of task launch (tap, swipe down, quick scrub)
UserEvent: action:FLING direction=DOWN
UserEvent:  Source child:TASK, packageHash=-1598699687, componentHash=1952702153, pageIdx=0

UserEvent: action:DRAGDROP
UserEvent:  Source child:TASK, packageHash=-744307622, componentHash=-515832044, pageIdx=4

(3) Avoid double logging (When onStop is called, it is not logged if
the cause of onStop is APP or TASK launch)

Change-Id: Ic5db7d6a640d43bfb5cd667b49e37dd0ed127d5c
2018-05-16 11:26:35 -07:00
Sunny Goyal 55eb556a4b Dumping the excoded view hierarchy instead of the default activity dump
> Encoded hierarchy is smaller is size and has a lot more information about the views

Bug: 79861035
Change-Id: I84316b1b0031282b0579f3aaac22d8d8f00d8bcb
2018-05-16 10:55:21 -07:00
Vadim Tryshev d9a1337b40 Loading task tiles on accessibility scrolling
Bug: 79749339
Change-Id: I5bd2652c0fca08ddd5e366415411b9b99caa71fb
Testing: Manual
2018-05-15 17:17:48 -07:00
Vadim Tryshev d0788021f9 Logging Square button presses opening Recents
Examples of traces are in notes.
Using the button for closing Recents is not logged.
Dooble-tap logs only one entry.

Bug: 79437767
Test: logcat
Change-Id: Ic2c50ecc937dd2e9cb4b3a7c7439d77bba9b372c
2018-05-15 14:58:27 -07:00
Hyunyoung Song 61745e17c7 Merge "Add logging for Onboarding Bug: 73784423" into ub-launcher3-edmonton 2018-05-15 21:48:06 +00:00
Tony Wickham 46afdf5194 Merge "Tune quick scrub" into ub-launcher3-edmonton 2018-05-15 21:34:34 +00:00
Hyunyoung Song 018eec6899 Add logging for Onboarding
Bug: 73784423

* Discovery bounce, homescreen, hotseat
UserEvent: action:TIP
UserEvent:  Source child:HOTSEAT id=0 BOUNCE

* Discovery bounce, overview, prediction
UserEvent: action:TIP
UserEvent:  Source child:PREDICTION BOUNCE

* Swipe up from navbar text (visibility, cancel target)
UserEvent: action:TIP
UserEvent:  Source child:TIP SWIPE_UP_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET SWIPE_UP_TEXT

* Quickscrub text (visibility, cancel target)
UserEvent: action:TIP
UserEvent:  Source child:TIP QUICK_SCRUB_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET QUICK_SCRUB_TEXT

* Prediction apps text (visibility, cancel target)
UserEvent: action:TAP
UserEvent:  Source child:TIP PREDICTION_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET PREDICTION_TEXT

Change-Id: I94710b5ed3d00e3599985b154eb660af4a958288
2018-05-15 14:31:07 -07:00
Tony Wickham d58c2d5a48 Tune quick scrub
- Change durations/interpolators when starting from home vs an app
- Increase dim animation duration after quick scrub from an app
  - Also fixed contention between setting dim alpha for the animation
    and setting dim alpha for scrolling
Change-Id: I2c9ea52d4eafaad8954f3ff9d3c0c459a07953bc
2018-05-15 11:49:09 -07:00
Vadim Tryshev 3154cd16b0 Keep clear-all button revealed after dismiss
If it was visible before the dismiss, it will be visible after that.
As a nice side effect, it will preserve visibility on any layout, say,
after a rotation.

Bug: 79117932
Test: Manual
Change-Id: Ia8a544af1326458d4e2d7a07ae2b668f604bc0b3
2018-05-15 11:28:24 -07:00
TreeHugger Robot c14adabe99 Merge "Scrolling on the most recent task upon Overview start" into ub-launcher3-edmonton 2018-05-15 17:47:50 +00:00
Sunny Goyal ff102be52b Merge "Showing the caret/drag handle in transposed layout" into ub-launcher3-edmonton 2018-05-15 17:25:04 +00:00
Sunny Goyal 0076e67dc4 Showing the caret/drag handle in transposed layout
> Adding a simple touch-down effect, without capturing the motion event

Bug: 79526736
Change-Id: I50dcc76836765d158dfdcef2886b190a85707ff2
2018-05-15 09:47:32 -07:00
Vadim Tryshev eb701c6360 Scrolling on the most recent task upon Overview start
Fixes this problem:
1. Open a single task in Recents
2. Dismiss via Clear-all
3. Start a task
4. Press Home
5. Press square button
get Recents revealing Clear All button

Bug: 79117932
Test: Manual
Change-Id: I47bcc50cb72f1757025d2abac0196460e0bb3f36
2018-05-14 17:24:00 -07:00
TreeHugger Robot 6baca0fc47 Merge "Updating the dark theme color to match system-ui theme" into ub-launcher3-edmonton 2018-05-14 23:17:35 +00:00
Sunny Goyal 12f803843b Updating the dark theme color to match system-ui theme
Bug: 79691756
Change-Id: I12058ca2d7651353af99f4ce65dc90339868bfc0
2018-05-14 15:58:19 -07:00
Winson Chung a92961a639 Merge "Clear ref to animation after drag & drop animation completes" into ub-launcher3-edmonton 2018-05-14 22:49:57 +00:00
TreeHugger Robot b299f3f172 Merge "Ensure that animaiton.end() is properly dispatched" into ub-launcher3-edmonton 2018-05-14 21:42:34 +00:00
TreeHugger Robot d12033ab4a Merge "Adding some activity state information in dump" into ub-launcher3-edmonton 2018-05-14 21:37:28 +00:00