Commit Graph

22963 Commits

Author SHA1 Message Date
TreeHugger Robot 662796d18b Merge "Fix quick switching to any task that already appeared" into ub-launcher3-rvc-dev 2020-06-12 05:22:44 +00:00
TreeHugger Robot 368621a4bb Merge "ADD NPE check before shortcut key creation." into ub-launcher3-rvc-dev 2020-06-11 23:00:05 +00:00
TreeHugger Robot 4aef742314 Merge "Reduce launcher logs in bugreports" into ub-launcher3-rvc-dev 2020-06-11 22:41:39 +00:00
Samuel Fufa adbe9b6075 ADD NPE check before shortcut key creation.
Bug: 156871815
Change-Id: I88132a51f80062eaa76da5838d20c5fe93224635
2020-06-11 15:15:02 -07:00
Samuel Fufa 852145c9b5 Reduce launcher logs in bugreports
Bug: 158216867
Test: Manual
Change-Id: I068550f2c0b233d5c7a6c4685efb36b62ced5dde
2020-06-11 15:02:58 -07:00
TreeHugger Robot 8449aeaf6e Merge "Adding tooltip for Select button." into ub-launcher3-rvc-dev 2020-06-11 21:07:39 +00:00
Sreyas da727bbb98 Adding tooltip for Select button.
Change-Id: I3a09d20b6dd26e81b8a010e2d2da52c52408e845
2020-06-11 13:29:37 -07:00
Samuel Fufa 6fd62fde91 Migrate Hotseat logging to WW
Bug: 158218197
Change-Id: I77743b78593f169ffc30f91ab9963052417dac23
2020-06-11 09:27:36 -07:00
Tracy Zhou 3b18d41e2c Merge "Consider folder diff differently" into ub-launcher3-rvc-dev 2020-06-11 05:21:18 +00:00
TreeHugger Robot bb58efabc8 Merge "Remove unused HomeRotatedPageHandler" into ub-launcher3-rvc-dev 2020-06-11 03:10:13 +00:00
Vinit Nayak 84f30b213a Remove unused HomeRotatedPageHandler
Transfer functionality of choosing
task menu layout to PortraitPageHandler,
which is what it should have been to
begin with.

Fixes: 158484000
Change-Id: Iadda53e7e1f796c063a111823f7f6278f3fdbf58
2020-06-10 18:47:05 -07:00
TreeHugger Robot 743e25e2d2 Merge "Show discovery tip for hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-10 23:22:14 +00:00
TreeHugger Robot ca5e9cb7ef Merge "Notify SysUi on device rotation for back gesture" into ub-launcher3-rvc-dev 2020-06-10 23:14:06 +00:00
TreeHugger Robot 97c399aa9f Merge "[Overview Actions] Add actions to the task menu for in-place landscape." into ub-launcher3-rvc-dev 2020-06-10 23:08:36 +00:00
Sreyas Rangaraju 9a391afbf1 Merge "Fix Task Icon menu behavior." into ub-launcher3-rvc-dev 2020-06-10 22:47:28 +00:00
Samuel Fufa 5b2da14e72 Show discovery tip for hybrid hotseat
Doc: go/hybrid-hotseat-tips

Issue 157683315: for fully populated hotseat, count returns to home screen and show discovery tip if Tip action was not tapped.
Issue 158301717: Don't use cached items if client has predicted items.

Test: Manual
Change-Id: I4747a1148caa62a6262fb6592d5185bdf216ede6
2020-06-10 15:12:55 -07:00
Becky Qiu 849622f6cb [Overview Actions] Add actions to the task menu for in-place landscape.
Test: local
Bug: 153736749
Change-Id: I9ba5a089e434e75de7d9cc29ebd303f7a1388324
2020-06-10 15:04:56 -07:00
thiruram ba0a6b61a3 Log folder open event into WW.
Bug: 158597506

Sample Log: https://paste.googleplex.com/5351626992779264

Change-Id: Ifb2f061924035abc84472a9a03d1b4212588428b
2020-06-10 15:00:19 -07:00
TreeHugger Robot c936fe1146 Merge "Add null check before updating animation progress" into ub-launcher3-rvc-dev 2020-06-10 21:51:45 +00:00
TreeHugger Robot 16823c2c03 Merge "Set qsb fade interpolator same as workspace for home <-> overview" into ub-launcher3-rvc-dev 2020-06-10 21:45:41 +00:00
TreeHugger Robot 479ff47a72 Merge "Allows Accessibility to focus on specified view in AbstractFloatingView." into ub-launcher3-rvc-dev 2020-06-10 20:58:06 +00:00
Tony Wickham 779955390c Add null check before updating animation progress
Haven't been able to reproduce it locally, but seems theoretically
possible if we get an onDrag() event right after something else
cancels the animation (which clears the animation controller).

Bug: 157900227
Change-Id: Ia134aa948e62d39f71e41dd4e6b98f3227ae0522
2020-06-10 15:36:52 -05:00
Andy Wickham bc83edbf4d Allows Accessibility to focus on specified view in AbstractFloatingView.
Here, the first item in an ArrowPopup or Folder are focused on.

Note: There's another pre-existing bug where it announces
"Home screen x of y" when the floating view appears; this
change doesn't address that.

Fixes: 147470419
Change-Id: I1dc70edc21ea7c19a5742208512738d6c4a94067
2020-06-10 12:03:43 -07:00
thiruram 18c2495b8f Adds PredictedHotseatContainer to launcher_atom.proto
Used for differentiating logs from normal hotseat and predicted hotseat.

Bug: 158218197
Change-Id: I011ff724ea0916b32f680dc24e8d6090d3df766d
2020-06-10 10:44:58 -07:00
Tracy Zhou fa88a25ea4 Consider folder diff differently
Fixes: 157813770
Test: manual

Change-Id: I0e95f7d9709cacfe1c3b8384dfb15208a4c36914
2020-06-10 10:40:47 -07:00
Tracy Zhou c11a808b99 Merge "Workspace migration should start from CellY = 1" into ub-launcher3-rvc-dev 2020-06-10 17:21:16 +00:00
TreeHugger Robot 4e975109bb Merge "Decrease predicted icon outline size" into ub-launcher3-rvc-dev 2020-06-10 17:06:48 +00:00
Tracy Zhou 51e33e187b Workspace migration should start from CellY = 1
Test: Manual
Fixes: 155828336
Change-Id: Ic262f63e5e9dc0a5738f71a84dc5cc8b0cefd321
2020-06-10 00:42:07 -07:00
TreeHugger Robot 179880c0f6 Merge "Relaunch app that is restarted mid-gesture" into ub-launcher3-rvc-dev 2020-06-10 06:53:50 +00:00
Winson Chung 7d7864e89a Relaunch app that is restarted mid-gesture
Bug: 156692295
Test: Swipe up from an app that has a HUN and ensure tapping on the
      HUN (or anything that can restart the activity) will start the
      activity while the recents animation is still running
Change-Id: Ia1fbd9cfb21aa64b3c8a0d431ba2d9824ee4c0a1
2020-06-09 23:10:13 -07:00
Sreyas b64b59d025 Fix Task Icon menu behavior.
Tapping task icon will now show the scrim for rest of thumbnail and not snap to page that is already snapped to.
Pressing task icon from clear all will scroll to the page.
Link: https://drive.google.com/file/d/1I90rd6ELPZNIje2_VZ3CamWWeFN8ywhL/view?usp=sharing

Bug: 158004853
Change-Id: I9ac8229a603190ea09a74e1cfb70a6bb6e1e65b7
2020-06-09 21:10:46 -07:00
thiruram 236f40d97e Update StatsLogManager to support ranking related events.
Change-Id: I238f00a782a620f704005d37c8972b5e25610c75
2020-06-10 02:47:58 +00:00
Becky Qiu 23986e9a84 Revert "Fix Task Icon menu behavior."
This reverts commit 6df0148b07.

Reason for revert: breaks the task icon behavior.

Change-Id: I6f654478e0ffe7827efeca1553622dad2e02c5da
2020-06-10 00:20:49 +00:00
TreeHugger Robot 8984fea211 Merge "Apply PendingAnimation#mDuration to all added anims" into ub-launcher3-rvc-dev 2020-06-10 00:18:31 +00:00
TreeHugger Robot ea928edc36 Merge "Remove rotation flag check" into ub-launcher3-rvc-dev 2020-06-09 23:43:44 +00:00
Tony Wickham fe54c36822 Apply PendingAnimation#mDuration to all added anims
Doing this at the root instead of individually for all added
animators ensures none fall through the cracks.

Fixes: shelf moving too quickly in 2 button mode
Change-Id: I0de1ba9cee3fb8f1d6161371625d97e4b2305129
2020-06-09 18:35:07 -05:00
TreeHugger Robot e34b183547 Merge "Add feature flag for majority ranking." into ub-launcher3-rvc-dev 2020-06-09 23:23:49 +00:00
Tracy Zhou f917b640d0 Merge "Fix icons not rendering in folder migration" into ub-launcher3-rvc-dev 2020-06-09 22:59:31 +00:00
Vinit Nayak 92364cdc74 Remove rotation flag check
There's a race condition between when
the flag is read and when it gets set,
and not registering the listener that
the flag is gating can result in a lot
of bad rotation state.

Fixes: 158592847
Change-Id: Idd78e15669698bb0d057d0b6661ea69bfa5c8202
2020-06-09 22:55:07 +00:00
Jayaprakash Sundararaj f4898452f7 Add feature flag for majority ranking.
Bug: 157907222
Change-Id: I72962c3c68559ce8d40ca4137e89b9cc2913825a
2020-06-09 15:50:58 -07:00
Tracy Zhou 1983faca2d Fix icons not rendering in folder migration
Fixes: 157813770
Test: manual

Change-Id: I68a2685482756a2b8afa65bf652b667972158a46
2020-06-09 14:40:17 -07:00
Samuel Fufa 25afca44c4 Merge "Work profile visual polish" into ub-launcher3-rvc-dev 2020-06-09 21:21:56 +00:00
Samuel Fufa 2e59b95024 Work profile visual polish
- Calculate work profile switch height and apply it as a padding to recyclerview instead of reading height from view.
- Add solid background to work_apps paused overlay for improved crossfade animation on pause/unpause
- Don't show work paused overlay text in landscape mode

Bug 151672365
Bug 153763804
Bug 151595687

Test: Manual
Change-Id: I6c14a8a1624455181d4998555bcc3ae2bb422efe
2020-06-09 14:17:47 -07:00
Samuel Fufa 39912270e5 Decrease predicted icon outline size
Bug: 156781454
Change-Id: Id9e1fbb47dbb5c18a41f466b9f3963f93ab6f509
2020-06-09 14:02:48 -07:00
Zak Cohen e246f191de Merge "Overview Actions - use scaled insets for screenshot transition." into ub-launcher3-rvc-dev 2020-06-09 20:36:12 +00:00
Tony Wickham 5e957551be Fix quick switching to any task that already appeared
Previously we did this for the last task that appeared, but didn't
take into account cases where multiple tasks had appeared during
the same gesture state. We handle that now.

Test:
- Quick switch to delayed task A, start new gesture, return to the
  first app after onTaskAppeared(A)
- Quick switch to delayed task A, start new gesture, wait for
  onTaskAppeared(A), then switch to delayed task B, start new
  gesture, wait for onTaskAppeared(B), and switch back to A
- Quick switch to delayed task A, start new gesture, wait for
  onTaskAppeared(A), then switch to delayed task B, start new
  gesture, wait for onTaskAppeared(B), and switch back to A and
  quickly back to original app (before settling on A)
Ensure task starts/resumes and is interactable in all cases.

Bug: 158588954
Change-Id: I647a6d015baa1d9b6d613e6c0e584589f35da54a
2020-06-09 15:07:16 -05:00
Hyunyoung Song 58c936c1a2 Merge "Guard logging behind a feature flag Bug: 158442037" into ub-launcher3-rvc-dev 2020-06-09 18:47:29 +00:00
Hyunyoung Song 3b1786ce77 Merge "Add FolderInfo label source / Add instance id to snapshot logging" into ub-launcher3-rvc-dev 2020-06-09 18:26:07 +00:00
TreeHugger Robot 81e651dba8 Merge "Removing multiple system RPCs to packageMAnager and userManager from UI thread" into ub-launcher3-rvc-dev 2020-06-09 17:19:56 +00:00
TreeHugger Robot fd4e7a8907 Merge "Fix bug where scrim did not fade in during staggered workspace animation." into ub-launcher3-rvc-dev 2020-06-09 17:13:50 +00:00