Commit Graph

36163 Commits

Author SHA1 Message Date
TreeHugger Robot 7f54d5cde4 Merge "Add icons for staged split" into sc-v2-dev 2021-12-02 23:00:48 +00:00
Alex Chau b31176c83b Merge "Fix switch access for overview grid" into sc-v2-dev 2021-12-02 22:32:01 +00:00
Vinit Nayak 20cbfa5427 Fix direction of matrix inversion
* "And I would have gotten away with it too
if it wasn't for you meddling [matrices]"

Fixes: 208360236
Change-Id: I1607a19c81830f6a037d2337ee1d9e944096e0ac
2021-12-02 22:08:06 +00:00
Tony Wickham e59a723af3 Fix taskbar jumping when going home
- Set resumed state immediately when finishing recents controller to launcher, otherwise there's a race where we start animating gesture state to 0 before animating resumed state to 1, which causes the jump in the bug

Test: Swipe from app to home 10 times, no jump
Fixes: 203725820
Change-Id: Ie8a1add29902a9961ba4d7861ba5424ab656f1c8
2021-12-02 12:19:32 -08:00
Winson Chung eb4b2d0147 Merge "Fix NPE from null thumbnail data when canceling recents animation" into sc-v2-dev 2021-12-02 19:01:40 +00:00
Tony Wickham 3d2a1a7368 Merge "Remove TaskbarLauncherStateController#setIconAlpha()" into sc-v2-dev 2021-12-02 17:39:08 +00:00
Andras Kloczl c820151a4c Add TAPL tests for two panel workspace
- Add test for icon dragging
- Add test for page pairing
- Add test for empty page removal
- Add dragIcon helper method

Test: TwoPanelWorkspaceTest
Bug: 197631877
Change-Id: I7ce2dd88e183626feac49b34254d00a589473944
2021-12-02 16:44:26 +00:00
Nick Chameyev c5d3a0d891 Do not animate QSB and hotseat when portrait
Disables fold/unfold animation for QSB and hotseat
icons when in portrait orientation. Launcher workspace
icons and widgets are still animated intentionally.
Reuses NaturalOrientationRotationProvider which is currently
used to disable fold/unfold animation in the status bar when
in non-natural orientation.

Bug: 201518277
Test: fold/unfold on launcher in landscape =>
 QSB and hotseat animated;
 rotate screen during fold/unfold animation =>
 translation reset after rotating to portrait,
 animated after returning to landscape;
 rotate after fold/unfold animation => no changes
Change-Id: I8ed405b09f445f554d7638ab44393c90773e0bb6
2021-12-02 14:39:08 +00:00
Android Build Coastguard Worker b96ade2012 Snap for 7960322 from 87f010f3bd to sc-d2-release
Change-Id: I8518242280453071321623d85b56bf0fb6ba8a6d
2021-12-02 00:08:46 +00:00
Schneider Victor-tulias fc846eef41 Update taskbar edu strings for i10n.
Fixes: 200777300
Test: none
Change-Id: I9d6e2575940d2fcdd354c94036662c178f9d6eee
2021-12-01 16:04:33 -08:00
Tony Wickham 488bca7934 Remove TaskbarLauncherStateController#setIconAlpha()
Instead use setTaskbarViewVisible directly. Now that we stash when going to overview, we shouldn't have any launcher state where we need to fade out TaskbarView icons

Test: quick switch from home (follow up CL)
Bug: 194728611
Change-Id: I03e1fa4037b7e8a08494f6b7e065d144c4bc4e1b
2021-12-01 15:27:44 -08:00
Vinit Nayak 455197bf41 Add icons for staged split
Fixes: 208649953
Change-Id: I8b7bb3a650e836608ebe6aa50631026f5f6a7c63
2021-12-01 14:58:53 -08:00
TreeHugger Robot 2bede2dbf2 Merge "Animate right icon of app pair" into sc-v2-dev 2021-12-01 20:06:56 +00:00
TreeHugger Robot 87f010f3bd Merge "Apply/reset split scroll offset regardless of previous state" into sc-v2-dev 2021-12-01 19:34:51 +00:00
TreeHugger Robot e7e3d6ad31 Merge "Removed onBackPressed handling in SplitSCreenSelectState" into sc-v2-dev 2021-12-01 18:21:05 +00:00
Alex Chau e81af3570b Animate right icon of app pair
Fix: 208647365
Test: Swipe up and observe right icon of app pair
Change-Id: I37a716c156d64c312d132bea80540ce922f3f709
2021-12-01 17:45:08 +00:00
Alex Chau 4536c2fc30 Apply/reset split scroll offset regardless of previous state
- Also do the same in setState without animation

Fix: 208605204
Test: Exit split screen and enter overview
Change-Id: I34dd102527dffa90925b6f0fd22465f1fe6e819c
2021-12-01 17:23:46 +00:00
Alex Chau a307492525 Removed onBackPressed handling in SplitSCreenSelectState
- So it'll have exact same behavior as OverviewState to exit overview when going back
- Also removed RecentsView.cancelSplitSelect as it's longer needed

Fix: 181707736
Test: manual
Change-Id: Ide4dfc64680ecc9adfe245ae2de1463735b0490e
2021-12-01 16:24:10 +00:00
Vinit Nayak b15d3cfe73 Merge "Treat RTL split placeholder animation same as LTR" into sc-v2-dev 2021-12-01 16:01:36 +00:00
Prabir Pradhan 79350ef1bc Merge "Tapl Widgets: Don't use container width as gesture margin" into sc-v2-dev 2021-12-01 11:39:11 +00:00
Fedor Kudasov d6a28fe202 Merge "Separate getTaskViewAt usage" into sc-v2-dev 2021-12-01 10:08:06 +00:00
TreeHugger Robot f7518d42eb Merge "Schedule OverviewCommandHelper callbacks for GroupedTaskView" into sc-v2-dev 2021-12-01 06:35:35 +00:00
Vinit Nayak f198f6e492 Merge "Add task unpinning support for 3 button taskbar" into sc-v2-dev 2021-12-01 04:34:06 +00:00
Vinit Nayak 09a822a6fe Schedule OverviewCommandHelper callbacks for GroupedTaskView
* Schedule runnables to clear pending queue in
OverviewCommandHelper similar to how TaskView does it.
* End callbacks get run when recents animation finishes in
RecentsView in the case of live tile when recents animation
is still running
OR
in directly when the split remote animation finishes

Bug: 207845542
Change-Id: I7e858ce55b08cde6436d44f2e857e28b73458f0b
2021-11-30 20:18:50 -08:00
Vinit Nayak b997930afc Treat RTL split placeholder animation same as LTR
* Since we're doing all transformations in screen
coordinates we don't need to account for RTL.

Bug: 202156862
Change-Id: Ibcbf698dbc5b8fabf2647949de6d2718937832d5
2021-11-30 19:58:00 -08:00
Vinit Nayak 570653346f Add task unpinning support for 3 button taskbar
Bug: 199544447
Test: Tested on small and large screen
Change-Id: Ib7785992ef11825cd07a929e2cb623d02ef246f1
2021-11-30 17:18:09 -08:00
Jon Miranda 5040335e35 Remove keepWindowOpaque and have the window always fade out.
We built this method so that the window would have
something to fade out on top of. But with longer icon loading times,
this causes a buggy experience since the window is opaque
for the entire duration of the animation.

Having the window always fade out is a better UX for now.
Next step is to always init the FloatingIconView with the
in-memory icon, and then possibly caching both layers
of AdaptiveIcon.

Test: restart phone, swipe up to home
      restart phone, back swipe to home (This flow never called keepWindowOpaque)
Bug: 207389002

Change-Id: Ida64829c60881786ed91e8641cdf7a278b37e201
2021-11-30 16:55:07 -08:00
TreeHugger Robot 96f3f2214c Merge "Fix potential memory leak by setting mControllers = null" into sc-v2-dev 2021-12-01 00:49:56 +00:00
Jerry Chang 36eb818600 Merge "Remove stage type from split screen APIs" into sc-v2-dev 2021-12-01 00:41:10 +00:00
Tracy Zhou d1f9fde371 Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-v2-dev 2021-12-01 00:34:00 +00:00
Vinit Nayak 6e906f3436 Align OverviewActionsView for 3 button taskbar
Bug: 189807374
Change-Id: I3c7ec5f8c7b588032ff83ca7ab461d2aac7bfa35
2021-11-30 16:24:12 -08:00
Brian Isganitis be388b8933 Merge "Make action optional for snackbar." into sc-v2-dev 2021-12-01 00:18:40 +00:00
Android Build Coastguard Worker 3ecf1a8f93 Snap for 7956453 from b78cbf29e5 to sc-d2-release
Change-Id: Ie5b3d29ac56d275cbafe4c6f7754c2b0facb464f
2021-12-01 00:08:02 +00:00
Tony Wickham f6c28a4381 Fix potential memory leak by setting mControllers = null
Test: N/A
Bug: 202511986
Change-Id: Iad7cc89e0e68ce09ebe4ca3ab89392b50b6a82c7
2021-11-30 14:37:36 -08:00
TreeHugger Robot b78cbf29e5 Merge "Possible fix for NullPointerException b/206040100." into sc-v2-dev 2021-11-30 19:58:24 +00:00
TreeHugger Robot 2280f3d5fc Merge "Close task menu scrim when pressing home button" into sc-v2-dev 2021-11-30 19:08:18 +00:00
Jonathan Miranda 199644c397 Merge "Fix NPE in FloatingIconView" into sc-v2-dev 2021-11-30 18:43:29 +00:00
TreeHugger Robot 96f34af124 Merge "Fling to close tasks in the GestureNav can be too small." into sc-v2-dev 2021-11-30 18:34:09 +00:00
Sebastian Franco 8afeba605a Possible fix for NullPointerException b/206040100.
There is a NullPointerException when trying to get the
length of the array.

Test: Manually tested
Fix: 206040100
Change-Id: I69a03fd3658094655eaf97fa21039fd373ee37d5
2021-11-30 10:09:02 -06:00
Prabir Pradhan 53ae5d85a6 Tapl Widgets: Don't use container width as gesture margin
The test used margin that was equal to the width of the container when
injecting a backward swipe. This means the swipe was injected at an x
value of 0 in the View's local coordinates. When injecting such events
into the system, the coordinates will undergo several transformations,
at which point floating point precision errors could accumulate. This
could result in the event being dispatched outside the boundary of the
view.

Change the injection margin so that the swipe is injected in the middle
of the View instead of at its edge.

Bug: 201777251
Bug: 207146693
Test: atest TaplTestsLauncher3
Change-Id: I4082c2845aef033a6fbe41070061866d6048e21d
2021-11-30 15:06:42 +00:00
Alex Chau a8fc7e03fd Close task menu scrim when pressing home button
- Generally close all floating view when starting home from Recents

Bug: 193432925
Test: with 3 button, open task menu, then press home
Change-Id: Ic99c50333c797f222fc8e682fd0f3fcc4d641d47
2021-11-30 14:27:36 +00:00
Jerry Chang 8176366f54 Remove stage type from split screen APIs
Bug: 198438631
Test: manual check
Change-Id: Ic4f41e39013e4d49585da4cda9b28151c549357a
2021-11-30 17:15:40 +08:00
Tracy Zhou 260b90c7ad Merge "Reset live tile params along with resetTaskVisuals" into sc-v2-dev 2021-11-30 04:41:40 +00:00
Adam Bookatz cbafa6803b Merge "Revert "Fix issue with Shell listeners being unbound if SysUI is restarted"" into sc-v2-dev 2021-11-30 03:44:30 +00:00
Tracy Zhou bb594548bb [DO NOT MERGE] Make the cutout slightly smaller
Temporary fix for S. Leaving the bug open for a proper fix in T.

Since we reverted the z order back (launcher on top), we should apply this fix from S and find a proper solution in T

Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
(cherry picked from commit 26f47c711a)
2021-11-30 01:01:59 +00:00
Tracy Zhou a56dc760dd Reset live tile params along with resetTaskVisuals
The dismissal animation doesn't return the translationY to 0, but resetTaskVisuals does.

Fixes: 207782306
Test: Drag live tile to dismiss lightly so it doesn't succeed. When it comes back, make sure it matches the cutout.
Change-Id: I64ee06ad72c403ab4fdd4671d08b1843a3e89253
2021-11-30 00:49:02 +00:00
Adam Bookatz 3d34f94784 Revert "Fix issue with Shell listeners being unbound if SysUI is restarted"
This reverts commit 34e384d2e1.

Reason for revert: Multiuser performance (b/208276322)

Change-Id: Icd27ab3095c446895360f8e2faa7f9c92ab2cf01
Bug: 208276322
2021-11-30 00:19:05 +00:00
Thiru Ramasamy 24fbda5448 Set default value for rank field in launcher logs to ItemInfo.rank.
Bug: 188222480
Test: wwdebug & wwlogcat
Change-Id: I16786eb2e6f1d4ce44dbda5eff27b1cd7f50ee8e
2021-11-29 16:14:02 -08:00
Android Build Coastguard Worker 49a9091e00 Snap for 7952937 from ed05712f04 to sc-d2-release
Change-Id: Ia46df41d29a25adb3f70811d8b7657b58fbffe9d
2021-11-30 00:08:19 +00:00
TreeHugger Robot ed05712f04 Merge "Handle configuration changes in floating rotation button" into sc-v2-dev 2021-11-29 19:41:26 +00:00