Commit Graph

35100 Commits

Author SHA1 Message Date
Sunny Goyal beefd1890c Fixing allSet page not closed if recentsAnimation takes time to start
> Also finishing the activity so that it doesn't show in home settings backstack

Bug: 204541138
Test: Manual
Change-Id: I7deec0d1ef7eec0464a0f21bf30b25cd5e18d02d
2021-11-05 13:05:49 -07:00
Tony Wickham d71a4288cf Merge "Recreate taskbar when dark mode changes" into sc-v2-dev 2021-10-29 17:13:57 +00:00
Tony Wickham 5a5a926945 Recreate taskbar when dark mode changes
Also dispatch sysui flags to all controllers upon recreate, not just NavbarButtonsViewController. Additionally, tell the controllers to skip the animation due to the flag changes if it's fromInit.

Test: Enable themed icons, switch dark theme in quick settings, ensure taskbar updates
Fixes: 204403933
Change-Id: Ic43a50cf0456175f9beba5c29360440f051cbd2d
2021-10-28 17:49:03 -07:00
Becky Qiu 75c97f534b [OneSearch] Increase API version number for the one search plugin.
Bug: 199289915
Test: manual
Change-Id: I540730e067ce70956d2c3c8bb6336e8b6bd97713
2021-10-28 17:47:45 -07:00
TreeHugger Robot e9652c9a63 Merge "[OneSearch] Add onesearch plugin api to trigger image from URL." into sc-v2-dev 2021-10-29 00:36:42 +00:00
Tony Wickham 00841576d4 Merge "Fix NPE when TaskView isn't attached to RecentsView" into sc-v2-dev 2021-10-28 22:40:01 +00:00
TreeHugger Robot da86c0e64d Merge "Update taskbar drag and drop treatment" into sc-v2-dev 2021-10-28 20:54:09 +00:00
Tony Wickham 956ce16f51 Fix NPE when TaskView isn't attached to RecentsView
Test: theoretical
Fixes: 201481275
Change-Id: Ie10b5ebac373e41a4d4113ee3cda737d88adad8a
2021-10-28 13:21:15 -07:00
TreeHugger Robot d84aaad11f Merge "Make gesture nav tutorial skip button always visible." into sc-v2-dev 2021-10-28 19:51:05 +00:00
Tony Wickham 89ef745d1c Update taskbar drag and drop treatment
- Disable the FastBitmapDrawable icon instead of setting it to invisible
- Suspend auto hide during drag and drop (moved to new TaskbarAutoHideSuspendController)

Test: Drag and drop from taskbar and ensure the original icon stays in place but desaturated
Test: Open immersive app, drag and drop from taskbar and ensure taskbar doesn't hide before drop
Fixes: 200816442
Change-Id: I4b895efd043be75e7e7034bd75e751ffdd2cfdd7
2021-10-28 11:43:49 -07:00
bquezada e12b321d5f Change AppTargetId for launcher events to align with other AppTargetId's.
Bug: 202535375
Test: Manual
Change-Id: I0c28f7f64935fdaf08edb7781e4e7378a068e8e6
2021-10-28 17:52:02 +00:00
Alina Zaidi 29c3f23be5 Merge "Send widget added and removed events to AiAi." into sc-v2-dev 2021-10-28 16:45:22 +00:00
TreeHugger Robot 01f8b561b3 Merge "Fixing the possibility of opening multiple WidgetsFullSheet" into sc-v2-dev 2021-10-28 16:20:05 +00:00
TreeHugger Robot ce597d786f Merge "Prevent launching app in split if task split is unsupported" into sc-v2-dev 2021-10-28 11:19:39 +00:00
Alex Chau 0cc439ab18 Merge "Partially restoring reverted logging" into sc-v2-dev 2021-10-28 11:10:17 +00:00
Alex Chau 14c8f45b5e Merge "Fix scroll task off screen to support different screen dimensions." into sc-v2-dev 2021-10-28 10:27:30 +00:00
Bill Lin 497d08aa01 Merge "Allow One-handed gesture when densityDpi > 600" into sc-v2-dev 2021-10-28 02:20:24 +00:00
Becky Qiu aa9a446b76 [OneSearch] Add onesearch plugin api to trigger image from URL.
Bug: 199289915
Test: manual

Change-Id: Ib96de90f87214ea7bd224d0c543cc9578527366e
2021-10-27 19:08:47 -07:00
Tony Wickham c1cdadf6ea Merge "Fix testStressSwipeToOverview" into sc-v2-dev 2021-10-27 21:39:45 +00:00
Tony Wickham ce6bf7dd7f Fix testStressSwipeToOverview
- Finish recents controller to app rather than to launcher, to ensure taskbar state uses in-app configuration
- Also fix an issue when a gesture completes before onLauncherStart, which happens in 3 button mode. The error I saw in the test was:
java.lang.AssertionError: http://go/tapl test failure: Failed to receive an event for the state change: expected [Overview], actual: [Background, Normal];
Context: want to switch from background to overview, clicking Recents button; now visible state is Background
(This also accurately describes what I saw on the device, where the LauncherState went to Normal but the task was still running in the live tile)

Test: testStressSwipeToOverview
Fixes: 203577620
Change-Id: I19616f7921c9821f1b45a90a3e4bec4fb3b8a9d3
2021-10-27 12:35:31 -07:00
Schneider Victor-tulias 9188b6b993 Update the hotseat edu layout for foldable devices.
Test: ran the hotseat edu on folded and unfolded foldable device in portrait and landscape mode and in three-button and gesture nav mode. ran hotseat edu on regular phone
Fixes: 203734732
Change-Id: Iea2140c8241cdea60cb5db37fbfb7f7701d63bd6
2021-10-27 17:48:46 +00:00
TreeHugger Robot 3edb8de094 Merge "Add mock animated taskbar to gesture nav tutorial for foldable devices." into sc-v2-dev 2021-10-27 17:45:38 +00:00
TreeHugger Robot 0c689ef773 Merge "Clean up IllegalStateException for page pairing" into sc-v2-dev 2021-10-27 11:21:46 +00:00
Tracy Zhou c6bdd9243a Merge "Delete TaskbarStateHander" into sc-v2-dev 2021-10-27 02:11:12 +00:00
Pablo Gamito aae8a2a2a5 Merge "Set custom task transition spec when taskbar is visible" into sc-v2-dev 2021-10-26 21:32:16 +00:00
Tracy Zhou 72f1afcf02 Delete TaskbarStateHander
Bug: 204220602
Test: N/A
Change-Id: I6c26b4d3b8acb35750be56986555350e84f31ecb
2021-10-26 13:26:27 -07:00
TreeHugger Robot e9316d5ba7 Merge "Fix the fallback logic for shortcut icons when icons are missing" into sc-v2-dev 2021-10-26 20:07:40 +00:00
Vadim Tryshev 8629be753f Partially restoring reverted logging
ag/15858126 slowed down everything so
that the flake stopped to repro.

Attempting to reintroduce a more
lightweight logging hoping that the flake will
keep reproing.

Test: presubmit
Bug: 195031154

Change-Id: Ib533c22253e367cced1680a6f4d6736087f0837a
2021-10-26 20:00:55 +00:00
TreeHugger Robot 3cbee2d1d7 Merge "Using a different transition for All-set activity" into sc-v2-dev 2021-10-26 20:00:21 +00:00
TreeHugger Robot 766549a4ca Merge "Fix overview clear all tasks button text color." into sc-v2-dev 2021-10-26 18:37:58 +00:00
Sunny Goyal eed4bbfb49 Using a different transition for All-set activity
Bug: 201797003
Test: Manual
Change-Id: I33b342ca224ab283e2ac475d4defe2eac6a87bb8
2021-10-26 11:25:32 -07:00
Vinit Nayak 3e9bd87ca9 Prevent launching app in split if task split is unsupported
Bug: 204026157
Change-Id: Ie13ac74e0c1d357db242d49083be97f0f45e6ca5
2021-10-26 11:10:23 -07:00
Pinyao Ting 35c5755b71 Fix the fallback logic for shortcut icons when icons are missing
The icons of shortcuts in general are not persisted in backup payload
and thus are not available on the new device, apps are reposponsible for
republishing those shortcuts on the new device, with the only exception
being pinned shortcuts, whose icons are stored in launcher.db as a
fallback when icons are not avaialble in the shortcut themselves.

A previous CL unexpected excluded deep shortcuts from loading their
fallback icons in launcher.db, causes pinned shortcut to fallback
further to default droid icons, this CL restores the original behavior.

Bug: 202346722
Test: manual
Change-Id: Ie09becd3a0dc1ca1e7c2573fe1b68b61a58c2091
2021-10-26 18:02:08 +00:00
TreeHugger Robot 3bd6b8bf81 Merge "Make sure distinct widgets items are used when mapping widget component names to widget items." into sc-v2-dev 2021-10-26 18:01:48 +00:00
Pat Manning 1b5975c205 Fix scroll task off screen to support different screen dimensions.
This will fix the breaks on cuttlefish as seen in b/203781041.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I3b582a9df1790543c4e1521b45494fb462bb5c1c
2021-10-26 18:08:45 +01:00
Sebastian Franco 97503ab4fb Fixing the possibility of opening multiple WidgetsFullSheet
The error is that you can open multiple times the view for
selecting widgets for the Home Screen (i.e. WidgetsFullSheet.java)
but only when using a keyboard by using the command ctrl+w
creating a new instance every time you use it. To fix this
I added a singleton pattern so that only one instance of
WidgetsFullSheet.java can be open at any given point.

Test: Manually Tested
Fix: 196704061
Change-Id: I7a364ee5e746e77455da326a21aff6830ac18e8c
2021-10-26 11:26:21 -05:00
Pablo Gamito 77d3cab287 Set custom task transition spec when taskbar is visible
This is to ensure that the task to task animations look good when the
taskbar is visible (the transition background is the same as the taskbar
color, the taskbar overlay rounded corners are hidden, and the task
animates above the taskbar so it's rounded corners are visible during
the animation and not hidden behind the taskbar).

Test: Open tasks from other tasks to trigger task to task animations and
see if they look good
Bug: 200675009
Bug: 196387647

Change-Id: I8e46718829c0e6541a5c1b1a3a156285aeecd30a
2021-10-26 14:56:27 +02:00
Alina Zaidi 987221a1cc Send widget added and removed events to AiAi.
-Pass the widgets on workspace as an extra List<AppTargetEvents> while
 creating prediction session.
-Notify the session about widget added/removed events after creation.

Bug: 186648032
Test: Manually checked events are received
Change-Id: I4de6c011a1e24c129a3e995ddba16bfc55074939
2021-10-26 12:29:48 +01:00
Tony Wickham add188f339 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev 2021-10-26 02:56:47 +00:00
TreeHugger Robot 8935b22cd7 Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev 2021-10-26 00:06:37 +00:00
Schneider Victor-tulias 1bda3e7424 Fix overview clear all tasks button text color.
Test: checked button on dark/light mode on a wallpaper similar to bug
Fixes: 203198804
Change-Id: I03e663422d2cdba63f3c5953741b5c0bd722fccf
2021-10-25 16:49:36 -07:00
Alex Chau 4941b84717 Merge "Avoid calling getIconResult if recycle is called after request is queued" into sc-v2-dev 2021-10-25 23:30:32 +00:00
TreeHugger Robot c6649763a7 Merge "Fix launching window bounds for immersive apps" into sc-v2-dev 2021-10-25 23:20:47 +00:00
Sebastian Franco 63d1a181e5 Fix the remove button icon not centered when the home screen is in landscape.
To fix it I put the bounds of the Icon/drawable when the text is not visible.

Fix: 202811811
Test: Manually Tested.
Change-Id: Ieff54a73e819c4b3a61e28fd76faf93a84b67666
2021-10-25 17:34:11 -05:00
Tony Wickham 232e9a4631 Hide taskbar background when notification shade is expanded
- In 3 button mode, don't hide the background but do ensure nav buttons are translated down when swiping to notificaitons from the home screen

Test: swipe down notifications, background hides in 0 button mode but not in 3 button mode
Fixes: 199163951
Change-Id: Ic70adc7d67b2ab7c92a2d5d846b9b259d1bd7bfc
2021-10-25 13:44:09 -07:00
Alex Chau 53c7ed5084 Avoid calling getIconResult if recycle is called after request is queued
Fix: 203582251
Test: atest -c NexusLauncherTests:com.android.launcher3.memory.MemoryTests
Change-Id: Ice1e981e1813df516008be578aa89ee17fb79fab
2021-10-25 21:06:27 +01:00
Alina Zaidi fa37c6742e Make sure distinct widgets items are used when mapping widget component
names to widget items.

This is to prevent a crash on duplicate key when creating map.

Bug: 204065759
Test: Enabled flag and got no crash
Change-Id: Ice9f93af76c02eeba53c934687358ed806c60b60
2021-10-25 16:10:45 +01:00
Alex Chau 39da1f78da Fix TaskView jumping caused by split select
- Never apply split select translation to grid overview, instead use dismiss translation to make space to split placeholder to minimize motion and avoid janky double movement
- Ensures snapping to last task for end of grid split cases
- Adjust mCurrentPageScrollDiff due to coordinate shift
- Use longGridRowWidthDiff to shift all task to make space for split placeholder
- Also fixed a bug that split translation isn't reset if entering overview immediately after exit

Bug: 200537815
Test: manual
Change-Id: Ie1b57c34ce4bb079f898ba5b7c3464a714021847
2021-10-25 15:38:34 +01:00
Alex Chau 920be89b26 Clean up IllegalStateException for page pairing
Fix: 198820019
Test: manual
Change-Id: Ic691f781b20d664c57a26370aae479ab68508303
2021-10-25 15:20:16 +01:00
Bill Lin 2745327c5e Allow One-handed gesture when densityDpi > 600
This logic was aim to prevent tablet device enable One-handed gesture
so added displayInfo.densityDpi < DisplayMetrics.DENSITY_600 before.

However, it seems this densityDpi=600 does not able to represent to
tablet device, instead we already have system property
"ro.support_one_handed_mode" which provides feasibility to config false
on tablet project, as the reason we can safe to remove this condition.

Bug: 203936659
Test: adb shell wm density 600 , and observe OHM gesture is available
Test: atest WMShellUnitTests
Change-Id: Ic7ae10e8a47d26b9bb39ab80e22d591d74f89ae5
2021-10-25 06:47:13 +00:00