Commit Graph

35361 Commits

Author SHA1 Message Date
Winson Chung c1afaa4042 Merge "Removing logs" into sc-v2-dev 2021-11-23 21:58:14 +00:00
Vinit Nayak 458832c09e Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev 2021-11-23 20:09:47 +00:00
TreeHugger Robot db5f5f05e7 Merge "Add scrim below TaskMenu" into sc-v2-dev 2021-11-23 19:29:00 +00:00
Thales Lima f316a267d8 Add scrim below TaskMenu
When opening a menu, a scrim with 80% alpha should be shown on top of
Recents view.

Align task menu second row with icon: when the menu shows up in the
bottom row in landscape, the menu should be aligned on the second row.

TODO: there is a RTL bug that I'm waiting because it also affects other
parts, not only this menu.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: I6846ee937cb5e739e8be64d17045bc3b32e28e46
2021-11-23 09:13:25 -03:00
Winson Chung 34e384d2e1 Fix issue with Shell listeners being unbound if SysUI is restarted
- If SysUI is restarted (ie. during dev or a crash), the components
  registering the shell listeners may not be aware of this, and
  listener callbacks will not be re-registered.  Currently all the
  listeners are managed correctly (bound & later unbound) so we can
  just keep the active listener references to re-register if this
  happens.

Bug: 207142749
Test: Kill SysUI, start some apps and ensure Launcher still shows them
      in recents
Change-Id: Iba3b11ee972caf8f0b482942d38c3a7359211180
2021-11-23 08:04:14 +00:00
TreeHugger Robot 0b7ed895e7 Merge "Invoke Assistant on 3 button long click on Taskbar" into sc-v2-dev 2021-11-23 03:34:04 +00:00
Vinit Nayak bca13abc82 Invoke Assistant on 3 button long click on Taskbar
Bug: 204273914
Change-Id: I757fa40ad9ac0ace44b57c7dd08ec30b4c0ae6d0
2021-11-22 17:32:16 -08:00
Winson Chung a5642379d9 Merge "Skip scheduling frame callback if view root is already detached" into sc-v2-dev 2021-11-23 00:41:30 +00:00
Tony Wickham 426b021e22 Merge "Add support for dark tint on taskbar nav buttons" into sc-v2-dev 2021-11-22 22:05:35 +00:00
Alex Chau 48644c75b3 Merge "Consider launching task's position on screen in pivot calculation" into sc-v2-dev 2021-11-22 21:07:41 +00:00
TreeHugger Robot 953641e28d Merge "Add timeout to AbstractLauncherUiTest.getOnUiThread" into sc-v2-dev 2021-11-22 20:59:16 +00:00
Alex Chau 31b46953cb Add timeout to AbstractLauncherUiTest.getOnUiThread
- Send signal 6 to Launcher process when this happens to get a thread dump

Bug: 203416429
Test: labtest
Change-Id: If22b58418be33131e7f585e718a2197cda2e7365
2021-11-22 18:36:11 +00:00
vadimt 499e2055a6 Logging the stack trace for system anomaly messages
With these system anomalies, you are never sure that the system/tests will be able to normally bubble up the error.

Bug: 203416429
Test: presubmit

Change-Id: Ie1d3d183cf6e56778d5c052ef7b8e0541bbc6255
(cherry picked from commit 37542c8c0e1aed42fcdbd8406f0257cd5fea48bf)
2021-11-22 18:08:00 +00:00
Winson Chung 550dc8dc69 Merge "Clear ref after animation if visual stashing not supported" into sc-v2-dev 2021-11-22 17:22:16 +00:00
Alex Chau 4f49c9ce62 Log the display state when number of screen bounds is inconsistent
- If the number of screen bounds a.k.a. number of displays has changed, it should be a bug from system and add a log for that

Bug: 198965093
Test: manual
Change-Id: I74612e6c0d2f3cfd52b509e43ea16adf0eec76de
2021-11-22 15:16:17 +00:00
Alex Chau 3c2298668a Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev 2021-11-22 11:12:23 +00:00
Winson Chung e2074f01c0 Skip scheduling frame callback if view root is already detached
- Also remove references to deprecrated compat class

Bug: 206932656
Test: Presubmit
Change-Id: I1add65b0fe03dedea872d162e51095bf9c648acf
2021-11-20 00:58:43 +00:00
Winson Chung c2a84d887f Clear ref after animation if visual stashing not supported
Bug: 206814323
Test: Presubmit
Change-Id: Ia38bd2707edbddf1b1f2ad98b3cdac4c8c62a6d3
2021-11-19 23:52:18 +00:00
Winson Chung 5e49df2bbe Merge "Set sync applier on the transform params for the glued targets" into sc-v2-dev 2021-11-19 22:24:13 +00:00
Jonathan Miranda 2d9ac4e67f Merge "Use empty intent instead of null when creating stub TaskKey" into sc-v2-dev 2021-11-19 22:05:07 +00:00
Vinit Nayak 54baaae0ab Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev 2021-11-19 21:51:03 +00:00
Zak Cohen d95942132d Remove temporary logging for NO_SCREENSHOT bug/.
Bug: 202414125, 203583301
Test: Local
Change-Id: I8345bd9f1c3ee93971d64ed49cf613cfd09ce10c
2021-11-19 13:49:36 -08:00
Alex Chau 7ba828c1a9 Merge "Use only current density to check isTablet" into sc-v2-dev 2021-11-19 20:24:57 +00:00
Jon Miranda 1f2b9b1c36 Use empty intent instead of null when creating stub TaskKey
Bug: 199027804
Test: manual
Change-Id: Ie66c8740453088791e026fa51a2842f59c6c67fd
2021-11-19 12:06:42 -08:00
Vinit Nayak a59835214f Open taskMenu based on TaskIdAttributeContainer
* We were always passing in the same task no matter
which task icon was clicked.
* Use TaskIdAttributeContainer to associate
IconViews with their respective tasks

Fixes: 206154715
Test: Correct menu opens for split and fullscreen
tasks

Change-Id: I5f264bb69828532bdefffb7ec4b9ff1e501de086
2021-11-19 11:38:31 -08:00
Winson Chung a5960223cf Set sync applier on the transform params for the glued targets
Bug: 199043513
Test: Swipe up with split task and scroll really quickly
Change-Id: Ie10b27457903d8db4d4c973ab5b7e669da2c4998
2021-11-19 19:33:54 +00:00
Jonathan Scott 6547721d8c Merge "Revert "Open taskMenu based on TaskIdAttributeContainer"" into sc-v2-dev 2021-11-19 16:44:30 +00:00
Jonathan Scott ec79eb9cbc Revert "Open taskMenu based on TaskIdAttributeContainer"
This reverts commit c1ec2d4260.

Reason for revert: broken build b/207126572

Change-Id: I0908e8e6579bc54c6ce1dff88bddf8b030f336d9
Fixes: 207126572
2021-11-19 16:43:45 +00:00
TreeHugger Robot 988a87526e Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev 2021-11-19 16:06:30 +00:00
Alex Chau 2998307cd6 Use only current density to check isTablet
- Removed DeviceProfile.allowRotation and use DeviceProfile.isTablet instead, which only uses current density to calculate its value
- Reverted default allow_rotation preference handling to before ag/14234761

Fix: 203817448
Test: isTablet is set correctly in different screen sizes
Change-Id: Ic6c8dfc774e7787f62d489ad27720a7644c1e8c7
2021-11-19 15:27:01 +00:00
Alex Chau 6499e83c57 Consider launching task's position on screen in pivot calculation
- Instead of using RecentsViewScroll, put task's position offset versus current scroll as TaskRect calculation, so it's considered when calculating for putting task to full screen
- Revert back RecentsViewScroll to apply before RecentsViewScale
- Added new property in PagedOrientationHandler to apply both primary/secondary param without clearing the other, and renamed an existing method

Fix: 206972618
Test: Quick switching
Test: Launch task from grid, launch side task from carousel overview
Change-Id: I5977975ed1e930ad70b81d83513d8f3a00c0aed4
2021-11-19 14:42:20 +00:00
Fedor Kudasov 039501f41f Merge "Move FloatingTaskInit set up into init method" into sc-v2-dev 2021-11-19 10:26:46 +00:00
Vinit Nayak f957244b88 Show multiple App Info A11y options for split app icons
* AccessibilityNode actions are required to have a
unique resourceId to show as an action in A11y dialog.
For now, only AppInfo option is shown for each app in split,
but moving forward we'll need to add resourceIDs for
each option that can show up for either app.

Fixes: 200609838
Test: Saw multiple options for App Info for each app
come up in talkback mode

Change-Id: I92b349347354ac639537021d775eea814c866a0e
2021-11-18 23:22:46 -08:00
Vinit Nayak 788821ec4e Launch GroupedTaskView from thumbnails
* Previously when starting the remote animation
we were relying on SplitPlaceholderViews to
animate into the proper place since we weren't
launching from the TaskView itself
* Now when launching from a GroupedTaskView,
we use the existing animation that handles that
animation in addition to showing the new split tasks

Fixes: 206608786
Test: Thumbnails animate from home -> overview -> launch
Change-Id: I1499ead7d90cd41e285ed0f4df66ea31f0dfbc95
2021-11-18 22:58:53 -08:00
TreeHugger Robot 8c8e2a22da Merge "Revert "Adding screen record for a flake"" into sc-v2-dev 2021-11-19 00:51:07 +00:00
TreeHugger Robot 84b64d7910 Merge "Reset split selection state when RecentsView resets" into sc-v2-dev 2021-11-18 23:51:47 +00:00
Vinit Nayak 97f9bd575a Reset split selection state when RecentsView resets
* We weren't calling reset on the views
involved in split selection when recents view gets
a reset call (oops)
* Use device theme for split placeholder theme instead
of hardcoding to white

Fixes: 206155455
Change-Id: I3768fd574cb21eec9562d89c1a93eaa3f53d5ff1
2021-11-18 14:06:27 -08:00
TreeHugger Robot 39aceb6dc7 Merge "Check if ThumbnailData's bitmap is null in TaskThumbnailCache" into sc-v2-dev 2021-11-18 19:46:50 +00:00
Schneider Victor-tulias ce740c832c Merge "Add TODO to fix b/206508141 before removing or changing the default value to the feature flag ENABLE_LOCAL_COLOR_POPUPS" into sc-v2-dev 2021-11-18 18:45:16 +00:00
TreeHugger Robot 722d0b7e90 Merge changes from topic "presubmit-am-18a7324d3163401db618e725a06a3dba" into sc-qpr1-dev am: a33cbebd8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16291580

Change-Id: I435e83246fb3f55c420351ce7d870c84eee8a49e
2021-11-18 18:34:14 +00:00
Bill Yi 39d1454a8f [automerger skipped] [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: 3e39786ec3 am: 8aa6d024aa -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16291580

Change-Id: I8c448a9be802f61f69423180f86b3714b5bdd725
2021-11-18 18:34:13 +00:00
Thales Lima bd1aec6721 Merge "open grid task menu to the right of icon" into sc-v2-dev 2021-11-18 18:19:58 +00:00
TreeHugger Robot a33cbebd8d Merge changes from topic "presubmit-am-18a7324d3163401db618e725a06a3dba" into sc-qpr1-dev
* changes:
  [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: 3e39786ec3
  Import translations. DO NOT MERGE ANYWHERE
2021-11-18 18:18:41 +00:00
Bill Yi 9dc66c4bd7 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f841aa488d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16291585

Change-Id: I7876bfffdef580a4b3a44e4342915ea7f4b980d7
2021-11-18 18:03:19 +00:00
TreeHugger Robot 160d85c815 Merge "Adding back the badges on widgets for widget recommendations." into sc-v2-dev 2021-11-18 17:44:50 +00:00
TreeHugger Robot f46f911fd1 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-11-18 17:20:21 +00:00
Alex Chau 4670d37e55 Check if ThumbnailData's bitmap is null in TaskThumbnailCache
- This makes sure TaskThumbnailCache fetch for thumbnail when its Bitamp is null

Fix: 206959035
Test: See steps in b/206959035
Change-Id: I03b574b0f8cc7390a8cad618bd810f44f0dee279
2021-11-18 15:57:28 +00:00
Thales Lima 45f2306ce9 open grid task menu to the right of icon
This makes the TaskMenuViewWithArrow open to the right of the icon if
there is enough space, and to the left if not. It also works correctly
in RTL, inverting the side to open by default.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Ib1098f48ed28d2e0758fb0e3fb733e86271fa1a0
2021-11-18 12:01:16 -03:00
TreeHugger Robot 1edee616ae Merge "Move live tile app to top when the task view is tapped" into sc-v2-dev 2021-11-18 12:26:05 +00:00
Alex Chau 60d5315e19 Refresh overlay when thumbnail was set for first time
Bug: 202414125
Test: TaplTestsNexus.testOverviewActions && TaplTestsQuickstep.testOverviewActions
Change-Id: I2cc38df4c891fb21a8295d4f9c75e396c71449f2
2021-11-18 10:31:13 +00:00