Commit Graph

35879 Commits

Author SHA1 Message Date
Steven Moreland d05ecb8d9d Merge "libutils: check vsnprintf error" into oc-dev am: a03d37d542 am: d8801aaad8
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/core/+/12254459

Change-Id: Ifa0692e4966e78f4e180a2efc53db991177b6006
2020-08-04 22:03:55 +00:00
Steven Moreland d8801aaad8 Merge "libutils: check vsnprintf error" into oc-dev am: a03d37d542
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/core/+/12254459

Change-Id: Id247c7079c146da8eaf52f098027d5daa25ce8d8
2020-08-04 21:37:54 +00:00
Steven Moreland a03d37d542 Merge "libutils: check vsnprintf error" into oc-dev 2020-08-04 21:20:36 +00:00
TreeHugger Robot 84dcff4c6b Merge "Fail explicitly on length overflow." into oc-dev am: ea8d38e77f am: cf91151364
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/core/+/11619803

Change-Id: Idb480f2a4dc1aa0d929e17e7e568a9c1b05c8489
2020-07-31 20:03:44 +00:00
TreeHugger Robot cf91151364 Merge "Fail explicitly on length overflow." into oc-dev am: ea8d38e77f
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/core/+/11619803

Change-Id: I9a6def9ff590fdadb457e9a011df3532829d23f4
2020-07-31 19:45:35 +00:00
TreeHugger Robot ea8d38e77f Merge "Fail explicitly on length overflow." into oc-dev 2020-07-31 19:24:50 +00:00
Steven Moreland ee22384c54 libutils: check vsnprintf error
For encoding errors, this function will return a negative value which
causes problems down the line. Check for an error and return. Also,
integer overflows are guarded.

Bug: 161894517
Test: fuzzer test case
Change-Id: Ia85067d4258bde4b875c832d6223db5dd26b8838
Merged-In: Ia85067d4258bde4b875c832d6223db5dd26b8838
2020-07-30 17:29:34 +00:00
Steven Moreland 9be245c3f0 String16::remove - avoid overflow am: 4048e49956 am: 107f18cb61
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/core/+/11619802

Change-Id: I22f6b8299b4b77be31859a10b14efe01b297d531
2020-07-14 15:51:29 +00:00
Steven Moreland 107f18cb61 String16::remove - avoid overflow am: 4048e49956
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/core/+/11619802

Change-Id: I4dedf81e3471473e589a858e14d7a9ae5f91b3d9
2020-07-14 15:37:25 +00:00
Christopher Ferris 4d14303653 Fail explicitly on length overflow.
Instead of aborting when FileMap::create detects an overflow, detect the
overflow directly and fail the call.

Bug: 156997193

Test: Ran unit tests, including new unit test that aborted before.
Change-Id: Ie49975b8949fd12bbde14346ec9bbb774ef88a51
Merged-In: Ie49975b8949fd12bbde14346ec9bbb774ef88a51
(cherry picked from commit 68604b9c29)
2020-06-04 11:05:18 -07:00
Steven Moreland 4048e49956 String16::remove - avoid overflow
Bug: 156999009
Test: libutils_test (cases added)
Change-Id: Iad46d95d9848928ba81000090b2fe9aec1e5eaac
Merged-In: Iad46d95d9848928ba81000090b2fe9aec1e5eaac
(cherry picked from commit f251c1c581)
(cherry picked from commit 9a9c8910e9296c9dc8d79c37f589895f5a2a836c)
2020-05-28 20:45:55 +00:00
Steven Moreland 3f273f49f1 FlattenableUtils::align memsets am: e62a9d7669
am: 59e7d4e8ea

Change-Id: I1105027b52c3621e2031bdb747de61ce54d3ec74
2019-11-06 16:06:57 -08:00
Steven Moreland 59e7d4e8ea FlattenableUtils::align memsets
am: e62a9d7669

Change-Id: I51a5528d8544f374ff3ceb632e75a1d3ae97d963
2019-11-06 15:55:08 -08:00
Steven Moreland e62a9d7669 FlattenableUtils::align memsets
Bug: 141890807
Test: boot, check data is zero'd
Change-Id: I45aaeac369f4c5cf3eb44f61c233e00f870a5c79
(cherry picked from commit bf824f8fa5)
2019-10-15 19:26:22 +00:00
Janis Danisevskis ca662c7118 [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d am: 7535975701 am: e126026c02 am: 4ae4ad8e5b am: b25983460c
am: 20e73e23c4

Change-Id: I026aa5ddb79cd10146924fd6625816782645f660
2019-06-21 13:38:10 -07:00
Janis Danisevskis 20e73e23c4 [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d am: 7535975701 am: e126026c02 am: 4ae4ad8e5b
am: b25983460c

Change-Id: Ie7a02bb3c7b283f3497a469e0cd3b2b69792d2f6
2019-06-21 13:33:05 -07:00
Android Build Merger (Role) b25983460c [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d am: 7535975701 am: e126026c02 am: 4ae4ad8e5b
Change-Id: I3fb4fc631eccd68a8f4468363d841855f94187f9
2019-06-20 22:31:20 +00:00
Android Build Merger (Role) 4ae4ad8e5b [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d am: 7535975701 am: e126026c02
Change-Id: I98df60cfed36c714dae1fa4218d3c5ef23c4035c
2019-06-20 22:31:18 +00:00
Android Build Merger (Role) e126026c02 [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d am: 7535975701
Change-Id: I25e3d526bb3f09c826d204909ea1763af4eb951d
2019-06-20 22:31:15 +00:00
Android Build Merger (Role) 7535975701 [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d
Change-Id: I2e9d6b1a5badb501adc641b17ce337c911d09610
2019-06-20 22:31:13 +00:00
Android Build Merger (Role) bdc924f31d [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968
Change-Id: Ie5dd32eec9a24b329ff4c5fd18c8f535f43c9bc7
2019-06-20 22:31:11 +00:00
Janis Danisevskis 6a9c4e7968 Fix a memory leak in gatekeeper.
In violation to the documentation of GateKeeper::GetAuthTokenKey and
GateKeeper::GetPasswordKey, the implementations in SoftGateKeeper
allocate and return buffers and relinquish ownership causing a memory
leak, because the caller expects the implementation to retain ownership.

Bug: 129768470
Bug: 134557251
Test: gatekeeper-unit-tests
Change-Id: I0af9539d3dcd47dfd1e7d80cdee700ea0c2d6d0f
Merged-In: I0af9539d3dcd47dfd1e7d80cdee700ea0c2d6d0f
2019-06-20 22:31:06 +00:00
Martijn Coenen c9455b4740 [automerger skipped] Export maximum number of fds/ints in a native_handle. am: c1cea05b5f -s ours am skip reason: change_id I0eafff70d3a7e4d732fe600a0052efb90108208d with SHA1 02debfa2df is in history
am: 479b8544c6 -s ours
am skip reason: change_id I0eafff70d3a7e4d732fe600a0052efb90108208d with SHA1 02debfa2df is in history

Change-Id: If4f1b92e9ed89bfd50fc0621ded802255165b2de
2019-01-07 04:29:02 -08:00
Martijn Coenen 479b8544c6 [automerger skipped] Export maximum number of fds/ints in a native_handle.
am: c1cea05b5f -s ours
am skip reason: change_id I0eafff70d3a7e4d732fe600a0052efb90108208d with SHA1 02debfa2df is in history

Change-Id: I64ce50c8c687a849a2e2acdcacda42c98d3a4115
2019-01-07 04:23:56 -08:00
Martijn Coenen 5fa5708025 Export maximum number of fds/ints in a native_handle.
am: 02debfa2df

Change-Id: I36da3de7dcad006ee647163a62b0d5c8819b994e
2019-01-04 10:46:21 -08:00
Martijn Coenen c1cea05b5f Export maximum number of fds/ints in a native_handle.
So we can deserialize it consisently and safely.

Bug: 120084106
Test: builds
Change-Id: I0eafff70d3a7e4d732fe600a0052efb90108208d
Merged-In: I0eafff70d3a7e4d732fe600a0052efb90108208d
2018-12-11 11:07:49 +00:00
Martijn Coenen 02debfa2df Export maximum number of fds/ints in a native_handle.
So we can deserialize it consisently and safely.

Bug: 120084106
Test: builds
Change-Id: I0eafff70d3a7e4d732fe600a0052efb90108208d
2018-12-11 11:38:41 +01:00
Steven Moreland 4e13bf0e73 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913 am: f479f90679 am: e9df4d52f7 am: dd95a7f10d am: f546acd3fa -s ours
am: 9ce034ce8a  -s ours

Change-Id: I6dc6d1628deb2992d292672a20e1b7209ca8fcb5
2018-03-09 03:04:48 +00:00
Steven Moreland 9ce034ce8a [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913 am: f479f90679 am: e9df4d52f7 am: dd95a7f10d
am: f546acd3fa  -s ours

Change-Id: I00bb77d99b2e4548215a64a80d89c214b0759c10
2018-03-09 02:57:24 +00:00
Android Build Merger (Role) f546acd3fa [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913 am: f479f90679 am: e9df4d52f7 am: dd95a7f10d
Change-Id: Ic2cae6509c07e60fe66494b4b37fc5f0d29f068e
2018-03-09 01:49:02 +00:00
Android Build Merger (Role) dd95a7f10d [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913 am: f479f90679 am: e9df4d52f7
Change-Id: Ifab7435d2c707247b64b6debccbdd00224bdc6af
2018-03-09 01:49:01 +00:00
Android Build Merger (Role) e9df4d52f7 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913 am: f479f90679
Change-Id: Ib19d60a2933bf9ca6aa7eaeb285055d0f2c01452
2018-03-09 01:49:00 +00:00
Android Build Merger (Role) f479f90679 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913
Change-Id: Ia9d1a2f4387bdd11085163ffea0e99d22d43757f
2018-03-09 01:48:58 +00:00
Android Build Merger (Role) dc2153c913 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe
Change-Id: I1f668592187eef0bb882372f42529d147ce49786
2018-03-09 01:48:57 +00:00
Android Build Merger (Role) 35629db6fe [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14
Change-Id: Ifc14cf3778241da9ba4d06e3e8913c08dec085ce
2018-03-09 01:48:55 +00:00
Android Build Merger (Role) 4ca82d1d14 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0
Change-Id: I61308a749e84d4a909d22e4365bbd403fcf67dd4
2018-03-09 01:48:54 +00:00
Android Build Merger (Role) 726007edf0 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd
Change-Id: Iaf27e11e7beb60499e8c44c8659a13a02c923cbd
2018-03-09 01:48:53 +00:00
Android Build Merger (Role) 9de539d0dd [automerger] String16: remove integer overflows am: d0648d8dc6
Change-Id: Ib1bb7df40aac5be2ff7a704038279e4768b18f88
2018-03-09 01:48:52 +00:00
Steven Moreland 1549baa415 String16: remove integer overflows am: 0e5fbea01c
am: b02e0ab211

Change-Id: I618aaf491fb6309a3e313f4eeed62f68822f574d
2018-03-08 22:20:15 +00:00
Steven Moreland b02e0ab211 String16: remove integer overflows
am: 0e5fbea01c

Change-Id: I60af627000e8c8d4ad44dfafcfdea772afad3838
2018-03-08 22:13:10 +00:00
Steven Moreland d0648d8dc6 String16: remove integer overflows
Bug: 73826242
Test: manual
Change-Id: I32e13d61b944c1a527cf2d95473552d246e322be
Merged-In: I32e13d61b944c1a527cf2d95473552d246e322be
2018-03-02 20:26:45 +00:00
Steven Moreland 0e5fbea01c String16: remove integer overflows
Bug: 73826242
Test: manual
Change-Id: I32e13d61b944c1a527cf2d95473552d246e322be
2018-03-02 20:16:28 +00:00
tintin d60dc7ef5c libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87 am: 804323c195 am: 4f5f00d879 am: 3a1ff1ad71 am: bab7b1ecd9 am: cdf0fc6018
am: 9f1398c6e3

Change-Id: I4c46a36846dd8f6588f29bc84de9bc3f1d7c088a
2017-11-02 03:28:42 +00:00
tintin 9f1398c6e3 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87 am: 804323c195 am: 4f5f00d879 am: 3a1ff1ad71 am: bab7b1ecd9
am: cdf0fc6018

Change-Id: If9bc99849e62fe38cdf52180ff76390c452e0784
2017-11-02 03:25:33 +00:00
tintin cdf0fc6018 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87 am: 804323c195 am: 4f5f00d879 am: 3a1ff1ad71
am: bab7b1ecd9

Change-Id: Id56f81b841d83b4b6fc75517fa165c0000dac663
2017-11-02 03:23:59 +00:00
tintin bab7b1ecd9 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87 am: 804323c195 am: 4f5f00d879
am: 3a1ff1ad71

Change-Id: Ibea1269632e1700617b55f0ede7a0d9cc6442871
2017-11-02 03:21:57 +00:00
tintin 3a1ff1ad71 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87 am: 804323c195
am: 4f5f00d879

Change-Id: Id2e1d882921b8a69f191e90032539a2e5835f05d
2017-11-02 03:18:53 +00:00
tintin 4f5f00d879 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87
am: 804323c195

Change-Id: I27c237896e46f15c258fda00a9ab23465691cb9e
2017-11-02 03:16:51 +00:00
tintin 804323c195 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499
am: 8191e9ba87

Change-Id: Ia297a2af179285b63e7d5d3d1d64baf71dadaef0
2017-11-02 03:14:34 +00:00
tintin 8191e9ba87 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840
am: 19702dc499

Change-Id: I5056e93b303683a70c38251f282c80e810fb317b
2017-11-02 03:11:49 +00:00