Commit Graph

31857 Commits

Author SHA1 Message Date
TreeHugger Robot ea8d38e77f Merge "Fail explicitly on length overflow." into oc-dev 2020-07-31 19:24:50 +00:00
Christopher Ferris 4d14303653 Fail explicitly on length overflow.
Instead of aborting when FileMap::create detects an overflow, detect the
overflow directly and fail the call.

Bug: 156997193

Test: Ran unit tests, including new unit test that aborted before.
Change-Id: Ie49975b8949fd12bbde14346ec9bbb774ef88a51
Merged-In: Ie49975b8949fd12bbde14346ec9bbb774ef88a51
(cherry picked from commit 68604b9c29)
2020-06-04 11:05:18 -07:00
Steven Moreland 4048e49956 String16::remove - avoid overflow
Bug: 156999009
Test: libutils_test (cases added)
Change-Id: Iad46d95d9848928ba81000090b2fe9aec1e5eaac
Merged-In: Iad46d95d9848928ba81000090b2fe9aec1e5eaac
(cherry picked from commit f251c1c581)
(cherry picked from commit 9a9c8910e9296c9dc8d79c37f589895f5a2a836c)
2020-05-28 20:45:55 +00:00
Steven Moreland e62a9d7669 FlattenableUtils::align memsets
Bug: 141890807
Test: boot, check data is zero'd
Change-Id: I45aaeac369f4c5cf3eb44f61c233e00f870a5c79
(cherry picked from commit bf824f8fa5)
2019-10-15 19:26:22 +00:00
Android Build Merger (Role) b25983460c [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d am: 7535975701 am: e126026c02 am: 4ae4ad8e5b
Change-Id: I3fb4fc631eccd68a8f4468363d841855f94187f9
2019-06-20 22:31:20 +00:00
Android Build Merger (Role) 4ae4ad8e5b [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d am: 7535975701 am: e126026c02
Change-Id: I98df60cfed36c714dae1fa4218d3c5ef23c4035c
2019-06-20 22:31:18 +00:00
Android Build Merger (Role) e126026c02 [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d am: 7535975701
Change-Id: I25e3d526bb3f09c826d204909ea1763af4eb951d
2019-06-20 22:31:15 +00:00
Android Build Merger (Role) 7535975701 [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968 am: bdc924f31d
Change-Id: I2e9d6b1a5badb501adc641b17ce337c911d09610
2019-06-20 22:31:13 +00:00
Android Build Merger (Role) bdc924f31d [automerger] Fix a memory leak in gatekeeper. am: 6a9c4e7968
Change-Id: Ie5dd32eec9a24b329ff4c5fd18c8f535f43c9bc7
2019-06-20 22:31:11 +00:00
Janis Danisevskis 6a9c4e7968 Fix a memory leak in gatekeeper.
In violation to the documentation of GateKeeper::GetAuthTokenKey and
GateKeeper::GetPasswordKey, the implementations in SoftGateKeeper
allocate and return buffers and relinquish ownership causing a memory
leak, because the caller expects the implementation to retain ownership.

Bug: 129768470
Bug: 134557251
Test: gatekeeper-unit-tests
Change-Id: I0af9539d3dcd47dfd1e7d80cdee700ea0c2d6d0f
Merged-In: I0af9539d3dcd47dfd1e7d80cdee700ea0c2d6d0f
2019-06-20 22:31:06 +00:00
Martijn Coenen c1cea05b5f Export maximum number of fds/ints in a native_handle.
So we can deserialize it consisently and safely.

Bug: 120084106
Test: builds
Change-Id: I0eafff70d3a7e4d732fe600a0052efb90108208d
Merged-In: I0eafff70d3a7e4d732fe600a0052efb90108208d
2018-12-11 11:07:49 +00:00
Android Build Merger (Role) f546acd3fa [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913 am: f479f90679 am: e9df4d52f7 am: dd95a7f10d
Change-Id: Ic2cae6509c07e60fe66494b4b37fc5f0d29f068e
2018-03-09 01:49:02 +00:00
Android Build Merger (Role) dd95a7f10d [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913 am: f479f90679 am: e9df4d52f7
Change-Id: Ifab7435d2c707247b64b6debccbdd00224bdc6af
2018-03-09 01:49:01 +00:00
Android Build Merger (Role) e9df4d52f7 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913 am: f479f90679
Change-Id: Ib19d60a2933bf9ca6aa7eaeb285055d0f2c01452
2018-03-09 01:49:00 +00:00
Android Build Merger (Role) f479f90679 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe am: dc2153c913
Change-Id: Ia9d1a2f4387bdd11085163ffea0e99d22d43757f
2018-03-09 01:48:58 +00:00
Android Build Merger (Role) dc2153c913 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14 am: 35629db6fe
Change-Id: I1f668592187eef0bb882372f42529d147ce49786
2018-03-09 01:48:57 +00:00
Android Build Merger (Role) 35629db6fe [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0 am: 4ca82d1d14
Change-Id: Ifc14cf3778241da9ba4d06e3e8913c08dec085ce
2018-03-09 01:48:55 +00:00
Android Build Merger (Role) 4ca82d1d14 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd am: 726007edf0
Change-Id: I61308a749e84d4a909d22e4365bbd403fcf67dd4
2018-03-09 01:48:54 +00:00
Android Build Merger (Role) 726007edf0 [automerger] String16: remove integer overflows am: d0648d8dc6 am: 9de539d0dd
Change-Id: Iaf27e11e7beb60499e8c44c8659a13a02c923cbd
2018-03-09 01:48:53 +00:00
Android Build Merger (Role) 9de539d0dd [automerger] String16: remove integer overflows am: d0648d8dc6
Change-Id: Ib1bb7df40aac5be2ff7a704038279e4768b18f88
2018-03-09 01:48:52 +00:00
Steven Moreland d0648d8dc6 String16: remove integer overflows
Bug: 73826242
Test: manual
Change-Id: I32e13d61b944c1a527cf2d95473552d246e322be
Merged-In: I32e13d61b944c1a527cf2d95473552d246e322be
2018-03-02 20:26:45 +00:00
Steven Moreland 0e5fbea01c String16: remove integer overflows
Bug: 73826242
Test: manual
Change-Id: I32e13d61b944c1a527cf2d95473552d246e322be
2018-03-02 20:16:28 +00:00
tintin cdf0fc6018 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87 am: 804323c195 am: 4f5f00d879 am: 3a1ff1ad71
am: bab7b1ecd9

Change-Id: Id56f81b841d83b4b6fc75517fa165c0000dac663
2017-11-02 03:23:59 +00:00
tintin bab7b1ecd9 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87 am: 804323c195 am: 4f5f00d879
am: 3a1ff1ad71

Change-Id: Ibea1269632e1700617b55f0ede7a0d9cc6442871
2017-11-02 03:21:57 +00:00
tintin 3a1ff1ad71 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87 am: 804323c195
am: 4f5f00d879

Change-Id: Id2e1d882921b8a69f191e90032539a2e5835f05d
2017-11-02 03:18:53 +00:00
tintin 4f5f00d879 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499 am: 8191e9ba87
am: 804323c195

Change-Id: I27c237896e46f15c258fda00a9ab23465691cb9e
2017-11-02 03:16:51 +00:00
tintin 804323c195 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840 am: 19702dc499
am: 8191e9ba87

Change-Id: Ia297a2af179285b63e7d5d3d1d64baf71dadaef0
2017-11-02 03:14:34 +00:00
tintin 8191e9ba87 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8 am: 3de04e9840
am: 19702dc499

Change-Id: I5056e93b303683a70c38251f282c80e810fb317b
2017-11-02 03:11:49 +00:00
tintin 19702dc499 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f am: c29049f4f8
am: 3de04e9840

Change-Id: I72b1d728918b7359236e57b67805d9a9521e49e0
2017-11-02 03:10:14 +00:00
tintin 3de04e9840 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55 am: 29d054046f
am: c29049f4f8

Change-Id: I6949ceb5c4dee7ea0c97cdc79f0ce0a1dde84651
2017-11-02 03:08:48 +00:00
tintin c29049f4f8 libnetutil: Check dhcp respose packet length am: 61f25d4a36 am: cee6d38c55
am: 29d054046f

Change-Id: Ic15afbd822f6901e6db9274304af3e587fa8ce08
2017-11-02 03:05:45 +00:00
tintin 29d054046f libnetutil: Check dhcp respose packet length am: 61f25d4a36
am: cee6d38c55

Change-Id: Ieac19dd67cee1f22e019ac87b33b8afcd1200dcb
2017-11-02 03:03:42 +00:00
tintin cee6d38c55 libnetutil: Check dhcp respose packet length
am: 61f25d4a36

Change-Id: Id5158c66d2ade871c90a2337fe867f977cefdca3
2017-11-02 03:01:40 +00:00
Narayan Kamath fb1a14ad59 DO NOT MERGE : Partially revert change 141d1d836465e8a5a56a5cc1e. am: bfe4b5edb3 -s ours am: e1257bad6e -s ours am: 89b22dff0a am: 4bcb04290d am: 3a46bcc3e0 am: 9800d5d074 -s ours am: c995780ded am: 10d3ff2004 am: 5bccb55338 am: 7fe7bce52f
am: d07ba77e60  -s ours

Change-Id: I1f7f0cfa5b5f550dc2850a1845734e3ef5ee6929
2017-10-19 19:40:28 +00:00
Narayan Kamath b1f99e94d8 DO NOT MERGE : Fix build breakage due to 2d516d2d46. am: eeb93c9a64 -s ours am: 951b0dccf0 am: 6e598b9e9d am: 4b187be82f am: b46123a98d -s ours am: 97d2cfab6a am: ea2010e196 am: a4de1f4749 am: 5995e741e5
am: bc5fc101ad  -s ours

Change-Id: I416210e446828495b6b0db054b77e15a8b1dd731
2017-10-19 19:38:28 +00:00
Narayan Kamath d07ba77e60 DO NOT MERGE : Partially revert change 141d1d836465e8a5a56a5cc1e. am: bfe4b5edb3 -s ours am: e1257bad6e -s ours am: 89b22dff0a am: 4bcb04290d am: 3a46bcc3e0 am: 9800d5d074 -s ours am: c995780ded am: 10d3ff2004 am: 5bccb55338
am: 7fe7bce52f

Change-Id: I500587ac26d3b5420598520ee196cf696b39f4f9
2017-10-19 19:38:23 +00:00
Narayan Kamath bc5fc101ad DO NOT MERGE : Fix build breakage due to 2d516d2d46. am: eeb93c9a64 -s ours am: 951b0dccf0 am: 6e598b9e9d am: 4b187be82f am: b46123a98d -s ours am: 97d2cfab6a am: ea2010e196 am: a4de1f4749
am: 5995e741e5

Change-Id: I8ad269b877b307eb104f7b749ad728b931dd0aa2
2017-10-19 19:37:17 +00:00
Narayan Kamath 7fe7bce52f DO NOT MERGE : Partially revert change 141d1d836465e8a5a56a5cc1e. am: bfe4b5edb3 -s ours am: e1257bad6e -s ours am: 89b22dff0a am: 4bcb04290d am: 3a46bcc3e0 am: 9800d5d074 -s ours am: c995780ded am: 10d3ff2004
am: 5bccb55338

Change-Id: I42e59e67fec69f487fdffed07f84625714a58eaa
2017-10-19 19:36:20 +00:00
Narayan Kamath c26850c970 DO NOT MERGE : Fix build breakage due to 2d516d2d46. am: 547c7d9a0b -s ours am: 4732ec6440 -s ours am: 59c7fe7a39 am: 28a7d07705 am: a413ac3c8a am: 685a175cb0 -s ours am: 886eb4351e am: 4f22203279 am: ea729dcae5 am: 369bf9065d
am: 79f474a679  -s ours

Change-Id: I31ef016a5e85f365e0aa297fe37c65d2a391071b
2017-10-19 19:36:01 +00:00
Narayan Kamath 3fb0e4ae70 Merge "zip_archive: reject files that don't start with an LFH signature." into lmp-dev am: 64406ab149 am: fcf9c96fff -s ours am: 95584d203f am: 5d8784c53d am: d86a41ea39 am: 36424c8f5f am: b70bb65f24 am: 626bb148e6 am: 45ce8549c4 am: d27178e362
am: 1bab31a4df

Change-Id: Iebb2829c8c285953a056ac2ecef682ae9485b643
2017-10-19 19:35:22 +00:00
Narayan Kamath 5995e741e5 DO NOT MERGE : Fix build breakage due to 2d516d2d46. am: eeb93c9a64 -s ours am: 951b0dccf0 am: 6e598b9e9d am: 4b187be82f am: b46123a98d -s ours am: 97d2cfab6a am: ea2010e196
am: a4de1f4749

Change-Id: I781301b38e5dd172c10cca10fbae831530440ca1
2017-10-19 19:35:14 +00:00
Narayan Kamath 5bccb55338 DO NOT MERGE : Partially revert change 141d1d836465e8a5a56a5cc1e. am: bfe4b5edb3 -s ours am: e1257bad6e -s ours am: 89b22dff0a am: 4bcb04290d am: 3a46bcc3e0 am: 9800d5d074 -s ours am: c995780ded
am: 10d3ff2004

Change-Id: I6b01dd2fa72261126be178f521c74576e6221f0e
2017-10-19 19:33:02 +00:00
Narayan Kamath 79f474a679 DO NOT MERGE : Fix build breakage due to 2d516d2d46. am: 547c7d9a0b -s ours am: 4732ec6440 -s ours am: 59c7fe7a39 am: 28a7d07705 am: a413ac3c8a am: 685a175cb0 -s ours am: 886eb4351e am: 4f22203279 am: ea729dcae5
am: 369bf9065d

Change-Id: I3d8210eaa9dffa9f94abd9be4ff43b9f6d57d4b8
2017-10-19 19:33:02 +00:00
Narayan Kamath a4de1f4749 DO NOT MERGE : Fix build breakage due to 2d516d2d46. am: eeb93c9a64 -s ours am: 951b0dccf0 am: 6e598b9e9d am: 4b187be82f am: b46123a98d -s ours am: 97d2cfab6a
am: ea2010e196

Change-Id: Id94ff7eba5c127d1c6ac4dcadf09c9e7e4ad6bc1
2017-10-19 19:32:16 +00:00
Narayan Kamath 1bab31a4df Merge "zip_archive: reject files that don't start with an LFH signature." into lmp-dev am: 64406ab149 am: fcf9c96fff -s ours am: 95584d203f am: 5d8784c53d am: d86a41ea39 am: 36424c8f5f am: b70bb65f24 am: 626bb148e6 am: 45ce8549c4
am: d27178e362

Change-Id: I44f0e220da67fc29369ba1a01a89dd10627d5f85
2017-10-19 19:32:04 +00:00
Narayan Kamath 369bf9065d DO NOT MERGE : Fix build breakage due to 2d516d2d46. am: 547c7d9a0b -s ours am: 4732ec6440 -s ours am: 59c7fe7a39 am: 28a7d07705 am: a413ac3c8a am: 685a175cb0 -s ours am: 886eb4351e am: 4f22203279
am: ea729dcae5

Change-Id: I0724657c65dcd16956e52429d0cc646007b07273
2017-10-19 19:30:45 +00:00
Narayan Kamath 10d3ff2004 DO NOT MERGE : Partially revert change 141d1d836465e8a5a56a5cc1e. am: bfe4b5edb3 -s ours am: e1257bad6e -s ours am: 89b22dff0a am: 4bcb04290d am: 3a46bcc3e0 am: 9800d5d074 -s ours
am: c995780ded

Change-Id: I9a51f837432346064b4faf84a634e85e492debcf
2017-10-19 19:30:44 +00:00
Narayan Kamath d27178e362 Merge "zip_archive: reject files that don't start with an LFH signature." into lmp-dev am: 64406ab149 am: fcf9c96fff -s ours am: 95584d203f am: 5d8784c53d am: d86a41ea39 am: 36424c8f5f am: b70bb65f24 am: 626bb148e6
am: 45ce8549c4

Change-Id: I5b6f9a34fe64bbeab02fca9f37d5ddca138ce89a
2017-10-19 19:28:45 +00:00
Narayan Kamath ea729dcae5 DO NOT MERGE : Fix build breakage due to 2d516d2d46. am: 547c7d9a0b -s ours am: 4732ec6440 -s ours am: 59c7fe7a39 am: 28a7d07705 am: a413ac3c8a am: 685a175cb0 -s ours am: 886eb4351e
am: 4f22203279

Change-Id: I08886c30fdabfd59f5a75279e70ec74fc26b2d0b
2017-10-19 19:28:41 +00:00
Narayan Kamath ea2010e196 DO NOT MERGE : Fix build breakage due to 2d516d2d46. am: eeb93c9a64 -s ours am: 951b0dccf0 am: 6e598b9e9d am: 4b187be82f am: b46123a98d -s ours
am: 97d2cfab6a

Change-Id: Ie4c3f2fb73b4b64c9fa70e7cd7c09a5449600691
2017-10-19 19:28:37 +00:00