Commit Graph

3294 Commits

Author SHA1 Message Date
Cole Robinson 1294965aa3 config: Move all the cliconfig data passing into vmmConfig
Setting it in virt-manager is pretty redundant
2013-10-02 14:53:41 -04:00
Cole Robinson 7cb84f5ba5 preferences: Explicitly list system default 2013-10-02 14:47:21 -04:00
Cole Robinson 7b264eac74 create: Don't add graphics for arm 2013-10-02 13:30:18 -04:00
Cole Robinson 83b6dc7ea4 create: Incorporate non-default arch into default guest name 2013-10-02 13:23:49 -04:00
Cole Robinson fc2cef8eb2 create: Sort arch and mach lists, put supports variants at the top 2013-10-02 13:23:49 -04:00
Cole Robinson fa0ee32172 virt-install: Fix multiple invocation of --disk pool=default
Don't use a global counter, just correctly specify a collidelist with
not yet created disk images
2013-10-02 13:20:27 -04:00
Cole Robinson 187ce92621 hostkeymap: Centralize parsing, don't be so noisy
And add /etc/vconsole.conf parsing to close bug 882183
2013-10-02 12:35:59 -04:00
Cole Robinson 7c7f3ad0b2 create: Fix some spacing issues 2013-10-02 12:35:59 -04:00
Cole Robinson d6f96f72d5 create: Add kernel/initrd install option for arm
Basically just show kernel/initrd options for the 'import' install
method on non-x86.
2013-10-02 12:35:59 -04:00
Giuseppe Scrivano 89ba152f00 Fix a problem in the create window
This error is fixed:

Traceback (most recent call last):
  File "src/virt-manager/virtManager/create.py", line 335, in reset_state
    self.set_conn(activeconn, force_validate=True)
  File "src/virt-manager/virtManager/create.py", line 201, in set_conn
    self.set_conn_state()
  File "src/virt-manager/virtManager/create.py", line 594, in set_conn_state
    self.conn.netdev_error, True)
  File "src/virt-manager/virtManager/create.py", line 611, in set_net_warn
    net_warn_icon.set_visible(show_warn)
  File "/usr/lib/python2.7/site-packages/gi/types.py", line 113, in function
    return info.invoke(*args, **kwargs)
TypeError: Argument 1 does not allow None as a value

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-02 15:39:16 +02:00
Cole Robinson 910c3a93ad domain: Fix 'customize install' after snapshot changes 2013-10-02 07:42:24 -04:00
Cole Robinson 71350543d1 create: Desensitive irrelevant install options if arch changes 2013-10-02 07:35:02 -04:00
Cole Robinson c18c94d157 create: A couple mini layout tweaks 2013-10-01 17:55:27 -04:00
Cole Robinson 42389214af create: Add 'machine' option for non-x86 arch 2013-10-01 17:40:44 -04:00
Cole Robinson 0697e5f349 create: More arch/type handling
Hide the 'type' field on non-xen: we shouldn't need to expose
kvm vs. qemu in the UI, just assume if kvm is available we use it.

Hide arch if there's only one available. And hide the whole expander
if we hid both sub fields.
2013-10-01 17:27:58 -04:00
Cole Robinson 67c62e68de create: Move name to last page, arch/type to first page
Moving name to the end allows us to do things like generate a default
name based on the chosen OS type, which we do here. This is bz 736951

Moving arch/type to the front page of the wizard simplifies validation
and will be needed to intuitively install arm guests without a bunch
of hacky workarounds.
2013-10-01 16:53:59 -04:00
Cole Robinson 7009bd2560 createvol: Bunch of misc improvements
- Hide backing store for formats that don't support it
- Hide allocation for qcow2 since it doesn't do anything
- Automatically select the storage format as specified in prefs
2013-10-01 14:50:47 -04:00
Cole Robinson 37350859ce storage: Use qcow2 metadata preallocation if supported 2013-10-01 14:29:58 -04:00
Ying-Shiuan Pan fa8422f278 support: decrease required libvirt version for stream console
According to the changelog of libvirt http://libvirt.org/news.html,
the required version for stream console should be 0.8.6.

Please check the link: http://libvirt.org/news.html, libvirt started
to support virDomainOpenConsole() since "0.8.6: Nov 30 2010". And there
were also many changes related to stream console.

In practical terms, I have tested the change with libvirtd-0.8.8 in
Ubuntu 12.04.2 (x64) and another ARM port libvird-0.8.8. I think changing
to 0.8.6 should be fine because according to the changelog there are
no big changes in libvirt-0.8.7 and libvirt-0.8.8.

Signed-off-by: Ying-Shiuan Pan <yspan@itri.org.tw>
2013-10-01 10:58:44 -04:00
Cole Robinson bdaa0e511a Log object name with XML diff on redefine 2013-10-01 10:21:44 -04:00
Cole Robinson 868fbd9fc9 snapshots: Add screenshot support
Show a screenshot in the 'new snapshot' wizard. If we successfully create
that snapshot, save the screenshot in

~/.cache/virt-manager/$connuri/$vmuuid/snap-screenshot-$snapname.$ext

And show it in the snapshot details overview. We don't do any reaping
on snapshot delete, vm delete, etc, but that could be added later.
2013-10-01 10:14:51 -04:00
Cole Robinson 81c6beca03 Fix a test case after recent testdriver change 2013-10-01 10:14:46 -04:00
Cole Robinson dd823d2d8c cli: Don't log to debug files from the test suite
We shouldn't be doing it anyways, but my recent cache_dir change broke
a bunch of stuff without this.
2013-10-01 10:14:46 -04:00
Cole Robinson 0b58badfc1 Storage debug and scratch files in ~/.cache/virt-manager (bz 693028) 2013-10-01 08:28:15 -04:00
Cole Robinson 7a23ece986 details: Move snapshot switcher at end of toolbar
This was the original suggested layout from way way back when the designers
did mock ups.
2013-09-30 20:59:15 -04:00
Cole Robinson d44f863c2d details: Disable snapshot buttons if conn or guest doesn't have support 2013-09-30 20:33:42 -04:00
Cole Robinson 023953d4ac addhw: Fix cache default again :/ 2013-09-30 20:00:40 -04:00
Cole Robinson 8f1ea67cad Don't lose current selection if redefining net/pool/iface/snapshot 2013-09-30 19:55:21 -04:00
Cole Robinson 707a00c950 storagepool: Fix rename 2013-09-30 19:55:21 -04:00
Cole Robinson 6043a88a0c snapshots: Add some specific UI for external snapshots
We sort them separately in the snapshot list, explicitly mention that
they are 'external', and add a UI field listing the memory/disk
details.

In general mixing internal and external snapshots is a recipe for
confusion and disaster, so I think the best thing to do is at least
acknowledge their presence in the UI but not make any attempt to
predict what will or will not work.
2013-09-30 19:55:21 -04:00
Cole Robinson 6f469d7947 snapshots: List VM status in 'new snapshot' window 2013-09-30 17:40:01 -04:00
Cole Robinson e72944d171 snapshots: Make the list entries a bit prettier 2013-09-30 17:36:38 -04:00
Cole Robinson 45e84d46ec snapshots: Make state type/icon UI match other usage 2013-09-30 17:12:24 -04:00
Cole Robinson 3629dabeb0 snapshots: new: Add default and escape action 2013-09-30 16:37:46 -04:00
Cole Robinson b3e2d26337 snapshots: new: Automatically generate a snapshot name 2013-09-30 16:33:45 -04:00
Cole Robinson 34c502560f storage: Drop unused static function
This allows us to simplify the parameters for find_free_name
2013-09-30 16:22:12 -04:00
Cole Robinson 01577d3d88 snapshots: Desensitize 'finish' if no name entered 2013-09-30 16:22:12 -04:00
Cole Robinson 36837fd3af snapshots: Drop reporting of 'current' snapshot
It's a useless distinction in our UI
2013-09-30 16:22:12 -04:00
Cole Robinson 85ec41c3c9 snapshots: Fix initial UI state when guest has no snapshots 2013-09-30 15:52:37 -04:00
Cole Robinson b1d3987aaa domain: Fix deleting a VM that has snapshots (bz 821518) 2013-09-30 15:38:35 -04:00
Cole Robinson 844a567e7b details: Don't silently drop managed save when renaming VM
Instead just error about it. Until there's an actual libvirt 'rename'
API we can't do much better than that.
2013-09-30 15:38:35 -04:00
Cole Robinson 5f34e7d885 details: Use 'clone' icon for snapshot button
Better than the 'new' icon since people see that one much more and
likely already have an association with it. Better would be a
distinct icon though.
2013-09-30 15:38:34 -04:00
Cole Robinson 98a95b2e2d network: Add install() command, remove function from vmmConnection
This is the pattern used by other virtinst objects
2013-09-30 15:38:34 -04:00
Cole Robinson b9bcc84d35 libvirtobject: Remove no longer needed sanitize_xml helper 2013-09-30 15:38:34 -04:00
Cole Robinson 2b74c46909 snapshots: Pretty up the 'new snapshot' dialog 2013-09-30 15:38:12 -04:00
Cole Robinson ccb96e9e4a VirtualDisk: Add cache modes 'directsync' and 'unsafe' (bz 844907) 2013-09-30 14:30:50 -04:00
Cole Robinson 9de21be907 virt-manager: Drop --experimental-snapshot-ui
We are just sticking with internal snapshots only
2013-09-30 14:30:50 -04:00
Cole Robinson b3c5d123ca testdriver: Add bits for status, transient, managed save, snapshots
No unit tests for any of these, just for UI testing at the moment.
These require some non-upstream libvirt patches, but it doesn't
hurt in the interim while they are reviewed.
2013-09-30 14:30:25 -04:00
Cole Robinson 8f0bfb1ad6 host: Allow renaming a storage pool 2013-09-29 12:28:01 -04:00
Cole Robinson 369a17160a host: Allow renaming virtual networks 2013-09-29 12:14:00 -04:00