199e9593bf
storage: test default_source_name
2019-07-03 19:37:01 -04:00
f21d7e4c27
storage: Add explicit StoragePool.lookup_default_pool
...
Rather than adding an option to build_default_pool which is only
used in one location
2019-07-03 19:37:01 -04:00
67bb8fabdb
storage: Drop redundant validation
...
libvirt catches most of this, and it's not all that useful to
duplicate it ourselves
2019-07-03 19:37:01 -04:00
9d7b20d3de
storage: Add lots of coverage testing and exemptions
2019-07-03 19:37:01 -04:00
f64655a843
storage: Replace pool supports_property with supports_X
...
Makes usage more explicit, and easier to track for coverage testing
2019-07-03 19:37:01 -04:00
b8074b4505
storage: Replace volume supports_property with supports_format
...
Helps to make usage more explicit
2019-07-03 19:37:01 -04:00
657b2bcb26
storage: move supports_volume_creation to virtManager
...
It's the only user
2019-07-03 19:37:01 -04:00
4a0b7f61c8
storage: move pool pretty printing to virtManager
...
It's the only user
2019-07-03 19:37:01 -04:00
51d28f042b
unattended: Don't log user & admin passwords
...
Logging user & admin passwords in the command-line is a security issue,
let's avoid doing so by:
- Not printing the values set by the user when setting up the
install-script config file;
- Removing the values used in the install-scripts, when printing their
content;
'CVE-2019-10183' has been assigned to the virt-install --unattended
admin-password=xxx disclosure issue.
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
2019-07-03 13:25:26 -04:00
58c6876450
unattended: Read the passwords from a file
...
Let's not expose the user/root password in the CLI and, instead, let's
rely on a file passed by the admin and read the password from there.
'CVE-2019-10183' has been assigned to the virt-install --unattended
admin-password=xxx disclosure issue.
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
2019-07-03 13:25:26 -04:00
5312a9611b
virt-install: Revive --wait 0 as alias for --noautoconsole
...
This was the behavior prior to last release, and we received
a bug report about it. Revive it, but warn about the recommended way
to do it
https://bugzilla.redhat.com/show_bug.cgi?id=1724287
2019-07-03 13:12:19 -04:00
f3e7b9a8f0
cli: Finish off test coverage
2019-07-03 13:12:10 -04:00
3a1f10c6c5
cli: Remove warnings about spice and GL
...
libvirt catches the missing support here, and the warnings are not
accurate because these values can work with SDL and EGL headless.
2019-07-02 14:58:44 -04:00
afdb25e158
cli: Add more 'no cover' annotations
2019-07-02 14:58:44 -04:00
1277f5ebb1
clitest: Add non-testsuite virt-install stub
...
For hitting some logging code paths that are disabled for the
testsuite
2019-07-02 12:55:53 -04:00
5824cccf23
tests: test_urls: Add a fedora ftp:// example
2019-07-01 19:32:57 -04:00
6a1b0254bf
diskbackend: Handle unexpected error from test_urls
2019-07-01 18:53:16 -04:00
2df7a6bab4
tests: test_urls: Actually test centos7 aarch64
2019-06-25 10:15:42 -04:00
2c49c3887c
tests: test_urls: Better error report overwriting
2019-06-24 19:39:07 -04:00
267f226134
xmleditor: Fix the gtksource version checking
...
Previous commit was incomplete
2019-06-18 10:50:49 -04:00
e4b4834a58
uitests: newvm: More attempts to make the PXE test less flakey
2019-06-18 10:01:26 -04:00
cf04920211
INSTALL.md: We enforce python >= 3.4, not >= 3.3
2019-06-18 09:55:08 -04:00
876c0c014d
INSTALL.md: Document dep on gtksourceview
...
https://bugzilla.redhat.com/show_bug.cgi?id=1721341
2019-06-18 09:55:01 -04:00
033e97021e
xmleditor: Handle gtksourceview3 as well as gtksourceview4
...
API differences don't seem to affect our usage
2019-06-18 09:54:58 -04:00
b6563b90e5
cli: Add --numatune options memnode[0-9]*.cellid, memnode[0-9]*.mode, memnode[0-9]*.nodeset
...
XML Mapping:
<numatune>
...
<memnode cellid="X" mode="X" nodeset="X"/>
...
</numatune>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-06-17 17:41:25 -04:00
eda3c22458
guest: Add memory balloon by default
...
libvirt already does this for pretty much all QEMU guests, but
ARM virt guests for example don't get a memory balloon by default
at that level of the stack.
virt-manager is in a good position to make sure defaults are
consistent across architectures, and there's no downside in having
the device in the XML passed to libvirt anyway.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
2019-06-17 13:52:07 -04:00
fb81adea7e
cli: Add special treatment for --memballoon none
...
We want to start adding a memory balloon automatically to
guests, but we also need to make sure that it can be explicitly
disabled at the user's request.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
2019-06-17 13:50:11 -04:00
72fc6781c8
osdict: Add supports_virtioballoon()
...
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
2019-06-17 13:50:11 -04:00
1502417566
tests: Add a couple of virt-xml memballoon tests
...
We're going to slightly change how the device is handled in
a minute, and we want to make sure we don't break existing
functionality while doing so.
Note that the existing singleton-config-* test cases already
provide coverage for both enabling and disabling the memory
balloon in virt-install.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
2019-06-17 13:50:11 -04:00
8c5e0797e5
tests: dist: Drop forbidden import test
...
It's broken, and in practice it has not turned out to be an issue
preventing gdk or gtk from leaking into virtinst
2019-06-17 13:32:55 -04:00
c92693a276
setup: Remove dep on importing virtinst
...
Import BuildConfig directly from the source file using import hackery.
buildconfig.py is independent of virtinst code so it already does
the right thing. Add some checking to make sure this doesn't regress
in the future.
Drop the now unneeded RPM deps.
2019-06-17 13:18:50 -04:00
d097e66324
spec: add build dependencies that are now required for build
...
Recent changes refactored a code in a whey that running setup.py
requires more python modules and we need to reflect that in our
spec file in order to build RPMs.
We should not need all of these as they are not used but that will
require a lot of code changes. We should eventually fix it.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2019-06-17 12:08:34 +02:00
09abca4f76
Prep for release 2.2.0
2019-06-17 01:31:40 -04:00
5ef458a428
setup: Undo previous file search changes
...
They were totally busted
2019-06-17 01:27:08 -04:00
fab6b9ef78
ui: Bump gtk3 dep to our app wide 3.22
2019-06-17 01:14:58 -04:00
728fd7cf7b
cli: Don't generate path with 'None' if --name not specified
...
Use 'disk' instead. It will take some work to unwind this so
that the path isn't generated until a name is truly specified
2019-06-17 01:04:58 -04:00
6215c86fa2
virt-install: Warn about --location $DIR needing extra args
...
https://bugzilla.redhat.com/show_bug.cgi?id=1677019
2019-06-17 00:12:32 -04:00
e9308bde1f
man: virt-install: Clarify that --noautoconsole might want --wait
...
There's been some confusion about why the VM doesn not reboot after
--noautoconsole was passed. Mention the '--wait' fix in the man
page
https://bugzilla.redhat.com/show_bug.cgi?id=1663430
2019-06-17 00:12:32 -04:00
edfb749f91
man: virt-install: Big update
...
- Document --install
- Document --unattended
- Modernize EXAMPLES section
- Deprecate --livecd
- Tweak the intro describing VM defaults
2019-06-17 00:12:32 -04:00
16362671e9
virt-install: Add --install no_install=yes|no
...
This just formalizes the behavior of things like --import and
--livecd
2019-06-17 00:12:32 -04:00
230545bdb3
virt-install: Make bare '--wait' mean 'wait indefinitely'
2019-06-17 00:12:32 -04:00
49112dbb70
man: virt-xml: Update with all latest options
2019-06-17 00:12:32 -04:00
3062b5ce08
virtManager: Move a lot of misc files to lib/
2019-06-17 00:12:32 -04:00
fa3f25dc1c
virtManager: rename connect.py -> createconn.py
...
connect.py is too ambiguous, and this naming is more consistent
2019-06-17 00:12:32 -04:00
121cf5528d
virtManager: rename create.py -> createvm.py
...
To be more consistent with other create wizard naming
2019-06-17 00:12:32 -04:00
b15510f3fd
virtManager: rename storagelist to hoststorage
...
To match hostnets naming, and to be a bit more clear
2019-06-17 00:12:32 -04:00
16a608c37b
virtManager: move vmwindow components to virtManager/details
2019-06-17 00:12:32 -04:00
9be836102e
virtManager: move device UI files to virtManager/device/
2019-06-17 00:12:32 -04:00
a6c07fbfdc
virtManager: Move object .py files to virtManager/object/
2019-06-17 00:12:32 -04:00
e9439a8ef1
virtinst: Move multiple installer .py files to virtinst/install/
2019-06-17 00:12:32 -04:00
Cole Robinson