199e9593bf
storage: test default_source_name
2019-07-03 19:37:01 -04:00
9d7b20d3de
storage: Add lots of coverage testing and exemptions
2019-07-03 19:37:01 -04:00
f64655a843
storage: Replace pool supports_property with supports_X
...
Makes usage more explicit, and easier to track for coverage testing
2019-07-03 19:37:01 -04:00
58c6876450
unattended: Read the passwords from a file
...
Let's not expose the user/root password in the CLI and, instead, let's
rely on a file passed by the admin and read the password from there.
'CVE-2019-10183' has been assigned to the virt-install --unattended
admin-password=xxx disclosure issue.
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
2019-07-03 13:25:26 -04:00
5312a9611b
virt-install: Revive --wait 0 as alias for --noautoconsole
...
This was the behavior prior to last release, and we received
a bug report about it. Revive it, but warn about the recommended way
to do it
https://bugzilla.redhat.com/show_bug.cgi?id=1724287
2019-07-03 13:12:19 -04:00
f3e7b9a8f0
cli: Finish off test coverage
2019-07-03 13:12:10 -04:00
3a1f10c6c5
cli: Remove warnings about spice and GL
...
libvirt catches the missing support here, and the warnings are not
accurate because these values can work with SDL and EGL headless.
2019-07-02 14:58:44 -04:00
1277f5ebb1
clitest: Add non-testsuite virt-install stub
...
For hitting some logging code paths that are disabled for the
testsuite
2019-07-02 12:55:53 -04:00
5824cccf23
tests: test_urls: Add a fedora ftp:// example
2019-07-01 19:32:57 -04:00
2df7a6bab4
tests: test_urls: Actually test centos7 aarch64
2019-06-25 10:15:42 -04:00
2c49c3887c
tests: test_urls: Better error report overwriting
2019-06-24 19:39:07 -04:00
e4b4834a58
uitests: newvm: More attempts to make the PXE test less flakey
2019-06-18 10:01:26 -04:00
b6563b90e5
cli: Add --numatune options memnode[0-9]*.cellid, memnode[0-9]*.mode, memnode[0-9]*.nodeset
...
XML Mapping:
<numatune>
...
<memnode cellid="X" mode="X" nodeset="X"/>
...
</numatune>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-06-17 17:41:25 -04:00
eda3c22458
guest: Add memory balloon by default
...
libvirt already does this for pretty much all QEMU guests, but
ARM virt guests for example don't get a memory balloon by default
at that level of the stack.
virt-manager is in a good position to make sure defaults are
consistent across architectures, and there's no downside in having
the device in the XML passed to libvirt anyway.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
2019-06-17 13:52:07 -04:00
1502417566
tests: Add a couple of virt-xml memballoon tests
...
We're going to slightly change how the device is handled in
a minute, and we want to make sure we don't break existing
functionality while doing so.
Note that the existing singleton-config-* test cases already
provide coverage for both enabling and disabling the memory
balloon in virt-install.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
2019-06-17 13:50:11 -04:00
8c5e0797e5
tests: dist: Drop forbidden import test
...
It's broken, and in practice it has not turned out to be an issue
preventing gdk or gtk from leaking into virtinst
2019-06-17 13:32:55 -04:00
728fd7cf7b
cli: Don't generate path with 'None' if --name not specified
...
Use 'disk' instead. It will take some work to unwind this so
that the path isn't generated until a name is truly specified
2019-06-17 01:04:58 -04:00
6215c86fa2
virt-install: Warn about --location $DIR needing extra args
...
https://bugzilla.redhat.com/show_bug.cgi?id=1677019
2019-06-17 00:12:32 -04:00
16362671e9
virt-install: Add --install no_install=yes|no
...
This just formalizes the behavior of things like --import and
--livecd
2019-06-17 00:12:32 -04:00
230545bdb3
virt-install: Make bare '--wait' mean 'wait indefinitely'
2019-06-17 00:12:32 -04:00
e9439a8ef1
virtinst: Move multiple installer .py files to virtinst/install/
2019-06-17 00:12:32 -04:00
f107e39989
Switch to more traditional logging structure
...
Init a shared log instance in virtinst/logger.py, and use that
throughout the code base, so we aren't calling directly into
'logging'. This helps protect our logging output from being
cluttered with other library output, as happens with some
'requests' usage
2019-06-17 00:12:31 -04:00
2c03ea5c92
hostnets: Remove SR-IOV info listing
...
This is fairly advanced stuff and it should be fine to get this
info from the XML editor page
2019-06-16 23:48:51 -04:00
59873f3876
hostnets: Remove QoS viewing/editing
...
This is fairly niche, and can be reviewed or edited with the XML
editor
2019-06-16 20:25:42 -04:00
fe0e36499b
uitests: prefs: Another attempt to fix XML editor flakiness
2019-06-16 19:33:45 -04:00
9c8e879ff0
virt-install: Add --boot firmware=
2019-06-16 17:15:08 -04:00
53f075ab76
virt-xml: Warn if libvirt discards our defined changes
...
This can happen if we try to remove a default device, like
a ps2 mouse on x86, but it can happen for many other reasons as well
https://bugzilla.redhat.com/show_bug.cgi?id=1405263
2019-06-16 17:08:59 -04:00
52c6094c65
virt-xml: Denest and comment code flow a bit
...
Add lots of early exits to remove implicit fall through
behavior that I find hard to follow
2019-06-16 16:47:05 -04:00
0221471e4f
virt-xml: If no XML diff is generated, explicitly warn
2019-06-16 16:37:48 -04:00
4973564e65
virt-clone: add --skip-copy option
...
This is the flip side to the --force-copy option. We already
have the plumbing internally
https://bugzilla.redhat.com/show_bug.cgi?id=1564865
2019-06-16 14:41:54 -04:00
88f52f956e
urldetect: Don't use dict ordering for URL detection
...
ALLSTORES was implicitly using dict() ordering. This exposed
a bug in our code on debian ci which was nice, but it should
be deterministic. Hardcode the ordering
2019-06-16 14:41:54 -04:00
df82856021
tests: Finish cloner.py coverage
2019-06-16 14:37:56 -04:00
dcd0b2ac81
cloner: Fill out test coverage
2019-06-15 16:15:01 -04:00
d6b6397ce0
virtManager: xmleditor: warn when switching to XML tab
...
If there are unapplied changes in the UI warn user when they tries to
switch to XML editor.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2019-06-15 15:05:28 +02:00
524002da02
virt-xml: Abide domain name for --build-xml
...
https://bugzilla.redhat.com/show_bug.cgi?id=1648939
2019-06-14 21:37:50 -04:00
d40975c493
guest: Add back spice virtio-serial for windows
...
This was removed in v2.0.0, but we've had some complains since then
https://bugzilla.redhat.com/show_bug.cgi?id=1660123
2019-06-14 20:51:43 -04:00
c52e220504
devices: disk: Handle pool=iscsi-direct volumes
...
I don't have a working setup for this so I'm not positive
it actually works, but this roughly matches what I see in
libvirt test suite data and docs
https://bugzilla.redhat.com/show_bug.cgi?id=1658511
2019-06-14 20:35:41 -04:00
b9981b4623
createpool: Drop disk and netfs pool source listing
...
Both of these are awkward to use and IMO not really useful.
2019-06-14 17:16:48 -04:00
ab7b3c189f
Move virtcli/cliconfig.py to virtinst/buildconfig.py
...
There's really no reason for the split, just contain it all
within virtinst for simplicity
2019-06-14 17:12:19 -04:00
ef972cf2ea
virtinst: support: add full code coverage testing
2019-06-14 14:00:13 -04:00
54a28485df
tests: Use assertRaises more
2019-06-14 13:04:56 -04:00
bd7d213cf8
virt-xml: Add more test coverage
2019-06-14 12:37:35 -04:00
fbe388b26a
virt-install: Warn if mem less than OS recommended
...
And if mem is abnormally low, like it appears user tried to specify
GiB not MiB
2019-06-14 11:24:10 -04:00
34f42cc673
installer: Make test suite override paths a bit more descriptive
...
Have them incorporate the basename of the path we are replacing.
This gives some validation that we are manipulating the correct files
2019-06-13 21:53:41 -04:00
aafbca9e75
tests: Fix running on non-latest osinfo-db
2019-06-13 21:27:59 -04:00
17ac0d017c
virt-install: Drop --os-variant suboption parsing
...
Not sure I want to go down that route if we can avoid it. Instead
just fold the full_id support into the existing option handling.
Streamline the OSVariantData usage throughout the cli tools
2019-06-13 21:25:05 -04:00
21723706f5
virt-install: Add --install OSNAME
...
Replace the unreleased --os-variant OSNAME,install=location with just
--install OSNAME
Unwind the --unattended dependency on upfront --os-variant while
we are at it, since they are all intertwined. Now we can just do:
virt-install --install OSNAME
and
virt-install --install OSNAME --unattended
2019-06-13 20:26:26 -04:00
3b396e8321
virt-install: Split out --wait handling into a helper class
...
And add much more clitest coverage
2019-06-13 16:02:58 -04:00
8234b55fe8
tests: clitest: Fill in much more virt-install coverage
2019-06-13 16:02:52 -04:00
7ef20e26b0
Revert "guest: Don't hardcode vcpus = 1"
...
This reverts commit 66fe00ddee
2019-06-13 14:40:06 -04:00
Cole Robinson