f21d7e4c27
storage: Add explicit StoragePool.lookup_default_pool
...
Rather than adding an option to build_default_pool which is only
used in one location
2019-07-03 19:37:01 -04:00
f64655a843
storage: Replace pool supports_property with supports_X
...
Makes usage more explicit, and easier to track for coverage testing
2019-07-03 19:37:01 -04:00
b8074b4505
storage: Replace volume supports_property with supports_format
...
Helps to make usage more explicit
2019-07-03 19:37:01 -04:00
657b2bcb26
storage: move supports_volume_creation to virtManager
...
It's the only user
2019-07-03 19:37:01 -04:00
4a0b7f61c8
storage: move pool pretty printing to virtManager
...
It's the only user
2019-07-03 19:37:01 -04:00
267f226134
xmleditor: Fix the gtksource version checking
...
Previous commit was incomplete
2019-06-18 10:50:49 -04:00
033e97021e
xmleditor: Handle gtksourceview3 as well as gtksourceview4
...
API differences don't seem to affect our usage
2019-06-18 09:54:58 -04:00
3062b5ce08
virtManager: Move a lot of misc files to lib/
2019-06-17 00:12:32 -04:00
fa3f25dc1c
virtManager: rename connect.py -> createconn.py
...
connect.py is too ambiguous, and this naming is more consistent
2019-06-17 00:12:32 -04:00
121cf5528d
virtManager: rename create.py -> createvm.py
...
To be more consistent with other create wizard naming
2019-06-17 00:12:32 -04:00
b15510f3fd
virtManager: rename storagelist to hoststorage
...
To match hostnets naming, and to be a bit more clear
2019-06-17 00:12:32 -04:00
16a608c37b
virtManager: move vmwindow components to virtManager/details
2019-06-17 00:12:32 -04:00
9be836102e
virtManager: move device UI files to virtManager/device/
2019-06-17 00:12:32 -04:00
a6c07fbfdc
virtManager: Move object .py files to virtManager/object/
2019-06-17 00:12:32 -04:00
f107e39989
Switch to more traditional logging structure
...
Init a shared log instance in virtinst/logger.py, and use that
throughout the code base, so we aren't calling directly into
'logging'. This helps protect our logging output from being
cluttered with other library output, as happens with some
'requests' usage
2019-06-17 00:12:31 -04:00
2c03ea5c92
hostnets: Remove SR-IOV info listing
...
This is fairly advanced stuff and it should be fine to get this
info from the XML editor page
2019-06-16 23:48:51 -04:00
59873f3876
hostnets: Remove QoS viewing/editing
...
This is fairly niche, and can be reviewed or edited with the XML
editor
2019-06-16 20:25:42 -04:00
e25318e037
console: Fix graphics_type_pretty invocation
2019-06-16 20:19:26 -04:00
337e84083f
storagepool: Force refresh XML on refresh signal
...
The XML will report things like updated capacity information,
which we want to mirror in the UI
https://bugzilla.redhat.com/show_bug.cgi?id=1447962
2019-06-16 19:43:20 -04:00
a2a09a49c7
clone: Fix syntax error
2019-06-16 19:23:27 -04:00
b513388979
domain: Remove internal 'cloning' marker
...
qemu nowadays should reject the common cases here with its default
image locking. Our impl wasn't very good anyways so let's just leave
it up to the lower layers
2019-06-16 17:32:41 -04:00
d6b6397ce0
virtManager: xmleditor: warn when switching to XML tab
...
If there are unapplied changes in the UI warn user when they tries to
switch to XML editor.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2019-06-15 15:05:28 +02:00
5eb5913f34
domain: Ensure nvram path before trying to access it
...
https://bugzilla.redhat.com/show_bug.cgi?id=1667025
2019-06-14 21:50:08 -04:00
d61f9d9995
details: Check for mac conflict in customize wizard
...
https://bugzilla.redhat.com/show_bug.cgi?id=1660467
2019-06-14 21:11:37 -04:00
147a3b4790
preferences: Disable systray option if we know it won't work
...
Basically on wayland, if appindicator isn't available
https://bugzilla.redhat.com/show_bug.cgi?id=1666597
2019-06-14 20:05:09 -04:00
aabde5bbe6
domain: Remove pre-startup USB collision check
...
Libvirt nowadays will throw an explicit warning about this
exact situation. It doesn't guide people to virt-manager UI, but
then again it should be obscure enough that it doesn't warrant this
special corner case code to inform the user
2019-06-14 20:04:18 -04:00
b9981b4623
createpool: Drop disk and netfs pool source listing
...
Both of these are awkward to use and IMO not really useful.
2019-06-14 17:16:48 -04:00
ab7b3c189f
Move virtcli/cliconfig.py to virtinst/buildconfig.py
...
There's really no reason for the split, just contain it all
within virtinst for simplicity
2019-06-14 17:12:19 -04:00
d9729855ee
guest: break out disable_hyperv_for_uefi
...
Having this at set_uefi time complicates the domain XML building
machinery, where we don't want things to have osinfo access.
Rearrange it so that editing cases call this explicitly, and
the XML builder just deals with it at the set_defaults time
2019-06-13 17:55:37 -04:00
19bcec651c
virt-install: Push validation down into the installer
...
It's hard to validate whether something like --extra-args or
--initrd-inject is supported based on the command line arguments. It's
easier to let the installer.py figure it out because it's the
authoritative source
2019-06-13 14:00:04 -04:00
2266b650a5
preferences: Disable XML editing by default
...
This adds a field in gsettings and preferences UI to enable
XML editing. It's off by default. The XML tab page is still visible,
but the textview is not editable, and there's a warning at the top:
XML editing is disabled in 'Preferences'.
Only enable it if you know what you are doing.
When the setting is enabled, the warning goes away and the textview
is editable. This puts a roadblock up for people that don't know what
they are doing, but still advertises the feature and keeps the
UI surface difference fairly small between on/off states.
2019-06-13 07:17:34 -04:00
a5f4033493
details: add xmleditor UI
...
Handling this is a bit different from other bits, because:
1) the <device> editing paradigm is unique. We need to replace the
device in line in the XML which is a new operation
2) the New VM customize pattern is tricky and needs lots of
special handling
2019-06-13 07:15:46 -04:00
df80852952
addhardware: add xmleditor UI
2019-06-13 07:15:46 -04:00
0937c1e54b
createvol: add xmleditor UI
2019-06-13 07:15:46 -04:00
68b3cb16e5
createpool: add xmleditor UI
2019-06-13 07:15:46 -04:00
50d13d8c12
storagelist: add xmleditor UI
2019-06-13 07:15:46 -04:00
7d9d8d9237
createnet: add xmleditor UI
2019-06-13 07:15:46 -04:00
5f4510b4df
hostnets: add xmleditor UI
2019-06-13 07:13:43 -04:00
18af72212b
xmleditor: Add the shared code
...
The XML editor ui is a two tabbed notebook, one 'Details' tab
and one 'XML' tab. The latter has a gtksourceview and allows editing
the raw libvirt XML for whatever the selected object is.
API users will programmatically insert the xmleditor notebook into
their UI, with the existing UI under the details tab.
2019-06-13 07:13:43 -04:00
ecb60c3062
Drop use of logging.info
...
Just use logging.debug in these random places
2019-06-11 17:55:09 -04:00
078348fbbf
create: move generate_name to Guest
...
This will be used by virt-install.
Tweak the logic a bit to not have 'generic' in the name
2019-06-11 17:54:45 -04:00
387614c641
generatename: Move libvirt collision handling to callers
...
Make every caller pass an explicit cb that handles libvirt
collision processing. Makes it easier to see exactly what is going
on at the call impls
2019-06-11 17:54:45 -04:00
47a6f3a6d5
storage: Handle guest collision checking
...
This pattern is already used in two places. Formalize and centralize
it
2019-06-11 17:54:45 -04:00
58dfe05344
virtManager: Remove some unnecessary generatename collidelist usage
...
The libvirt callbacks will handle this for us already
2019-06-11 17:54:45 -04:00
6e6a0b8a6a
connection: Use shared default pool lookup logic
...
It wasn't abiding a different pool name pointing to our default
path
2019-06-11 17:54:45 -04:00
e27202d178
createpool: Use StoragePool.default_target_path
...
Indirectly, rather than the less useful get_default_dir
2019-06-11 17:54:45 -04:00
abb4719cee
addstorage: Drop non-storagepool fallback code
...
This isn't tested, and the usecase will error later anyways when
we attempt to create storage.
2019-06-11 17:54:45 -04:00
b5a664bd1b
virtinst: move UI only functions into virtManager
...
These throw off code coverage testing. They are mostly:
* pretty* device helpers
* network + snapshot validation + creation routines
2019-06-09 18:33:45 -04:00
388850f04e
virtinst: Rename util to xmlutil
...
The only functions left in there are largely for xml handling, so
make it explicit
2019-06-07 18:21:24 -04:00
6677f677da
util: move generate_name to generatename.py
2019-06-07 18:16:53 -04:00
Cole Robinson