openkylin
/
virt-manager
mirror of https://gitee.com/openkylin/virt-manager.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity
6,079 Commits 7 Branches 6 Tags 91 MiB
Commit Graph

6079 Commits

Author SHA1 Message Date
Radostin Stoyanov 19b3d2ac66 progress: Resolve E714 
E714: test for object identity should be ‘is not’

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov 6d125cca72 progress: Resolve E265 
E265: block comment should start with ‘# ‘

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov 3468a2ec1f progress: Resolve E722 
E722: do not use bare except, specify exception instead

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov c3453422f2 progress: Resolve E261 
E261: at least two spaces before inline comment

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov cd1a46c2ae progress: Resolve E701 
E701: multiple statements on one line (colon)

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov 9a472f506d progress: Resolve E221 
E221: multiple spaces before operator

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov ed98a29dda progress: Resolve E302 
E302: expected 2 blank lines

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov b7c7c27f7c progress: Resolve W0201 
W0201: Attribute %r defined outside __init__

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Radostin Stoyanov 5b1f6ad2b8 pylint: Don't exclude progress.py 
Currently progress.py file was excluded from pylint/pycodestyle check
because the code was straight from python-urlgrabber and it was not
PEP8 compliant. The following patched resolve the code style issues.

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-11-12 08:34:55 -05:00
Martin Kletzander 9308bae310 util: Fix typo vpcu -> vcpu 
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
 2018-10-22 15:05:30 +01:00
Cole Robinson 25b8873340 urldetect: Don't overload suse_content variable 
Use an explicit check_for_suse_content variable rather than
stuffing -1 into suse_content
 2018-10-18 17:16:14 -04:00
Cole Robinson 49f469a034 test_urls: Always check for distro value 2018-10-18 13:43:12 -04:00
Cole Robinson cd122b9387 test_urls: Drop dead code 
This is solved by the "testsuite-fedora-rawhide" hack
 2018-10-18 13:36:16 -04:00
Cole Robinson fe9aa7085b test_urls: Add kernelregex= option 
For verifying detected kernel paths. Add a few basic examples. I
will use this in my local iso test suite for checking debian
iso vs http-iso case
 2018-10-18 13:21:44 -04:00
Johannes Tiefenbacher b8aff28087 virtinst: quickfix ubuntu net-preseed insert cdrom error 
the proper kernel/initrd pair for booting from an http server is found in install/netboot/... on a mounted ubuntu iso.
this last worked in v1.4.2

Discussion: https://github.com/virt-manager/virt-manager/pull/34

(crobinso: add the fetcher.is_iso handling and add a comment)
 2018-10-18 13:21:41 -04:00
Cole Robinson 943f1d4bc2 Prep for release 2.0.0 2018-10-15 08:34:18 -04:00
Cole Robinson e127d5e269 tests: inject: use qemu system, not session 
system will give us vol upload coverage
 2018-10-14 19:06:06 -04:00
Cole Robinson 1b24ce455c tests: urls: Update for latest osinfo data 2018-10-14 17:09:48 -04:00
Cole Robinson 369cf6774b guest: Don't add spicevmc channel if virtio not supported 
Not that big of a deal for linux guests, but will add ?
devices on windows
 2018-10-14 12:29:33 -04:00
Cole Robinson 9be5fec593 tests: inject: fix some pylint 2018-10-13 17:54:07 -04:00
Cole Robinson b051b6c95d cpu: Have host-copy use domcaps if qemu is new enough (bz 1637767) 
capabilities is known problematic. Use domcaps if libvirt+qemu
reports working host-model

https://bugzilla.redhat.com/show_bug.cgi?id=1637767
 2018-10-13 17:48:25 -04:00
Cole Robinson 535e34481d libvirtobject: Add is_X object type helpers 2018-10-13 17:23:18 -04:00
Cole Robinson d39b7d1079 details: Fix launching wrong window for duplicate VM name (bz 1630220) 
https://bugzilla.redhat.com/show_bug.cgi?id=1630220
 2018-10-13 17:16:21 -04:00
Cole Robinson 6e00d816c7 preferences: Fix some mnemonics (bz 1630217) 
https://bugzilla.redhat.com/show_bug.cgi?id=1630217
 2018-10-13 17:05:21 -04:00
Cole Robinson 2ba48539ea tests: Regenerate with osinfo-db git 2018-10-13 16:33:37 -04:00
Cole Robinson f102d2a256 tests: inject: use virt-install, not direct API 
Simplifies the code and gives us actual command line coverage,
but requires a small hack to work correctly for modern
centos/fedora test cases, inst.repo from --location takes
precedence over our kickstart URL
 2018-10-13 16:31:04 -04:00
Cole Robinson e212ce84e6 installer: extraargs -> extra_args 
Better matches what's on the command line
 2018-10-13 16:29:32 -04:00
Cole Robinson 4ae24802d7 installer: Fix --initrd-inject 2018-10-13 15:51:38 -04:00
Cole Robinson cec5fdeabe addhardware: Fix some pylint 2018-10-13 15:34:09 -04:00
Cole Robinson 30448f3c81 tests: uitests: Add click() wrapper 2018-10-13 15:33:44 -04:00
Cole Robinson edab908f42 guest: Use q35 chipset by default for new qemu + supported OS 
There's been various discussions about changing the x86 default
from 'pc' to 'q35' over the years, but it's unlikely to happen
at the qemu or libvirt level for compatibility reasons. So
let's start using it for new enough OS that support it.
 2018-10-13 14:58:57 -04:00
Cole Robinson a00152d72a manager: fix some --test-leak-debug issues 2018-10-13 14:27:10 -04:00
Cole Robinson 0cbb420347 virt-install: Limit --os-variant warning to kvm+x86 
As that's really all that libosinfo defaults presently matter for
 2018-10-13 12:55:34 -04:00
Cole Robinson 570e6bbb29 tests: add osinfo net fallback test 
using openbsd4.9 with its pcnet recommendation
 2018-10-13 12:40:22 -04:00
Cole Robinson 452f5286cd addhardware: Don't show pci-bridge devices 
These aren't assignable
 2018-10-13 12:38:06 -04:00
Cole Robinson c23a0d4c96 nodedev: add is_linux_root_hub helper 
Move the check out of connection.py, and simplify the addhardware
code
 2018-10-13 12:18:50 -04:00
Cole Robinson 467c524684 tests: Add show_nographics_warnings coverage 2018-10-13 11:50:49 -04:00
Cole Robinson 41d0f8fdf1 installer: Order install CDROM before any manual CDROMs 
This is important for the virtio-win case: --cdrom media should
always be ordered first, so it's the boot preference.

https://www.redhat.com/archives/virt-tools-list/2018-September/msg00048.html
 2018-10-13 10:44:09 -04:00
Cole Robinson 2e6093d6b6 create: Show inserted CDROM media in customize 
This makes it easier for people to change install media afterwards
if they want:

https://bugzilla.redhat.com/show_bug.cgi?id=1508377

But also this makes it more clear that if users want to use virtio-win,
they need to add an additional CDROM and not try to reuse the install
CDROM device
 2018-10-13 10:17:50 -04:00
Cole Robinson eaf285f772 tests: xmlconfig: Drop a lot of redundant config 2018-10-13 10:11:43 -04:00
Cole Robinson 2482e57a15 create: Fix customize boot page 
Installer reworks dropped the guest.autostart flag, need to add
it back. Add Uitest for it
 2018-10-13 09:46:06 -04:00
Cole Robinson 11d1cbdf06 installer: DistroInstaller -> InstallerTreeMedia 
Now we have only one Installer class, and callers don't need to
worry about choosing a particular class type depending on their
needs, just pass cdrom vs. location to the installer init and
we figure out everything behind the scenes.

Besides simplifying the callers this makes the control flow a
lot easier to follow whether looking at InstallerTreeMedia or
Installer classes
 2018-10-13 09:42:11 -04:00
Cole Robinson 6fb81aeb65 cli: Another searchdata.user fix 2018-10-12 18:34:42 -04:00
Cole Robinson e4e924ea50 tests: Add libosinfo iso detection test 
With another fake iso, based on stripped down centos 6.5 boot iso.
Reason we do centos 6.5 is that everything newer also compares
on volume size, and we don't want to store a huge iso in git.
 2018-10-12 17:15:58 -04:00
Cole Robinson 8ff2043f2a urldetect: Drop boot.iso fetching 
Since this was only used for the --cdrom $treeurl case, this is
no longer used
 2018-10-12 15:54:39 -04:00
Cole Robinson b90b8e3c07 distroinstaller: Remove --cdrom $URL boot.iso fetching 
And instead treat any URL passed to --cdrom as a file to
access directly over http. Rationale for dropping this is
laid out here:

https://www.redhat.com/archives/virt-tools-list/2018-May/msg00011.html
 2018-10-12 15:54:36 -04:00
Cole Robinson 4f320c2b98 distroinstaller: Remove implied cdrom installs 
This is an obscure feature that I'm skeptical anyone is relying on,
and has weirdly subtle semantics that are hard to test.
 2018-10-12 15:33:05 -04:00
Cole Robinson 286dbf6d51 installer: Fold PXEInstaller into base Installer class 
PXEInstaller is really just 'boot off bootdev=network' which is
easy enough to model without a separate class
 2018-10-12 15:15:20 -04:00
Cole Robinson 4096800f71 Remove interface UI 
Discussed here: https://www.redhat.com/archives/virt-tools-list/2018-October/msg00032.html
 2018-10-12 14:38:05 -04:00
Cole Robinson 23d15d7ad1 uitests: Rename console->livetest.py 
It has more than console tests. let's use it as the destination for
all live VM testing
 2018-10-12 13:49:53 -04:00