Commit Graph

3762 Commits

Author SHA1 Message Date
Chen Hanxiao 1d3980015a host: unselect_all members before clear model
Interface_selected is being triggered by model.clear() in
populate_interfaces. It usually calls interface_selected
on every interface after the current selected row.

So the gtk code is probably removing the first
row over and over, and when it removes the
current selection (the interface we are deleting),
it selects the next row in line.
It will raise a KeyError.

This patch will fix this issue.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-14 09:04:52 +08:00
Giuseppe Scrivano 81696a5144 virtinst: use libvirt getCPUModelNames when available
Read the list of CPU models trough getCPUModelNames instead of
accessing directly the file cpu_map.xml.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1060316

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-13 19:00:54 +01:00
Giuseppe Scrivano 6c2645f0d2 virtinst: drop parsing of cpu features
As for the previous patch, this information is not used anywhere and
this information should be retrieved using the libvirt baselineCPU
API.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-13 16:50:40 +01:00
Giuseppe Scrivano 143a689592 virtinst: drop cpu_map parsing of arch features
This information is not used anywhere and there is no way to read
it directly from libvirt without parsing the cpu_map.xml file.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-13 16:50:37 +01:00
Cole Robinson 4f7f1adc47 addhw: Desensitive the 'create storage' UI for cdrom/floppy
Since we already fail in that case anyways, it makes things a bit clearer.
2014-03-12 17:22:48 -04:00
Cole Robinson abb3920ac6 addhw: Fix adding empty cdrom/floppy drive 2014-03-12 16:54:14 -04:00
Cole Robinson d2ad2bcf94 create: Clarify some bits in change_caps 2014-03-12 11:51:15 -04:00
Cole Robinson 1230ab57a9 create: Remove self.caps, it's redundant 2014-03-12 11:42:50 -04:00
Cole Robinson 1cf8b62990 create: Invalidate cached caps across similar connections (bz 1075444) 2014-03-12 11:37:36 -04:00
Chen Hanxiao e9519a2f9a domain: fix a typo
s/checkig/checking

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-12 15:36:59 +08:00
Kjö Hansi Glaz 66d146acee Add a gsetting key to disable keyboard grabbing
Add a gsetting key to disable keyboard grabbing that works the same way
as spicy when unchecking "Options" > "Grab keyboard when active and
focused".
2014-03-10 14:54:58 -04:00
Cole Robinson f23c031af4 ui: Drop minimum version to match RHEL7
And add unit test to catch future dependency issues
2014-03-10 11:17:58 -04:00
Giuseppe Scrivano 75349b9cf0 lxc: define a private network for OS containers
By default, specify the the "<privnet>" feature with LXC operating
system containers.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1040406
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-10 15:48:42 +01:00
Cole Robinson 081e34715f connection: Handle errors when deregistering events on close (bz 1069351)
Otherwise this interrupts the close/cleanup routine, and the connection
never appears to disconnect in the UI. This causes error dialog spamming
when libvirtd goes down.
2014-03-10 09:35:35 -04:00
Cole Robinson cfc52051b7 storagebrowse: Duplicate tooltip logic for 'new volume' button 2014-03-10 08:57:11 -04:00
Giuseppe Scrivano 27db4dac8f doc: fix typo in virt-install man page
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-10 12:52:19 +01:00
Cole Robinson 907c9c4dec spec: Drop needless version/release macros 2014-03-07 09:57:04 -05:00
Cole Robinson 7ef9d7fbfc addhardware: Fix adding disk through 'customize' dialog (bz 1073808) 2014-03-07 09:43:19 -05:00
Chen Hanxiao 40c1f5fdb8 clitest: put fake iso under /tmp dir
commit 797afb3b27
bring a dir depending issue when using
fake iso.
Test output will be undecided when virt-manager source
in different dirs.

This patch will touch a fake iso under /tmp,
so test case will pass on most of the machines.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-07 09:06:27 +01:00
Cole Robinson 797afb3b27 virt-install: Fix --location iso again, and test it (bz 1071513) 2014-03-06 12:46:46 -05:00
Cole Robinson df7012a68b Handle libvirt generating invalid volume XML (bz 1072770) 2014-03-06 12:04:08 -05:00
Cole Robinson 9074fc6c60 fsdetails: Fix adding a filesystem device (bz 1073067) 2014-03-06 11:45:26 -05:00
Cole Robinson 7d62662ec9 fsdetails: Make test driver act identical to qemu 2014-03-06 11:43:32 -05:00
Cole Robinson b078ba8c3d details: Fix fallback if fetching CPU models fails (bz 1072704) 2014-03-06 11:31:09 -05:00
Cole Robinson 75a2e12dc0 tests: Fix a few failures with older libvirt 2014-03-06 11:29:23 -05:00
Chen Hanxiao 98a27fc7fd formats: make sure 'unar' is existed
Commit 0b4a72fd77
need unar command to do something.

But if we haven't installed it, the error message
told us nothing valuable as:
"OSError: [Errno 2] No such file or directory"

This patch will impove the error message.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-06 09:22:03 +08:00
Chen Hanxiao 7dfdbb3f35 Fix some pylint
Two bad-indentation fixed.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-01 11:23:42 +08:00
Cole Robinson 3fcc2c2fed details: Fix setting default window size 2014-02-28 14:36:13 -05:00
Maros Zatko 44d4c1d329 details-toolbar: set show_arrow to true 2014-02-28 14:29:48 -05:00
Maros Zatko 74e6d43903 vmmDetails: toggle visibilities on page change 2014-02-28 14:29:48 -05:00
Maros Zatko dfa23765b5 vmmConsolePages: toggle visibilities on page change 2014-02-28 14:29:48 -05:00
Cole Robinson 4a2493f1e4 console: Fix unsetting 'resize-guest' property from UI
Reported in the followup of bz 754559
2014-02-28 11:47:05 -05:00
Cole Robinson b4e4f68376 cli: Add --graphics defaultMode 2014-02-27 17:43:59 -05:00
Cole Robinson f67df11701 vmm connection: Handle missing storage volumes (bz 1070883)
Similar to what was done in a808bd6692
for the virtinst connection wrapper.
2014-02-27 13:16:21 -05:00
Chen Hanxiao 77553c7e49 ui: disable setting uid/gid_start for user namespace
Libvirt not allowed uid/gid_start
configured as none 0 or not specified.
This patch will disable config uid/gid_start in UI.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-27 10:01:29 +08:00
Chen Hanxiao c1e7da72b7 cli: add missing remove_first method for --blkiotune
Add missing remove_first method for --blkiotune.
Update related man pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-26 09:38:20 +08:00
Chen Hanxiao 25a50d7b27 delete: fix a typo
s/sharable/shareable

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-26 09:36:16 +08:00
Cole Robinson 99eaf059ae Fix deprecation warnings on F21/rawhide 2014-02-25 15:57:38 -05:00
Cole Robinson ce64d037bf engine: Fix closing connection when tick() fails (bz 1069351) 2014-02-25 15:17:34 -05:00
Cole Robinson dd577de636 tests: Remove 'support' module, not very useful these days 2014-02-25 15:06:36 -05:00
Cole Robinson a2ab8a2643 tests: 'skip' a test if compare check fails
And make latest tests dependent on libvirt.git version
2014-02-25 15:05:58 -05:00
Cole Robinson 0b94c83beb xmlbuilder: Actually import logging 2014-02-25 14:56:54 -05:00
Cole Robinson 3efbefe91a Don't forbid object names that are only all numbers (bz 1067127)
Just let libvirt error, since in the case of things like storage pools
this is totally legitimate.
2014-02-25 14:54:06 -05:00
Cole Robinson 87c2ff1a14 xmlbuilder: Log broken XML if we can't parse it
Related to https://bugzilla.redhat.com/show_bug.cgi?id=1066564
2014-02-25 12:45:15 -05:00
Thorsten Behrens b5c3fe1da5 Attempt empty path on virDomainBlockStats
libvirt for some backends yields summary domain stats for empty
disk path - which saves us the looping on our side.
2014-02-24 21:38:20 -05:00
Chen Hanxiao 08daebe1aa details: add UI interface for LXC user namespace
We could config user namespace for LXC container
in details->overview page.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 21:37:13 -05:00
Chen Hanxiao 49cbc20b12 domain: add define method for idmap
add define_idmap and get_idmap method.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 21:37:13 -05:00
Chen Hanxiao a48f75078d virt-install: Add --memtune option
This patch provides the ability to
tune memroy tunable parameters for the domain.
Also add test cases for --memtune option
and update man page.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 21:02:31 -05:00
Chen Hanxiao 6722d2049e tests: update test suites output with the last libvirt
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 11:33:42 +01:00
Chen Hanxiao 0dceb24b3b virtinst: fix an issue of disk bus caculation
commit 466c2bcf9c
will generate the same index for
'hda' and 'hdaa'.
Also break test cases.

This patch will fix this.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-23 13:31:48 +08:00