Cole Robinson
2b41e130d8
connection: rename fetch_all_guests->fetch_all_domains
...
The virtinst class is erroneously called Guest, but these
functions are dealing with libvirt <domain> XML, so rename them
2018-08-31 16:50:46 -04:00
Cole Robinson
83a9e613e9
tests: uitests: Fix breakage
...
Needs adapting to latest TPM addhw work, and armv7 UEFI support
2018-08-31 16:47:10 -04:00
Cole Robinson
b1eb07c26a
guest: Don't add usb tablet for xen PV
...
xen PV doesn't have USB support
2018-08-22 08:38:33 -04:00
Cole Robinson
8d45dba43d
cli: Add --boot bootloader=
2018-08-22 07:38:34 -04:00
Cole Robinson
2b35183352
guest: Don't hardcode /usr/bin/pygrub for xenpv
...
Let libvirt/libxl fill it in. This was required for rhel5 xen at
least, but we don't support that anymore and modern libvirt seems
to do the right thing and fill it in for us.
2018-08-22 07:37:32 -04:00
Cole Robinson
348b7e092c
sshtunnels: Fix bytes vs str in error reporting
2018-08-22 07:29:52 -04:00
Cole Robinson
7cd41ab9ea
guest: Default to e1000e if machine=q35
...
And libosinfo doesn't have any specific recommendation for us
2018-08-21 16:36:38 -04:00
Cole Robinson
2da06fec95
guest: Default to ich9 if machine=q35 (bz 1388177)
...
It's the pci-e version which we should prefer for q35
https://bugzilla.redhat.com/show_bug.cgi?id=1388177
2018-08-21 16:35:34 -04:00
Cole Robinson
e59c3d969e
guest: Remove old xen acpi disabling
...
This is only for rhel5 vintage xen which is long out of support,
so drop it
2018-08-21 16:35:34 -04:00
Cole Robinson
f9600ca31b
virt-install: Remove smm validation and q35 default setting
...
The validation is already handled by libvirt, and setting q35 for
smm=on is overkill and just hardcoding some libvirt logic here.
I think the 'secboot' detection in Guest.py is the preferred
magic here, otherwise let users specify all the correct values.
2018-08-21 15:39:27 -04:00
Cole Robinson
a10b9c841c
details: Fix link state mnemonic
2018-08-21 11:55:17 -04:00
Simon Kobyda
ef4e0dbc4f
details: ADD checkbox to plug/unplug network interface
...
Hardware Details -> NIC of every VM should now contain checkbox for
interface's link state. This checkbox edits domain's XML by changing
<link state='up/down'/>. If XML doesn't contain this tag, virt manager
assumes state "up".
https://bugzilla.redhat.com/show_bug.cgi?id=1614532
Signed-off-by: Simon Kobyda <skobyda@redhat.com>
2018-08-17 10:49:26 +02:00
Cole Robinson
cab540792f
create: Support UEFI installs for armv7l
...
Will be supported with Fedora 29
https://fedoraproject.org/wiki/Changes/uEFIforARMv7
We should probably limit this by selected OS, but that's tricky
with the wizard as it is, so lets see if anyone cares
2018-08-08 15:14:21 -04:00
Cole Robinson
eb0f4a612f
virt-install: Support armv7l and i686 uefi
2018-08-08 15:14:21 -04:00
Cole Robinson
b623ece2ba
domcapabilities: Whitelist fedora arm and ia32 edk2 paths
2018-08-08 15:04:51 -04:00
Cole Robinson
7334cfb366
ui: details: Make firmware/chipset/machine selectable
...
Suggested-by: Laszlo Ersek <lersek@redhat.com>
2018-08-08 15:04:51 -04:00
Lin Ma
a55761c593
details: Use _disable_device_remove helper to set the remove tooltip
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-08-08 10:25:41 -04:00
Lin Ma
0c1fff2494
details: Disallow removing virtio-serial controller if devices attach to it
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-31 10:57:56 -04:00
Cole Robinson
6099ca674e
details: Add _disable_device_remove helper
2018-07-31 10:49:42 -04:00
Cole Robinson
5212ab992e
details: Reset Remove tooltip on hardware selection
...
Otherwise it can be out of date
Reported-by: Lin Ma <lma@suse.com>
2018-07-31 10:37:50 -04:00
Lin Ma
cacf2abe6b
details: Show attached disk info in sata, ide and floppy controller page
...
Reflect controllers <-> disks mapping relationship for not only scsi,
But other storage controllers.
As a bonus, These controllers are not allowed to be removed if there are
disks attached to them.
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-31 10:16:45 -04:00
Lin Ma
4484f473cd
char: Track/Show the state of virtio channels in channel details
...
crobinso: Add a test case
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-12 15:25:23 -04:00
Lin Ma
8f78b33d1c
Output the qemu guest agent lifecycle events in debug mode
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-12 15:19:34 -04:00
Lin Ma
ef3bcff14a
libvirtenummap: Map state vals of agent event to libvirt enum names
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-12 15:19:34 -04:00
Lin Ma
099ec95ac8
connection: Add callback parameter for function _add_domain_xml_event
...
Further patches will pass in the callback instead of the default one.
Signed-off-by: Lin Ma <lma@suse.com>
2018-07-12 15:19:34 -04:00
Pavel Hrdina
931936a328
virtinst: Remove only auto-generated channel source path
...
In attempt to fix https://bugzilla.redhat.com/show_bug.cgi?id=1270696
this code was introduced but it removes the path for all channel
devices. We need to limit it only to the devices that have
auto-generated source path.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591670
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2018-06-28 16:45:14 +02:00
Lubomir Rintel
3a4cf07a28
virtinst: allow adding host block devices to LXC containers
...
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
2018-06-19 15:07:45 -04:00
Lubomir Rintel
a2a022a879
virtinst: allow adding host character devices to LXC containers
...
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
2018-06-19 15:07:42 -04:00
Lubomir Rintel
bba3d04558
virtinst: allow adding host network devices to LXC containers
...
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
2018-06-19 15:05:28 -04:00
Cole Robinson
139031793c
serialcon: Remove direct PTY connection
...
Removal was discussed here:
https://www.redhat.com/archives/virt-tools-list/2018-May/msg00011.html
Libvirt stream APIs are pretty ubiquitous, have several advantages like
remote access, and avoid some pitfalls of direct access. So drop the
old code
2018-06-12 14:23:39 -04:00
Cole Robinson
7a2abb5abf
installer: Remove --location nfs support
...
Removal was discussed here:
https://www.redhat.com/archives/virt-tools-list/2018-May/msg00011.html
Basically I don't think many people use this, the feature is very
inflexible, it's hard to test, and users can essentially do it
themselves with a bit more effort.
2018-06-12 14:07:50 -04:00
Cole Robinson
8e150901f4
clitest: Streamline the string format dict
...
Remove a bunch of dead entries, open code a bunch of limited usage,
and only use the dict for commonly referenced data
2018-06-12 14:07:50 -04:00
Cole Robinson
d68305eaab
tests: utils: Move all URI strings to URIs object
...
Non-functional change, just makes code org nicer
2018-06-12 14:07:50 -04:00
Cole Robinson
e0e6ac6956
tests: Remove useless read_file helper
2018-06-12 14:07:50 -04:00
Cole Robinson
e12049b114
capabilities: Drop old svm/vmx handling
...
We don't realisistically support these old libvirt versions anymore
2018-06-12 14:07:50 -04:00
Cole Robinson
b6cd46b382
virt-install: Add --test-stub-command
...
Fills in basic install options to make the command succeed. Saves
devs having to type boiler plate options when testing new command
line bits
2018-06-12 14:07:50 -04:00
Cole Robinson
876c79cc15
virt-install: Simplify checking for install options
2018-06-12 14:07:50 -04:00
Cole Robinson
4dfc6b03e8
hostkeymap: Fix sanitize_keymap on python3
...
And add test cases to cover the failure
https://bugzilla.redhat.com/show_bug.cgi?id=1585574
2018-06-12 14:07:50 -04:00
Stefan Berger
c58f8514ab
tpm: allow hotplug operation so error is reported by libvirt
...
Perform a hotplug operation so that we get the error notification
about unsupported TPM hotplug operation and we can alert the user
that the change will only take effect upon domain shutdown.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2018-06-12 09:54:15 -04:00
Stefan Berger
a557ed18f9
details: show TPM device model and allow updating it
...
Show the TPM device model and allow updating it. If a TPM 1.2 has been
chosen, we only allow the TIS interface to be selected. In case of a
TPM 2.0 we also enable the choice of the CRB interface.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2018-06-11 12:40:28 -04:00
Marc-André Lureau
c802f2b3b8
details: show TPM version
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2018-06-11 12:40:28 -04:00
Marc-André Lureau
51919b9824
addhardware: learn to set emulated TPM version
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2018-06-11 12:40:28 -04:00
Marc-André Lureau
fa32aea416
tpm: add TPM emulator backend
...
An emulated backend doesn't require any path, since libvirt will take
care of finding the emulator and managing the storage. However, the
version to emulate can be specified.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2018-06-11 12:40:28 -04:00
Marc-André Lureau
67cb191e82
tpm: add CRB device model
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2018-06-11 12:40:28 -04:00
Marc-André Lureau
c04733c10d
addhardware: learn to choose a TPM model
...
There is only one for now, but we are adding CRB next (and SPAPR is
being added too in qemu/libvirt).
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2018-06-11 12:40:28 -04:00
Anya Harter
846e2f711a
cli: add --sound codec support
...
Add codec support to virt-install so that it can accommodate
multiple instances of codec configuration.
The commandline argument:
--sound codec0.type=micro,codec1.type=duplex,codec2.type=output
maps to the sound XML below:
<sound model="es1370">
<codec type="micro"/>
<codec type="duplex"/>
<codec type="output"/>
</sound>
Signed-off-by: Anya Harter <aharter@redhat.com>
2018-06-11 12:23:14 -04:00
Anya Harter
02635d3358
cli: Add --disk geometry attribute options
...
Attribute options are:
- geometry.cyls=W
- geometry.heads=X
- geometry.secs=Y
- geometry.trans=Z
This maps to disk XML like:
<disk>
<geometry cyls='W' heads='X' secs='Y' trans='Z'/>
</disk>
Signed-off-by: Anya Harter <aharter@redhat.com>
2018-06-11 12:02:11 -04:00
Anya Harter
89c389e45a
cli: Add --disk driver.copy_on_read=on option
...
This maps to disk XML like:
<disk>
<driver copy_on_read='on'/>
</disk>
Signed-off-by: Anya Harter <aharter@redhat.com>
2018-06-11 12:00:56 -04:00
Cole Robinson
96414aa88a
domain: Fix removing <console> compat (bz #1586333 )
...
Typo referencing the Guest console list
https://bugzilla.redhat.com/show_bug.cgi?id=1586333
2018-06-07 10:56:47 -04:00
Cole Robinson
bac3ea74ec
virt-install: Do all option compat conversions earlier
...
Prevents more mistakes like usage of old options when building the
Guest instance
2018-06-07 10:56:47 -04:00