Automatically select the connection in this order:
- URI specified via command line --connect
- First active connection
- First connection
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
last commits revealed that some objects can still be accessed by
registered callbacks after the console is closed. Unregister these
callbacks.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Latest VTE doesn't seem to provide set_emulation anymore, and the other
two seem to be the default anyways. This also avoids some VTE bindings
breakage on current rawhide:
https://bugzilla.redhat.com/show_bug.cgi?id=1114379
Python's os.open() defaults to mode 0777 if not explicitly specified.
Disk image files don't need to be executable, and having them world
readable isn't an ideal situation either. Owner writable and group
readable is probably more than sufficient when initially creating
them.
Signed-off-by: Ron Lee <ron@debian.org>
commit f109b1ed6f
used a undefined variable 'PAGE_MAX'.
It looks like it should be in a developing series,
but should be fixed in upstream.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
On the last page in the createnet wizard the Next button is changed to
Finish. Ensure the user input is validated also on this page.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
It fixes this exception:
Traceback (most recent call last):
File "virt-manager/virtManager/host.py", line 467, in add_network
self.addnet.show(self.topwin)
File "virt-manager/virtManager/createnet.py", line 102, in show
self.reset_state()
File "virt-manager/virtManager/createnet.py", line 180, in reset_state
devnames.append(iface.name)
AttributeError: 'vmmInterface' object has no attribute 'name'
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
It fixes this exception:
Traceback (most recent call last):
File "virt-manager/virtManager/createpool.py", line 454, in page_changed
self.set_page(page_number)
File "virt-manager/virtManager/createpool.py", line 451, in set_page
self.show_options_by_pool()
File "virt-manager/virtManager/createpool.py", line 292, in show_options_by_pool
self.widget("pool-source-name").get_child().set_text(
AttributeError: 'Entry' object has no attribute 'get_child'
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This patch will enable setting controller model
when adding controller.
If no USB controller or usb model = none,
we could add a new one;
if had, disable 'create-finish' button.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
Alt+f is already used for Finish. Choose Alt-o as it is already used
for "Format" in other places.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
re-order xml values according to libvirt code.
a) move "blkiotune" "memtune" ahead of "memoryBacking"
b) move "resource" ahead of "pm"
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
The check made in get_config_os_info fails anytime a variant is not
found, making impossible to choose Generic. Change it to not fail if
the OS was found.
commit 33a2d1a1c8 broke this.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
And clean up the API mess while we are at it. Treat the key as an opaque
value that users shouldn't depend on.
Besides the improved code clarity and API layout, this will help diagnose
'key error' issues, since we'll see an object name instead of UUID which
is hard to trace back.
Giuseppe Scrivano