dd823d2d8c
cli: Don't log to debug files from the test suite
...
We shouldn't be doing it anyways, but my recent cache_dir change broke
a bunch of stuff without this.
2013-10-01 10:14:46 -04:00
d44f863c2d
details: Disable snapshot buttons if conn or guest doesn't have support
2013-09-30 20:33:42 -04:00
6043a88a0c
snapshots: Add some specific UI for external snapshots
...
We sort them separately in the snapshot list, explicitly mention that
they are 'external', and add a UI field listing the memory/disk
details.
In general mixing internal and external snapshots is a recipe for
confusion and disaster, so I think the best thing to do is at least
acknowledge their presence in the UI but not make any attempt to
predict what will or will not work.
2013-09-30 19:55:21 -04:00
45e84d46ec
snapshots: Make state type/icon UI match other usage
2013-09-30 17:12:24 -04:00
34c502560f
storage: Drop unused static function
...
This allows us to simplify the parameters for find_free_name
2013-09-30 16:22:12 -04:00
b3c5d123ca
testdriver: Add bits for status, transient, managed save, snapshots
...
No unit tests for any of these, just for UI testing at the moment.
These require some non-upstream libvirt patches, but it doesn't
hurt in the interim while they are reviewed.
2013-09-30 14:30:25 -04:00
66f71262f0
clitest: Add case to verify collision check via backing store
2013-09-29 09:43:39 -04:00
40870dbcd8
tests: Add extra caching to speed up tests
2013-09-28 21:07:22 -04:00
bc34df1dc7
storage: Parse volume backingstore
2013-09-28 19:21:58 -04:00
4822e6478f
clitest: Don't fork rm for every test
...
Speeds up the tests quite a bit
2013-09-28 17:23:23 -04:00
4f59c24b40
tests: Add test_initrd_inject command
...
This is a standalone test like test_urls, and requires interraction. It
pulls down a bunch of kernels from public URL trees, inject known
kickstarts that induce quick failure. User inspects the output to
ensure initrd inject is working as expected.
2013-09-28 16:50:08 -04:00
5329a9afc9
virt-install: Add --tpm /dev/tpm convenience option
2013-09-28 10:28:04 -04:00
eca87838fb
virt-install: Add --features option
...
And hide docs about old --noacpi/--noacpi options. I don't think
anyone really uses them anyways, but if anyone complains we should
just implement --features for the other CLI commands.
2013-09-28 09:58:57 -04:00
fd00ad74e2
devicehostdev: Drop device creation helper
...
Goes against other device paradigms, and is cleaner when we unwind it.
2013-09-27 18:28:28 -04:00
a900ca14e3
domainfeatures: Fill out XML support
2013-09-27 15:35:27 -04:00
1212cf43a9
DomainFeatures: Drop __getitem__ helpers
...
They just complicate matters
2013-09-27 15:08:44 -04:00
186d33d8c5
Fix some pylint
2013-09-27 11:11:09 -04:00
90a610eaef
tests: Fix REPLACEME image.py hack
2013-09-26 19:56:16 -04:00
153e485bb7
Fix some tests
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-26 19:41:40 -04:00
74a2ab5612
test_urls: Fix --path option
2013-09-26 18:32:50 -04:00
d49e11dabc
urlfetcher: Fix distro lookup short circuiting if os_variant specified
2013-09-26 17:45:02 -04:00
7aa24be31a
urlfetcher: Detect debian, ubuntu, and opensuse variant from URL
2013-09-26 17:44:57 -04:00
1220d3082c
test_urls: Fix SL6 test
2013-09-26 14:53:59 -04:00
7d02d508dd
test_urls: Encode expected distro store in URL object
2013-09-26 14:40:52 -04:00
c5f5d5ad9d
urlfetcher: Clean up APIs for fetching URL media
2013-09-26 14:28:13 -04:00
655f458298
test_urls: Turn each URL test into an object, not a dict
...
Update the URL list and fix a couple bugs
2013-09-26 12:36:21 -04:00
ff5b8d29e2
test_urls: Use multiple unittests, not a single big one
2013-09-26 11:49:16 -04:00
601eb5f15e
virt-install: accept a single argument form for RNG devices
...
Detect the "--rng /dev/random" case and assume it is the "random" type.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-26 10:09:33 +02:00
15eac4de59
tests: Fix and update test_urls
2013-09-25 19:36:15 -04:00
382a24d08d
Fix tests on f20, /dev/loop0 isn't available
2013-09-25 19:35:05 -04:00
0d03f972a3
virtinst: handle the guest "title" XML element
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-25 19:16:22 +02:00
a2e5206730
deviceinterface: Fix creating direct interfaces (bz 1006324)
...
And take the opportunity to standarize on setting net.source,
rather than have API users have to do net.bridge/network/source_dev
2013-09-24 10:00:01 -04:00
9ec845af03
xmlbuilder: Unify make_xpath callbacks
2013-09-24 09:25:05 -04:00
a660088768
cloner: Unset domain ID when cloning
...
This unbreaks the cli clone tests whenever a new guest is added to
the testdriver.xml
2013-09-23 21:27:54 -04:00
737016c0cf
guest: Allow parsing domain ID
2013-09-23 21:27:42 -04:00
d261299b5a
testdriver: Add test-alternate-devs guest for alternate rng config
2013-09-23 19:59:42 -04:00
85813203dc
createnet: Use virtinst.Network for XML generation
2013-09-23 13:49:20 -04:00
0323fcfbf7
network: Fix parsing route netmask
2013-09-23 09:10:43 -04:00
b690557a53
Convert NodeDevice to XMLBuilder
2013-09-23 08:25:20 -04:00
a7834f5d6c
Add Network class for parsing <network> XML
...
Convert virtManager/host.py, do some cleanups and modernization to the
UI there, add tests.
createnet.py hasn't really been touched yet, but still works because
it was building the XML by hand anyways.
2013-09-22 11:16:07 -04:00
a55438f880
virt-install: add support for virtio-rng devices
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-20 18:56:19 -04:00
8abcae5073
virtinst: add support for virtio-rng devices
...
The virtio-rng device is supported by libvirt since version 1.0.3.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-20 18:56:12 -04:00
aff0ddb259
Use XMLBuilder for Storage object handling
...
Simplify the API a bunch while we are at it, add tests, etc.
2013-09-20 10:00:08 -04:00
3db5cb5f06
Use XMLBuilder for Interface XML
...
So we unify parsing and building the XML.
Since we already do this for vmmDomain, take the opportunity to move
the shared infrastructure into vmmLibvirtObject
2013-09-19 16:56:38 -04:00
cb06f7eb3d
xmlbuilder: Ensure top level XML objects always end with a newline
2013-09-19 13:48:28 -04:00
eb4068cc47
xmlbuilder: Add infrastructure for parsing into subclasses
...
We already had this open coded in several classes with varying methods.
Now all someone has to do is
features = XMLChildProperty(CPUFeature)
The xmlbuilder code will pull the relevant xpath from the CPUFeature class,
handling parsing into instances of that class directly. The only
thing that needs to be manually added is the add_* remove_* functions.
2013-09-10 21:34:45 -04:00
10e608e9dd
guest: Fix adding a parsed device to a built guest
2013-09-10 18:34:36 -04:00
97f641f645
tests: cli: Fix fallout from testdriver alterations
2013-09-10 18:34:36 -04:00
2e4685590f
testdriver: Drop test-many-nets
...
It doesn't even have as many nets as test-many-devices
2013-09-09 11:38:14 -04:00
67cc81f6b1
virt-install: Add --boot useserial=on
...
Which gives bios output over serial console via sgabios
2013-09-04 11:57:26 -04:00
70fae14635
Automatically add multifunction address parameter when needed
...
Also check for use of duplicate addresses before passing such XML to
libvirt. And fix tests (of course).
2013-09-03 08:08:06 +02:00
1730a8e5ff
virtinst: add nwfilter support
...
This allows to make use of libvirt network filtering support with virt-install.
With the additional option "filterref" in the --network parameter one can
configure any defined nwfilter per network interface, i.e.:
virt-install ... --network network=mynet,model=virtio,filterref=clean-traffic
(crobinso: add an xmlparse test case)
2013-08-29 11:44:40 -04:00
9d11c7eae3
virtinst: Add DomainSnapshot object and some plumbing
...
Just for parsing domainsnapshot XML and performing some support checks
2013-08-21 18:26:27 -04:00
e52f6050fa
qemu ARM support: wire up virtio, fix a bunch of defaults
...
This has some fallout on non-x86 tests which were wrong to begin with.
There's still some missing bits but this is the jist of it.
2013-08-18 12:30:58 -04:00
8c6149d3f3
tests: Add recent libvirt capabilities, share URIs better
2013-08-18 08:39:51 -04:00
414f6bbd99
guest: Use virtio on plain qemu on x86
...
It's been available for a long long time, and unifies code paths.
2013-08-17 18:00:31 -04:00
3130f64e35
VirtualDisk: Add is_disk, is_cdrom, is_floppy helpers
2013-08-17 14:21:30 -04:00
c2a4ca66e9
clitest: Add infrastructure for skipping tests based on support checks
2013-08-17 13:50:36 -04:00
aa2e105f2b
clitest: Simplify test register boilerplate a bit
2013-08-17 09:44:11 -04:00
71a25c267b
clitest: Drop some useless tests
2013-08-17 09:36:03 -04:00
e02fa9b4fe
virt-install: Add --boot dtb=DTB support
...
Allows passing in a device tree binary to the guest. Needed for
some non-x86 configurations.
2013-08-16 19:25:26 -04:00
cc75bc9311
guest: Remove needless functions
...
And simplify some test infrastructure as a result
2013-08-14 19:43:02 -04:00
81ce0a1085
osdict: Clean up 'default' handling usage
...
- Unify looking up osdict values
- Have Guest.py pass in its defaults, not encoding them in osdict
- Explicitly specify every device parameter that osdict handles, rather
than have some psuedo magic dictionary format to handle it
2013-08-12 13:31:47 -04:00
c426d5a16f
Guest: Drop os_type, just use single os_variant
...
Internally the distinction hasn't been valuable for a long time,
so simplify the API here.
2013-08-11 12:39:36 -04:00
3e158b80bf
guest: Move cpuset static functions to DomainNumatune
2013-08-11 12:39:28 -04:00
87789548ba
guest: Drop consolecb and wait parameters from start_install
2013-08-11 12:39:28 -04:00
952708f509
virtinst: Rename most files to be more sensible
...
- Lower case everything
- Virtual... -> device...
- A few other similar bits
2013-08-09 08:54:39 -04:00
01629d3f2c
virtinst: Combine ImageInstaller and ImageParser code
...
They aren't touched much these days, so unify the files for clarity.
2013-08-08 21:00:37 -04:00
accff84ecc
virtinst: Fix import ordering to standardize on relative imports
...
Kind of annoying that some imports were directly from files while
some were from the __init__.py convenience bits.
2013-08-08 20:49:50 -04:00
68ddb9d885
capabilities: Drop workarounds for long gone libvirt bugs
...
These were both fixed 4-5 years ago
2013-08-08 19:41:39 -04:00
623edd1a84
tests: Clean up cli imports even if --skipcli passed
2013-08-06 14:58:43 -04:00
4f63458050
tests: move the storage pool under /dev.
...
The commit efab27afbf02743a3a2582e9a111eb1b7d985b26 in libvirt uses
/dev/%s for logical pools, change the tests to accommodate it.
(crobinso: additional fix to work with older libvirt)
2013-07-29 10:01:18 -04:00
7616077ebf
testdriver: Drop iscsi <auth>, tough to support with old and new libvirt
2013-07-29 09:41:44 -04:00
03bd6f024e
xmlbuilder: Fix setting float value for is_int
2013-07-25 15:31:40 -04:00
695c4b7189
VirtualDisk: Make the driver/type auto changes opt-in
...
It was hard to get this right, so just require that any API users
which are changing the path of an existing disk call sync_path_props()
2013-07-25 15:04:47 -04:00
bba3c93508
xmlbuilder: Always keep around an xml node, even if building from scratch
...
This further unifies the 'parse existing' vs. 'build new' case.
2013-07-25 10:59:23 -04:00
7a369a9802
xmlbuilder: Drop is_multi option
...
It complicates things quite a bit. And there's only one user, so just open
code it.
2013-07-24 12:36:44 -04:00
3cf7679beb
Guest: Add get_install_xml for install handling
2013-07-24 11:32:30 -04:00
2ba3ec2684
Guest: Convert to new style XML prop, drop a bunch of XML infrastructure
...
Now every XML property is new style, without explicit local get/set
handlers. Drop a bunch of XML infrastructure that was helping with the
transition.
2013-07-24 07:54:04 -04:00
24e433a8de
CPU: Convert to new style XML props
2013-07-23 17:34:33 -04:00
6af0848fb8
osxml: Convert to new style XML props
2013-07-23 17:34:33 -04:00
012d1cdc52
Installer: Drop all XML handling, just have it setup install info
2013-07-23 17:34:33 -04:00
07215853b3
Installer: Drop hard to manage install_bootconfig
2013-07-23 17:34:33 -04:00
f37d4d010a
virtinst: Drop __init__ params from Guest and Installer
2013-07-23 17:34:32 -04:00
d9e82f984c
VirtualDevice: Raise error if parsing addrstr fails
2013-07-23 17:34:32 -04:00
524d1047b1
Guest: Make API users opt in for default console/input devices
...
We don't need to maintain API back compat anymore
2013-07-23 17:34:32 -04:00
b18a29d8ff
xmlbuilder: Add explicit support for yes/no XML options
2013-07-23 17:34:32 -04:00
326731cfc5
xmlbuilder: Remove order_elements hack
2013-07-23 17:34:32 -04:00
510d28e33b
Seclabel: Convert to new style XML props.
2013-07-23 17:34:31 -04:00
e802eae07b
VirtualCharDevice: Convert to new style XML props, rework API
2013-07-23 17:34:31 -04:00
9f37f58804
Fix tests that fail due to default graphics change
...
As pointed out, the tests were configuration-dependent and thus might
have failed in case './setup.py configure' was run with non-default
graphics. The default graphics has changed as well and that lead to
test disaster. Reverting first hunk of commit b8a209ef
2013-07-17 08:14:34 +02:00
4f7f9e2267
VirtualAudio: Convert to new style XML props
2013-07-15 22:00:08 -04:00
a9296ec3ae
VirtualController: Convert to new style XML props
2013-07-15 21:52:18 -04:00
dc58d48a33
VirtualGraphics: Drop non-default __init__ params
2013-07-15 20:43:41 -04:00
75e34247f3
VirtualGraphics: Switch to new style XML props
2013-07-15 18:53:53 -04:00
f079ec36eb
VirtualHostDevice: Convert to new style XML props
2013-07-15 17:45:43 -04:00
3ae835dc7c
VirtualNetworkInterface: Drop all XML __init__ params
2013-07-15 14:14:05 -04:00
81cd055f9c
VirtualNetworkInterface: Convert to new style XML props
...
Leave __init__ where it is for now though.
2013-07-15 13:59:09 -04:00
a75cb4074c
VirtualPort: Convert to new style xml properties
2013-07-15 13:08:58 -04:00
98a4d86d7f
VirtualRedir: Convert to new style XML props
2013-07-15 12:57:37 -04:00
b6f2d99db2
VirtualSmartCard: Convert to new style XML props
2013-07-15 12:36:57 -04:00
f3a37ba195
VirtualTPM: Convert to new style properties
2013-07-15 12:18:23 -04:00
e5a7fe6405
VirtualVideo: Convert to new style xml props
2013-07-15 11:19:18 -04:00
e5230e90e9
VirtualAddress: Convert to new style XML properties
...
This adds a bunch of extra XML parsing infrastructure to make everything
work the same.
2013-07-15 10:40:12 -04:00
1a74a8fda6
VirtualDisk: Convert 'type' to new style XML property
2013-07-14 18:15:47 -04:00
2cea517823
xmlbuilder: Allow classes to specify order of certain xml elements
...
This will save us some test case churn. As an example, we now
do auto building of disk <target> XML and it doesn't alter things.
Without this bus and target are often swapped.
2013-07-14 16:45:28 -04:00
154bad0184
xmlbuilder: Simplify default getter/setter some more
2013-07-14 16:35:25 -04:00
2d460a98e5
xmlbuilder: Don't treat 0 as None in setter impl
2013-07-14 16:35:25 -04:00
9c5a1b60ee
CloneManager: Make sure to sync driver_name
2013-07-14 16:35:25 -04:00
6506fb2995
VirtualDisk: Drop is_parse conditional if changing device
...
We can easily push this up to the caller, nothing really changes the
device of an existing device in practice.
2013-07-14 16:35:09 -04:00
c12327cbd1
Guest: Switch memory units to KB to match default XML
2013-07-13 23:07:01 -04:00
69e1d66b53
xmlbuilder: Few misc cleanups and streamlinings
2013-07-13 22:51:54 -04:00
7d75a43e33
XMLProperty: Add convenience param is_int
2013-07-13 21:49:32 -04:00
5f58d05051
VirtualDisk: Convert more XMLProperties to the new world order
2013-07-13 21:40:54 -04:00
e04dfdd4ff
virtinst: Test rhel defaults, and make sure it doesn't break test suite
2013-07-13 20:01:07 -04:00
b152e83fef
virtinst: Rename XMLBuilderDomain.py -> xmlbuilder.py
...
And XMLBuilderDomain -> XMLBuilder
And _xml_property -> XMLProperty
2013-07-13 18:57:24 -04:00
c78c358662
tests: Drop validation.py, largely useless at this point.
2013-07-13 16:52:03 -04:00
4ce1774d53
VirtualDisk: Rework provisioning and validation behavior
...
We separate all the provisioning bits to diskbackend.py. VirtualDisk
users now need to explicitly opt in to storage creation by using
set_create_storage().
validation is no longer done automatically, users must call the
validation() command.
__init__ drops all extra parameters.
This will eventually get us to a point where we can unify the manual
XML building and XML parsing machinery, and get consistent validation
behavior between devices.
2013-07-13 16:37:33 -04:00
fbf2d9ee40
VirtualDisk: Convert simple props to unified parse/get/set
2013-07-12 15:26:51 -04:00
ce243314c0
tests: Verify that every new style XML prop is exercised
...
coverage isn't going to help us much here, so add some hacky infrastructure
to ensure that xmlparse.py is touching every new style xmlprop.
2013-07-12 15:19:37 -04:00
dcd632da80
XMLBuilder: Provide default fget and fset impls
...
This is the first step towards unifying the XML handling split between
parsing and creating from scratch. Demonstrate it with VirtualDisk.iotune
bits.
2013-07-12 14:41:29 -04:00
f620b317b9
tests: Make sure all XML use " for quoting
...
This is what libxml outputs with, and it's going to mess up
test output with upcoming tests.
2013-07-12 14:19:54 -04:00
b26fd8fa3e
tests: Minor cleanup in xmlparse
2013-07-12 13:10:23 -04:00
f1b55090d2
VirtualDisk: Drop cache and io from __init__
...
They are barely used and can be specified separately.
2013-07-12 13:10:23 -04:00
57d4fcab33
VirtualDisk: Drop the volName parameter, it's not needed
2013-07-12 13:10:22 -04:00
c151b75896
XMLBuilder: Remove largely unused validation helpers
...
They aren't adding much value
2013-07-12 13:10:22 -04:00
7a2caee6e1
VirtualConnection: Allow using virt-manager object caches
...
So when we call into virtinst it doesn't do a whole round of object
lookup and XML fetching.
2013-07-07 18:54:08 -04:00
c406a6433c
VirtualConnection: cache version lookups
2013-07-06 15:39:00 -04:00
94f8d4cfa9
VirtualConnection: cache capabilities XML
...
This means we can drop passing around the pre-parsed caps info everywhere.
2013-07-06 14:12:13 -04:00
3005382e0d
Make is_blktap_capable take a connection
...
So we don't perform the check if we're using a remote connection
2013-07-06 12:44:53 -04:00
ba3aa9ecca
Drop conn_max_vcpus validation
...
Let's just let libvirt throw an error in the rare occasion that we
exceed max vcpus.
2013-07-06 12:40:24 -04:00
492a039f7d
VirtualConnection: proxy virtinst.support API
...
Simplifies the lives of callers, and will allow us to do caching later
2013-07-06 12:40:24 -04:00
57e86259d8
Make conn required for all virtinst objects
...
This was the way the API had been heading, this just formalizes it.
2013-07-05 20:28:21 -04:00
be2d9ddcb4
Add base conn object and bump minimum libvirt version to 0.6.0
...
This base connection object will be used to simplify the API in various
places, reduce libvirt API calls, and better share code between virtinst
and virt-manager. For now it just centralizes connection opening.
This also exposed various places where our handling for older libvirt
was busted, so raise our minimum host version to 0.6.0, the first
version that supports threaded client requests.
2013-07-05 16:42:19 -04:00
ea2a1331cf
virtinst: Guest: Simplify passing in a connection
2013-07-03 13:37:00 -04:00
e973f34c41
virtinst: Remove User module
...
I'm sure the solaris support is totally broken, so just drop this
overcomplicated abstraction.
Also fix a bug where we were using usermode networking in a bunch of
places where it isn't supported.
2013-07-02 21:17:07 -04:00
802ed1cba6
clone: Bunch of API cleanup
...
Simplify imports, drop back compat stuff, drop needless property handling.
2013-07-02 18:54:03 -04:00
771707fb9c
Minor TPM UI fixups
2013-06-26 20:20:12 -04:00
2766dd5c6a
Add GUI elements for TPM passthrough details
...
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2013-06-26 19:45:16 -04:00
93718868c7
Add CLI support and CLI test cases
...
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2013-06-26 19:43:58 -04:00
c829b55581
Add VirtualTPMDevice class to virtinst
...
Add VirtualTPMDevice class and TPM test cases to xmlparse.py
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2013-06-26 19:43:53 -04:00
137134650f
Allow partial address formatting
...
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-06-19 18:18:32 -04:00
0283750b9d
Fix USB test failures with latest libvirt
2013-06-14 14:58:52 -04:00
f625cf66d4
testdriver: Add guest using a duplicate host USB device
2013-05-11 11:44:25 -04:00
32f0781531
addhardware: differentiate duplicate usb devices by bus/addr
...
When there are multiple usb devices with same vendor/product
in the host device list, the bus/addr is going to be used when
attaching one of usb devices.
Currently is_dup flag is only useful to VirtualHostDeviceUSB.
I put get_nodedevs_number() in connection.py, so the startup
hooks can use it.
2013-05-09 13:48:18 -04:00
0802cb1add
virtinst: throw error when --host-device can't specify unique device
...
When there are mutiple USB devices with identical vendorId and
productId, with --host-device <vendorId:productId>, virt-install
fails to specify one.
Currently the virt-install add the first node device with
these vendorId and productId.
This fix will throw out an error when argument to --host-device
can't specify unique node device.
For example:
virt-install ${other args} \
--host-device <vendorId:productId>
ERROR 15e1:2007 corresponds to multiple node devices
2013-04-25 13:40:23 -04:00
6f4167a66f
clone: Fix --preserve-data --file /existing/storage/vol
...
We were validating storage creation in a bunch of cases where we
shouldn't, since it was all skipped anyways.
2013-04-24 10:50:20 -04:00
8d1ad359ee
Don't leave *c files around after tests
2013-04-23 17:19:27 -04:00
b2041f7399
clitest: Remove massive dict, turn test cases into objects
...
This will make it easier in the future to annotate test cases with
libvirt version information, so the test suite can work across
libvirt versions.
2013-04-23 17:18:34 -04:00
6f7fca5f2a
tests: Greatly expand testdriver.xml
...
Mostly comes from my own testdriver I used for manual virt-manager testing.
Add some notes to HACKING about using it.
2013-04-21 13:34:51 -04:00
191fff8c0c
tests: Make sure virtinst doesn't pull in Gtk
...
Add an explicit test to warn if it inadvertently happens
2013-04-18 16:41:02 -04:00
07e0c92b4b
Remove a bunch of outdates FIXME/XXX comments
2013-04-17 09:32:00 -04:00
0f57dae8b2
virtinst: Remove not-very-useful post_install_check
...
It doesn't work in a variety of cases and it's not very useful
to begin with.
2013-04-15 12:37:36 -04:00
ee7168e6f9
Add and fix test cases for cpu mode attribute
...
This patch adds and fixes test cases for cpu mode attribute.
Signed-off-by: Ken ICHIKAWA <ichikawa.ken@jp.fujitsu.com>
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
(crobinso: Minor rebase tweaks)
2013-04-14 13:55:26 -04:00
1771f6a300
tests: Replace 'scriptimports' with a much simpler method
2013-04-13 15:38:53 -04:00
0d243983d0
Revive pep8 and clean up the code
...
autopep8 is pretty cool :)
2013-04-13 15:22:43 -04:00
fcc680cae1
Use an RC file for pylint
...
Will let use tweak things easier in the future
2013-04-13 15:22:29 -04:00
3f79fa3919
Fix the last of the pylint messages
...
If using an older pylint, there are still some complaints about hashlib
and Popen, but those aren't our problems.
2013-04-13 13:45:08 -04:00
baf531f710
virtinst: Guest: Remove back compat static device lists
2013-04-13 13:40:45 -04:00
248a1a509f
virtinst: Guest: remove legacy 'boot' handling
2013-04-13 13:40:45 -04:00
7a47465ab6
virtinst: Guest: remove back compat graphics handling
2013-04-13 13:40:45 -04:00
9359ad2bb6
virtinst: Remove ParaVirt and FullVirtGuest
...
They were just around for back compat at this point, the tools
have moved on.
2013-04-13 13:40:45 -04:00
ae471007fc
Tons of misc pylint fixes
2013-04-13 13:40:29 -04:00
a386186c74
Remove most map() and filter() usage
...
They aren't available on python3 so pylint complains, and list
comprehensions are usually better.
2013-04-12 08:27:44 -04:00
c5e45ae448
Remove all relative imports
...
We also drop VirtualDevice from the 'public' virtinst API, since there
are better ways to get its info.
2013-04-12 08:27:44 -04:00
aead0135b0
setup.py: Re-add 'pylint' subcommand
...
We drop our hacky shell wrappers, and just track it all in setup.py
2013-04-12 08:27:09 -04:00
69d3f21da6
virtinst: nic: Don't check MAC collision with host
...
It was:
- Slow
- Not that useful
- Only worked in the local case
If anyone cares, the proper thing to do is implement it with the iface APIs.
2013-04-11 12:15:37 -04:00
459cb3de5e
util: Remove old default_bridge, rename default_bridge2
2013-04-11 12:15:37 -04:00
b3779eec7d
Remove old 'Xen' class name back compat
2013-04-11 12:15:37 -04:00
3bce20d974
virtinst: Combine util.py and _util.py
...
Was originally split to not pollute the public API, but we aren't public
anymore
2013-04-11 12:15:37 -04:00
1876ce0af8
Fix cpuset tests
...
In order to fix last tests that fail for me, I had to modify the
output xml, both modified machines will fit in the first numa node, so
the cpus from that node should be mentioned in the xml and that lead
me to the fact that the problem was in the test xml and not the code.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-04-10 10:02:13 -04:00
a2d36f8c52
Fix hostdev tests
...
For <hostdev> element, mode="capabilities" is used only for
block/character device passthrough and thus it fails with pci
passthrough.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-04-10 10:02:13 -04:00
212b77cc1f
Fix logical volume tests
...
After commit 590c8dbebf
2013-04-10 10:02:13 -04:00
73629b76b2
IPv6 support v2: update gui python and ui
...
The purpose of this update is:
1. replace use of IPy with ipaddr since ipaddr has needed
functionality and IPy does not.
2. Update the glade-3 ui (vmm-host.ui) to provide
for IPv6 as well as IPv4. If either IPv4 or IPv6
is not defined, its respective frame is hidden.
3. The DNS Domain Name is added to the basic frame.
4. IPv4 forwarding is moved to the basic frame and ipv6
forwarding is added.
5. If an IPv4 address is not defined then the IPv4
is set to Isolated network, internal rout only.
6. IPv6 network has three values for Forwarding:
Isolated network, Isolated network with internal forwarding,
and Routed network.
7. Add network definitions to tests/testdriver.xml which
include IPv6 and other new parameters now being handled.
This patch includes the fix for getting a KeyError exception
when deleting a network definition.
In this update, createnet.py has been changed to use
ipaddr but it still only handles IPv4 network creation.
.
Signed-off-by: Gene Czarcinski <gene@czarc.net>
(crobinso: Add Gene to AUTHORS)
2013-04-03 21:32:42 -04:00
ae0e151c8a
tests: Add rbd pool example to testdriver
2013-04-03 19:40:39 -04:00
d6c8ad0297
Wire up python unit tests, unify gettext setup
2013-04-03 18:22:05 -04:00
88603e4fad
Merge code from python-virtinst.git
...
As outlined here:
https://www.redhat.com/archives/virt-tools-list/2012-February/msg00040.html
For now this is just a direct import of the code from virtinst commit
dca5a4d6245f21d554f8853197a6a234bfc8e52c. History is not merged, so
please refer to original git for detailed commit histor:
http://git.fedorahosted.org/cgit/python-virtinst.git/
2013-04-03 18:22:05 -04:00
9d05583c26
Remove autotools, replace with distutils-extra
...
Despite being a known quantity, autotools is so overkill for our needs,
so let's drop it and replace it with a much simpler and easy to customize
system.
2013-04-03 18:20:51 -04:00
abbdd1743a
Fix some pylint
2013-04-03 18:13:27 -04:00
e741d9cab6
Clean up all pylint + pep8 violations
2013-04-03 18:13:25 -04:00
d057cce292
Remove local copy of IPy
2013-04-03 18:13:25 -04:00
3c3237b951
Convert to use GTK3 and GObject Introspection bindings
...
Switch over to use GObject introspection bindings for all python
modules related to GObject/GTK3/etc. It is not possible to mix
and match old pyggtk/pygobject manual bindings with new introspection
based bindings so it must be all changed in one go.
Imports like
import gtk
Change to
from gi.repository import Gtk
The vmmGObject class is changed to always inherit from GObject.GObject
There is no compelling reason to avoid a GObject dep for the
virt-manager TUI & it horribly messed up the code.
Signal declarations are changed from
vmmChooseCD.signal_new(vmmChooseCD, "cdrom-chosen", [object, str])
To
__gsignals__ = {
"cdrom-chosen": (GObject.SignalFlags.RUN_FIRST, None, [object, str])
}
which is required by new GObject bindings
Most of the rest of the change is simply dealing with renamed
constants / classes.
Alot of legacy compat code was removed - ie helpers which
check to see if certain GTK2 methods are available are no
longer required since we're mandating GTK3 only.
The event loop is replaced with LibvirtGLib's event loop.
Still todo
- Rip out all DBus stuff & make vmmEngine class inherit GtkApplication
which provides unique support & DBus method handling
- Switch to use LibvirtGConfig & LibvirtGObject for libvirt interaction
- Possibly switch to Python 3 too ?
- Figure out why GNOME keyring is missing Introspection support
My suggestion is that the standalone GIT repo for virt-install
only live on as a support branch for legacy platforms.
A stable-0.9 branch of virt-manager can be kept for legacy PyGtk2
based virt-manager releases.
The virt-manager master branch should exclusively use GObject
inspection and ideally Python3 and contain both the virt-manager
and virt-install codebases in one since they are intimately
related to each other & using separate GIT repos has needlessly
complicated life for everyone.
crobinso:
Some locking fixes
Misc cleanups and dropping now-useless code
Fix dbus usage
Fix graph cell renderer regression
Fix a couple tooltip issues
2013-04-03 18:13:24 -04:00
12dcebcc0a
Disable a bunch of pep8 tests I won't fix before gtk3 port
2013-02-06 15:41:43 -05:00
f4aa83e10f
Fix pylint detection, and clean up the fallout
2012-01-31 19:07:32 -05:00
1ff601138f
Specify all logging string format args as function parameters
...
As warned about by pylint. Also clean up some pylint false positives
and a few scattered legit warnings.
2012-01-16 22:04:40 -05:00
a1d2b1a0f0
pylint: s/addmsg/skipmsg/g
2012-01-16 21:13:41 -05:00
25f5bc90a7
Actually run pep8 against TUI, fix the fallout
2011-07-14 12:28:05 -04:00
303c8c91df
tui: Enable pylint check for TUI, fix a bunch of reports
...
There are still a lot of errors reported, so more patches are required to
make pylint silent.
2011-05-31 15:55:52 -04:00
33b67a1c16
pylint: Add a test exception
2011-03-23 10:41:07 -04:00
677f73fca7
Run pep8 with check-pylint, fix the fallout
2010-12-10 11:47:07 -05:00
0fd57daca1
pylint: Check for unused variables, fix fallout
2010-12-09 11:22:35 -05:00
fe14b5e200
Use URI hacking from virtinst to facilitate testing
2010-12-07 14:26:51 -05:00
1c3e7a1ea3
Remove some unneeded imports and old pylint workarounds
2010-11-30 15:01:02 -05:00
779dcdd824
Don't use old style __gobject_init__()
2010-11-30 14:40:49 -05:00
5a8523fc03
Silence a pylint false positive
2010-11-29 18:11:27 -05:00
81eb69853f
More pylint fixes
2010-11-29 17:28:52 -05:00
716bec3e56
Enable some more basic pylint checks and clean the code
2010-11-29 14:06:43 -05:00
026934ed3e
pylint: Fix script for latest pylint version
2010-11-11 16:29:30 -05:00
297c84bbc3
Clean up pylint
2010-05-05 16:16:15 -04:00
1e9dcc8615
Drop no longer needed pylint check.
2010-04-21 13:09:15 -04:00
5aaae5db86
Fix 'tests' install to not end up in RPM
2010-02-08 22:27:15 -05:00
b53a3a5e6b
Fix an error detecting pylint features
2010-01-27 13:47:53 -05:00
1842a204dd
Fix up some pylint.
2009-10-28 20:35:13 -04:00
c24ba2fd5d
Make sure pylint supports a check before we disable it.
2009-10-28 20:20:14 -04:00
994d516ee8
Block a new pylint check.
2009-09-17 12:31:17 -04:00
31509207c2
Actually try to fix pylint spamming.
2009-09-16 16:00:47 -04:00
2802745e3e
Try to avoid 'maximum recursion depth' errors from pylint script.
2009-09-14 10:14:41 -04:00
1e603974bd
Clean up some pylint warnings on rawhide.
2009-05-11 10:13:32 -04:00
dd50d5e141
Check 'defined outside init' w/ pylint script, fix errors.
2009-04-03 14:15:23 -04:00
67adc74816
Packages the tests directory with 'make dist'
2009-04-03 14:15:13 -04:00
b1f69cffd8
Add libvirt storage aware file browser.
...
Hook it up to the New VM and Add Hardware wizards, all storage browsing.
2009-03-09 16:19:39 -04:00
bdd09af3f7
Mark pylint script as executable.
2009-01-12 14:54:32 -05:00
83884c0ef6
Add 'make check-pylint' command.
2008-12-17 15:27:38 -05:00
Cole Robinson