Commit Graph

3883 Commits

Author SHA1 Message Date
Cole Robinson 42fe235cbf virt-install: Add --network portgroup= option 2014-05-31 14:30:07 -04:00
Cole Robinson 1c608f3ba8 network: Parse <portgroup> XML 2014-05-31 14:20:56 -04:00
Cole Robinson 519e3b5768 connection: Log when objects are added/removed 2014-05-31 13:52:13 -04:00
Cole Robinson 3654d56aa6 create: Raise error if populating summary page fails 2014-05-31 13:31:08 -04:00
Chen Hanxiao 33c7e63a99 cli: fix some style misc issue
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-05-29 17:06:13 +08:00
Chen Hanxiao 3c45262526 virt-install: add --events support
This patch will enable setting event configuration:
on_poweroff, on_reboot and on_crash.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-05-29 09:46:24 +08:00
Cédric Bosdonnat 2e7ebd4b76 Don't create a qemu disk image when creating containers
Make sure we don't create a default disk image if the option is checked
but not visible as this is the case for containers
2014-05-28 08:26:42 -04:00
Cole Robinson 768ff1ff84 createvol: remove redundant logging 2014-05-21 10:45:51 -04:00
Chen Hanxiao 0b21c96d34 host: fix a typo
s/Starmode/Startmode

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-05-21 16:41:30 +08:00
Giuseppe Scrivano b84f8cb406 osdict: fix default value for devices data
commit 4f056dcba9 didn't take into
account the default value.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-05-21 10:09:41 +02:00
Giuseppe Scrivano 4f056dcba9 osdict: lazy load devices data
Do not load the devices data for each OS as most of this data will
will not be used by virt-manager.  It makes the "Create new VM" wizard
faster on the first time it is accessed (~0.5s faster on my machine).

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-05-20 08:41:22 +02:00
Cole Robinson 139392c093 createnet: Catch too small network prefix (bz 1095347) 2014-05-19 19:23:46 -04:00
Cole Robinson 51976bba2d storagevol: Log on XMLDesc errors 2014-05-19 17:32:22 -04:00
Cole Robinson f397d96ca6 virt-install: Don't require install option with --print-xml (bz 1095789) 2014-05-11 19:19:00 -04:00
Cole Robinson ea89dfb53f tests: Don't fail on non-latest libvirt 2014-05-11 19:11:45 -04:00
Cole Robinson 2de9e9cc52 virt-install: Remove needless error message redirection 2014-05-11 19:00:51 -04:00
Giuseppe Scrivano 78caf0d5da doc, virt-install: add "lun" to the Disk device type list
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1077232

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-05-05 15:23:34 +02:00
Chen Hanxiao c28516e73c test: Fix tests with latest libvirt
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-05-05 11:00:35 +08:00
Cole Robinson 9fd0ef5c88 details: Better handling for <input type=keyboard> 2014-05-04 13:23:54 -04:00
Cole Robinson 3d02ff220d appdata: Clarify license
As recommended at:
http://blogs.gnome.org/hughsie/2014/05/02/appdata-meet-spdx-spdx-meet-appdata/
2014-05-03 13:42:10 -04:00
Cole Robinson 196ff823b3 Fix warnings with latest pep8 2014-05-02 10:20:59 -04:00
Cole Robinson cddb9cc426 domain: Clearer debug message when status update fails 2014-05-02 10:13:33 -04:00
Cole Robinson 725b0fb0b3 asyncjob: Remove uninteresting debug message 2014-05-02 10:08:56 -04:00
Cole Robinson 7fb0aa05a2 domain: Emit debugging message when we update status 2014-05-02 10:08:39 -04:00
Cole Robinson 5c28a00d3e connection: Call path_exists before getting storage volume (bz 1092739)
path_exists will check to ensure the volume actually survives a pool
refresh, incase it was deleted behind libvirt's back. This makes the
delete dialog happier at least.
2014-04-30 16:00:34 -04:00
Cole Robinson f35438a01b engine: Show error if launching delete dialog fails 2014-04-30 15:54:00 -04:00
Cole Robinson 3d49bbe649 create: Fix error when detecting OS in 'show all' list
The will be free'd when the widget is repopulated, so don't access
stale data.
2014-04-30 15:46:06 -04:00
Cole Robinson 3ae2b0959d create: Simplify set_os_val 2014-04-30 15:45:56 -04:00
Cole Robinson 15449eb126 packageutils: Fix install when one package is already installed (bz 1090181) 2014-04-29 14:34:31 -04:00
Cole Robinson feadd98fed Fix using storage when the directory name contains whitespace (bz 1091384) 2014-04-29 14:09:14 -04:00
Cole Robinson 2272166844 snapshots: Fix screenshot with qxl+spice (bz 1089780) 2014-04-29 13:26:26 -04:00
Jim Minter 764063dfe9 virt-install --disk discard= support
(crobinso: Remove default overriding, add test cases)
2014-04-29 10:38:30 -04:00
Cole Robinson 02f49be9e2 serialcon: Hide scrollbar until there's something to scroll 2014-04-29 10:28:06 -04:00
Chen Hanxiao 10e199279d console: fix a comment typo
s/arbitray/arbitrary

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-26 23:01:08 +08:00
Chen Hanxiao 8d3dbfb90c details: force select list entry before showing popup menu
We show/hide remove device menu by the attribute
of config-remove button.
But on some desktop, it showing popup menu before
selection.
This patch will force select list entry before
showing popup menu.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-26 22:45:50 +08:00
Chen Hanxiao 2dd2e440d1 addhardware: introduce populate_controller_model_combo
Introduce populate_controller_model_combo for details
and addhardware.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-26 22:41:31 +08:00
Chen Hanxiao 865dd99af2 addhardware: add controller UI
This patch will enable adding controller
without model.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-26 22:40:17 +08:00
Giuseppe Scrivano 33a2d1a1c8 virt-manager: use autocomplete for OS variant selection
After the migration to libosinfo, choosing an OS variant from "New VM"
wizard became a mess for the very long list of options.
Using an autocomplete entry text will facilitate this task, as an user
can start typing the variant as soon as the OS type is selected.
The combo-box is left untouched, so undecided users can still use it.

UI-suggested-by: Máirín Duffy <duffy@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-04-26 10:32:30 +02:00
Cole Robinson 6ed988ebfc osdict: Prevent traceback in the logs when detection fails 2014-04-25 16:31:00 -04:00
Chen Hanxiao b1236c1af0 console: fix a comment typo
s/succesfull/successful

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-22 23:41:04 +08:00
Chen Hanxiao cb682c09eb details: show/hide remove popup menu by remove button
Use the senesitive attribute of remove button to
determine whether remove popup menu should be shown.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-22 07:31:18 +08:00
Cole Robinson 70da20682c details: Explicit warn that 'format' doesn't change image format (bz 1089457) 2014-04-21 17:04:33 -04:00
Cole Robinson e6a67fc709 filesystem: Fix target validation when editing device (bz 1089422) 2014-04-21 16:51:57 -04:00
Giuseppe Scrivano b20462d861 virt-manager: display error on an empty installation URL
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1086529

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-04-18 09:52:44 +02:00
Giuseppe Scrivano 06e480c847 virt-manager, addhardware: disable "Finish" with unsupported devs
Disabled the "Finish" button in the "Add Hardware" window when the
specified dev is not supported by the HV.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1087670

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-04-17 21:11:00 +02:00
Cole Robinson d4c27baa45 connection: Mark a few bits as private 2014-04-16 12:29:24 -04:00
Cole Robinson 873c22d19a connection: Avoid some useless errors when connection closes
- Run the connection
- Restart libvirtd, connection is auto closed
- Re-run the connection
- Manually stop it, see errors in the logs about unknown event IDs

We need to unconditionally clear our event ID list
2014-04-16 12:29:24 -04:00
Cole Robinson 1f7604b241 engine: More work to fix cascading error dialogs
If a remote network connection stalls, the tick queue becomes backed
up while we wait for the hung connection to continue. While this
happens, the queue is filled up with other requests to poll the hung
connection.

When the connection finally times out, the tick thread closes the
connection via an idle callback. However before that callback gets
a chance to run, all the other poll requests for the dead connection
are processed, all launching their own error dialog.

Mark the connection as 'closing' before conn.close is scheduled, and
use it to short circuit the tick() routine.
2014-04-16 12:29:24 -04:00
Cole Robinson 341a453d28 error: Don't log redundant details bits 2014-04-16 12:17:10 -04:00
Chen Hanxiao 6288135f2b addhardware: use range to initialize page number
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-16 23:39:06 +08:00