Commit Graph

5165 Commits

Author SHA1 Message Date
Cole Robinson 4c4d31d67d tests: Fix after vmvga change 2017-04-19 14:08:04 -04:00
Bryan Quigley 984ba6b33e osdict: Remove ubuntu vmvga usage
This is now removed in patches on Ubuntu, so seems no longer necessary.

virt-manager-1.3.2/debian/patches/virtinst/use_qxl_for_ubuntu.patch

That patch is also from Marc Deslauriers on 2016-01-28
2017-04-19 10:03:17 -04:00
Cole Robinson 93085d2b9d guest: Don't repeatedly overwrite self.domain
Since clearing it is important, just set it at the end when things
have succeeded
2017-04-13 14:56:03 -04:00
Christophe Fergeau 2099a1946e Reset Guest.domain to None on domain creation error
When an error occurs when the VM creation wizard tries to start the VM,
it's then not possible to press again the "Finish" button to try again
to start it, as this errors out with:

Traceback (most recent call last):
  File "/home/teuf/redhat/virt/virt-manager/virtManager/asyncjob.py", line 88, in cb_wrapper
    callback(asyncjob, *args, **kwargs)
  File "/home/teuf/redhat/virt/virt-manager/virtManager/create.py", line 2341, in _do_async_install
    guest.start_install(meter=meter)
  File "/home/teuf/redhat/virt/virt-manager/virtinst/guest.py", line 457, in start_install
    raise RuntimeError(_("Domain has already been started!"))
RuntimeError: Domain has already been started!

This is caused by code introduced in commit fc6778 which does not reset
self.domain to None when an exception is caught.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2017-04-13 14:24:40 -04:00
Pino Toscano 6b23810733 virtinst: tweak distros in the 'supported' workaround
- pick only the latest version for centos6.x, centos7.x, and
  freebsd11.x; the latter two have only one element each currently,
  so this is preparing for future versions
- bump the minimum supported version of Fedora to 24
- enable also mageia >= 5, and centos >= 7.0, since they are supported

Hopefully in the future we can reduce these checks (maybe accepting
directly some families), but for now improve our hacks.
2017-04-13 14:20:02 -04:00
rst0git 04d46d4baa Replace GtkHBox and GtkVBox with GtkBox.
Problem:
    - GtkHBox and GtkVBox have been deprecated since version 3.2 and should not be used in newly-written code.

Solution: Replace GtkHBox and GtkVBox with GtkBox.
    - I have used the find function in text-editor to find all occurances of "GtkVBox" and "GtkHBox" then replaced them with "GtkBox".
    - Then append on a new line immediately after "<property name="orientation">...</property>" with value "horizontal" or "vertical" accordingly.
2017-04-12 09:22:56 -04:00
Cole Robinson ff3b4dc5b0 cli: Don't overwrite install bootorder with manual --boot (bz 1438946)
--boot should be for post-install bootorder only

https://bugzilla.redhat.com/show_bug.cgi?id=1438946
2017-04-04 18:22:15 -04:00
Rowan Potgieter a98b456975 Add x86_64 check to urlfetcher to cater for Ubuntu 16.04 2017-04-04 15:24:05 -04:00
Cole Robinson 6d1a3db421 createnet: Cleanups around hostdev UI 2017-04-04 15:20:33 -04:00
Lin Ma 97c8412df6 network: add support to create SR-IOV VF pool
Create a network with a device pool containing all the VFs of an SR-IOV device.

Signed-off-by: Lin Ma <lma@suse.com>
2017-04-03 19:15:11 -04:00
Lin Ma fe9588d438 tests: add test for network of SR-IOV VF pool
Signed-off-by: Lin Ma <lma@suse.com>
2017-04-03 19:09:08 -04:00
Lin Ma 17ac04a62b testdriver: Add missing net dev to match pci dev for SR-IOV network test
Add missing net device to match pci device for network ui test of the
SR-IOV VF pool.

Signed-off-by: Lin Ma <lma@suse.com>
2017-04-03 19:09:02 -04:00
Venkat Datta N H 66435cb03d virt-install:support --features hyperv_synic=(on/off) 2017-03-30 14:19:06 -04:00
Chen Hanxiao a72d368c4e nodedev: remove useless exception instance
Commit f341352cda
removed redundant error string,
so the instance 'e' in exception is useless.
Just delete it.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-03-30 22:43:44 +08:00
Cole Robinson f341352cda nodedev: Remove redundant error string (bz #1370418) 2017-03-29 14:09:35 -04:00
Cole Robinson 0610cd6acb console: Ensure bool value used for set_sensitive call
Seen in a bug log file:

[Tue, 28 Mar 2017 12:05:21 virt-manager 2465] DEBUG (cli:251) Uncaught exception:
Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/details.py", line 1303, in refresh_vm_state
    self.console.details_update_widget_states()
  File "/usr/share/virt-manager/virtManager/console.py", line 1025, in details_update_widget_states
    return self._update_vm_widget_states()
  File "/usr/share/virt-manager/virtManager/console.py", line 597, in _update_vm_widget_states
    self._refresh_widget_states()
  File "/usr/share/virt-manager/virtManager/console.py", line 663, in _refresh_widget_states
    self.widget("details-menu-vm-screenshot").set_sensitive(is_viewer)
TypeError: Argument 1 does not allow None as a value
2017-03-29 12:07:50 -04:00
Cole Robinson 14f3efa810 libvirtobject: Add better __repr__ for debugging 2017-03-29 12:07:50 -04:00
Chen Hanxiao 407915b489 virt-xml: add qemu commandline passthrough example
We forgot to mention --qemu-commandline in virt-xml.pod.
Also added an example copied from Cole's blog.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-03-29 23:51:42 +08:00
venkat 935c93812f virt-install: support --features hyperv_reset=(on/off) 2017-03-27 17:50:35 -04:00
Cole Robinson 2c8ed52813 Fix some pylint 2017-03-27 17:27:14 -04:00
Lin Ma 7c8005b999 testdriver: Add network example of a pool of SRIOV VFs
Signed-off-by: Lin Ma <lma@suse.com>
2017-03-27 17:27:14 -04:00
Lin Ma 262376d16f nodedev: Parse PCI capability_type for SR-IOV device
This will be used in the following patch to recognize SR-IOV capable
device.

Signed-off-by: Lin Ma <lma@suse.com>
2017-03-27 17:15:17 -04:00
Lin Ma 899f53b993 testdriver: Add SR-IOV example
Signed-off-by: Lin Ma <lma@suse.com>
2017-03-27 17:15:07 -04:00
Yaniv Kaul 7d221d51f1 Update virt-install man with path to Fedora 25 ISO
The path was to an outdated Fedora 21. Updated for Fedora 25.
2017-03-27 16:20:01 -04:00
Charles d'Hondt b545201617 Added OpenVSwitch Network Detection
Small patch to allow VMM to detect OpenVSwitch

Signed-off-by: Charles d'Hondt <charles.dhondt@gmail.com>
2017-03-24 16:42:45 -04:00
Cole Robinson 24a073a9bc testdriver: Add openvswitch <network> example 2017-03-24 16:27:46 -04:00
Pavel Hrdina cb182f7e3a graphics: skip authentication only for VNC with listen type none
This is in fact a bug in QEMU so we have to workaround this issue
to allow to connect to guest with VNC and listen type none.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1434551

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-03-23 15:26:19 +01:00
Cole Robinson cfc4e903b7 details: Remove some debug printing 2017-03-22 12:28:04 -04:00
David Thurstenson a86c119e1c Fix ambigous label on Autostart checkbox
When the Autostart checkbox on the host Virtual Network or Storage tabs
is deselected, the label reads "Never", and when selected the label reads
"On Boot". This changes these labels to always read "On Boot".
2017-03-22 11:53:00 -04:00
Cole Robinson aefea61fa0 create: Fix some minor UI issues with vz installs 2017-03-22 11:40:04 -04:00
Mikhail Feoktistov 3f59906af6 Add GUI test for Virtuozzo containers 2017-03-22 11:00:50 -04:00
Mikhail Feoktistov 5a70b946c7 Add GUI to create wizard for virtuozzo containers
Add virtuozzo hypervisor to connection list.
Add radio buttons for choosing VM or container virtualization type.
New wizard window for setting template name for containers.
2017-03-22 11:00:50 -04:00
Cole Robinson 6b5106eae6 Fix format errors in it.po and ko.po 2017-03-21 19:28:36 -04:00
Cole Robinson 452a693e0a Update some translations 2017-03-21 19:26:59 -04:00
Cole Robinson fd048e4c1c tests: Add msgfmt validation for pofiles 2017-03-21 19:23:29 -04:00
Cole Robinson 6715ed6be9 tests: Minor cleanups to ui version file test 2017-03-20 17:04:54 -04:00
Cole Robinson c66098f3b6 Fix busted italian translation, again (bug 1433800) 2017-03-20 16:45:47 -04:00
Cole Robinson f5d709d9d0 Update italian translation from zanata 2017-03-20 16:43:58 -04:00
Mikhail Feoktistov c25ea6537b Tune default device list for Virtuozzo containers
Virtuozzo supports virtio NIC.
Also add default VNC graphics.
Privnet feature and emulator device have no sense for vz containers.
2017-03-17 13:36:15 -04:00
Mikhail Feoktistov d86792fe0a Add VM capabilities to vz.xml 2017-03-17 13:27:04 -04:00
Cole Robinson 9c8ffe51da storage: Move alloc/cap validation to validate()
Doing this at property set time is overly noisy. Follow the same
pattern of VirtualDisk and only do this in the validate() function.

https://bugzilla.redhat.com/show_bug.cgi?id=1433239
2017-03-17 12:14:05 -04:00
Cole Robinson c08226182e Prep for release 1.4.1 2017-03-08 18:48:48 -05:00
Cole Robinson b58417071c ui: about: Adjust copyright year 2017-03-08 18:25:32 -05:00
Cole Robinson 8f39de8243 ui: details: Tweak RNG page a bit 2017-03-08 17:48:26 -05:00
Cole Robinson d62e975568 guest: Add default virtio-rng /dev/urandom (bz 1212082)
For guests that support it, per libosinfo, and new enough libvirt
to handle /dev/urandom. See the bug for discussion

https://bugzilla.redhat.com/show_bug.cgi?id=1212082
2017-03-08 17:26:19 -05:00
Cole Robinson dff27a298e cli: Default to ignoring 'none' strings
If the parsed option string is just 'none', make it a no-op.
This helps us be backwards compatible: for example, --rng none is
a no-op, but one day we decide to add an rng device by default to
certain VMs, and --rng none is extended to handle that. --rng none
can be added to users command lines and it will give the expected
results regardless of the virt-install version.

Options that already have special 'none' handling need to opt out
of the default behavior.
2017-03-08 17:05:36 -05:00
Cole Robinson 8eee62712e gfxdetails: Add more errors/warnings around spice GL
Add warning icons with informative tooltips. Desensitive UI rather
than hide it if the hypervisor doesn't support things. A few other
usability tweaks
2017-03-08 16:07:32 -05:00
Cole Robinson f61e586b77 domain: rename: Fix when nvram pool is newly created
We don't have any way at the momemnt to synchronously update cached
object lists. So if old_nvram will create a pool for the nvram dir
(/var/lib/libvirt/qemu/nvram), new_nvram won't see that new object
in our cache, will attempt to create it itself, and raise an error.
Next attempts succeed though.

We can avoid this by not even setting new_nvram.path, that step was
redundant anyways since we are setting a vol_install right afterwards.
This way, new_nvram is getting a reference to the parent_pool object
via the vol_install, so it doesn't even check the pool object cache.
2017-03-08 14:22:44 -05:00
Cole Robinson a9e3e50046 xmlbuilder: Improve __repr__ a bit
To show child class name as well
2017-03-08 13:59:11 -05:00
Cole Robinson e58b1fc95f uitests: Add details->rename tests 2017-03-08 13:22:09 -05:00