Commit Graph

4439 Commits

Author SHA1 Message Date
Cole Robinson 4e47cc9061 console: Fix password entry grab_focus 2015-04-12 12:43:29 -04:00
Cole Robinson f013453999 sshtunnels: Don't log the SSH command over and over
Just log it once at init time
2015-04-12 12:21:38 -04:00
Cole Robinson 2ca72d1117 viewers: Don't try to use SSH tunnels in spice local case
Regressed with the recent tunnel cleanups
2015-04-12 11:06:15 -04:00
Cole Robinson acebd1248c viewers: Add explicit API for removing display from parent
Previously we were hacking it in
2015-04-12 10:33:41 -04:00
Cole Robinson c3fc4ee5a2 console: Drop timeout retry logic
This was needed in the days of old xen + libvirt, but I don't think
it's required nowadays, and if it is it's busted with our XML caching
I think.
2015-04-12 10:24:35 -04:00
Cole Robinson 792774450f console: Properly cleanup viewer when closing
Otherwise signals aren't properly removed, can cause some backtraces on
shutdown.
2015-04-12 09:53:23 -04:00
Cole Robinson 80c2dde350 virt-manager: Fix connection to domain from cli
Need to tweak our signal handling here with the recent connection changes.
2015-04-12 09:34:55 -04:00
Cole Robinson aec851f73a viewers: Always clean up tunnel FDs when closing viewer
We were basically leaking a lot of FDs. They were still being tracked
but they were stranded and never dealt with.
2015-04-11 22:44:03 -04:00
Cole Robinson e2cdfd651c sshtunnels: Don't use python socket for FD we pass to spice
Since socket objects close their FD when they are garbage collected,
this seems to lead to crashes like reported here:

https://bugzilla.redhat.com/show_bug.cgi?id=1135808
2015-04-11 22:36:04 -04:00
Cole Robinson 21b80226a8 config: Remove debug print statement 2015-04-11 22:36:04 -04:00
Cole Robinson 285e345f17 viewer: Simplify tunnel handling
- Cache ginfo, since it is tied to a single viewer instance
- Always create the sshtunnels object
- Track lock state so we can make it idempotent
2015-04-11 21:39:24 -04:00
Cole Robinson 93f826a8b2 cli: Replace add --check option (bz 1063471)
For fine grained enabling/disabling validation checks. Use this to
replace the heavy handed --force option.
2015-04-11 19:48:35 -04:00
Cole Robinson 0f3d86ac9e guest: Disable PM for virt-install as well
We are just mirroring the behavior that virt-manager (and boxes) have
used for a while now.

In my experience the average user is confused by their VMs suspending,
so for our sake I'd rather make people opt into this feature.
2015-04-11 18:02:45 -04:00
Cole Robinson a2c7d62ec4 guest: Disable spice image compression for local VMs
The image compression setting has a noticably detrimental effect on
spice graphics quality. It's meant to be used for spice VDI but the
vast majority of people don't use spice in a way that makes bandwidth
usage matter.

Boxes has already done this for a while as well:

https://mail.gnome.org/archives/commits-list/2013-March/msg14904.html

Turn it off by default if creating the VM on a local connection.
2015-04-11 17:53:17 -04:00
Cole Robinson e9495110ca connection: Refresh XML for every libvirt object event
We tried to split up status vs XML refreshing, but they are tied together
in various ways (like the runtime XML changes when a VM starts). This
was breaking console connecting when starting a VM
2015-04-11 17:24:30 -04:00
Cole Robinson 20d37422fe virt-install: Fill in a bunch of --graphics spice options (bz 1110017) 2015-04-11 16:56:27 -04:00
Cole Robinson 9a789c19e2 virt-install: Support --hostdev scsi passthrough (bz 1054912)
Pass it a type=scsi nodedev name, and we will set things up correctly.
2015-04-11 15:55:09 -04:00
Cole Robinson 630a80de62 storagelist: Fix sorting by size 2015-04-11 15:08:07 -04:00
Cole Robinson 9d99b8caab createvol: Don't cap capacity to host space (bz 1118706)
Only cap allocation, since we can overcommit with sparse images.
2015-04-11 14:56:23 -04:00
Cole Robinson d7a7d00e9e engine: Don't raise conn poll errors if only systray visible (bz 1082685) 2015-04-11 14:41:02 -04:00
Cole Robinson f7b05912f0 engine: Before launching any error, try to find a parent dialog 2015-04-11 14:39:52 -04:00
Cole Robinson 0b47635676 vmmenu: Fix updating submenu state 2015-04-11 14:14:24 -04:00
Cole Robinson 9a1fc63c89 manager: Disable 'force reset' if HV doesn't support it (bz 1078731) 2015-04-11 14:01:45 -04:00
Cole Robinson 839ce682b1 Drop support for non-managed save/restore
All major drivers either support it, or don't support save at all,
so I think we can safely drop it. If people still need it they can
get by with virsh.
2015-04-11 13:52:48 -04:00
Cole Robinson 3d2afbaf6f connection: Allow setting a custom 'pretty name' (bz 784701)
We've had multiple requests over the years for something similar. People
might have to connect to multiple IP addresses, or really large hostnames,
that become difficult to distinguish in the UI.

Add a field in the host details page that allows setting a custom name,
and store it in gsettings.
2015-04-11 13:39:25 -04:00
Cole Robinson 4781ad6cd6 connection: Simplify manager row 'pretty name' handling
Unify all the callers, and use some UI ellipsizing to handle
crazy long hostnames.

This drops the conn name collision prevention stuff which can be
useful when you have lots of similar connection names. But upcoming
patches will make it mostly redundant.
2015-04-11 12:57:32 -04:00
Cole Robinson fc171fc31d connection: Bunch of minor tweaks handling TCP URIs 2015-04-11 12:08:57 -04:00
Cole Robinson ee9aa0ef11 host: Don't trigger selection callbacks when conn is closing
We already do this for storage, make sure we do it for iface + net
as well.
2015-04-11 11:40:47 -04:00
Cole Robinson 8c107f87f9 host: Remove some redudant conn details
And some minor UI spacing fixes
2015-04-11 11:29:03 -04:00
Cole Robinson 7c3f9dfcc2 spec: Don't install GConf conversion script
We have shipped several releases of RPMs that use gsettings. People
have already rebuilt their settings by hand. Installing the conversion
script could overwrite their latest bits with old gconf bits (this
happened to me).
2015-04-11 11:14:04 -04:00
Cole Robinson 20cd7f86ca domain: Remove manual_reboot
qemu has provided this feature for a long time, and every other driver
we care about provides a reboot implementation as well, so drop our
handling of it.
2015-04-11 11:13:05 -04:00
Cole Robinson 413c290bfe create: Renamed 'advanced options' to 'network selection'
Since that's all it contains now
2015-04-10 18:44:16 -04:00
Cole Robinson 8f563cbae8 storagelist: Simplify Ui a bit
Drop the bold and overly sized text. Drop the name duplication.
Drop the type field since it's shown in the pool list.
2015-04-10 18:40:54 -04:00
Cole Robinson 6d06425f3d icons: Add button sized variants for VM status
Since gtk doesn't scale anymore, these were looking a bit funky in
the host details window.
2015-04-10 18:34:43 -04:00
Cole Robinson 705daf6db9 storagelist: Fix refresh button sensitivity 2015-04-10 18:20:13 -04:00
Cole Robinson 87098d1273 storagepool: Refresh volumes on state change
Otherwise the UI list is out of date
2015-04-10 18:17:29 -04:00
Cole Robinson a0075beab4 libvirtobject: Minor tweaks to ensure we cache domain bits correctly 2015-04-10 18:03:56 -04:00
Cole Robinson 42648f45f0 libvirtobject: Clean up XML invalidation
Make sure we aren't invalidating things when we are using events. Don't
overload APIs so much.
2015-04-10 17:50:06 -04:00
Cole Robinson a7a19b2abc libvirtobject: Drop redefine_cached
There's no external callers anymore, and the prospect of keeping this
stuff cached but potentially having a thread invalidate it makes me nervous,
so simplify things by making callers explicitly request the object they
want to redefine.
2015-04-10 17:23:11 -04:00
Cole Robinson 1552cb257e domain: Make device XML editing similar to guest XML editing 2015-04-10 17:15:07 -04:00
Cole Robinson 2c9adb18bc storagelist: Fix backtrace on connection close 2015-04-10 16:53:19 -04:00
Cole Robinson d0ffd954cd connection: Unify initial object refresh handling
Have libvirtobjects advertise a routine specifically for initial setup,
and emit a signal when it's complete. Then dispatch the associated conn
signal on demand as the objects are initialized. This should avoid a
whole class of ordering issues, and is easier to follow IMO.
2015-04-10 15:00:42 -04:00
Cole Robinson 629627b663 connection: Drop unused open() argument 2015-04-10 15:00:34 -04:00
Cole Robinson 6071ab0ea4 uiutil: Clarify a few ambiguous function names 2015-04-10 15:00:34 -04:00
Cole Robinson 49e3ea2cdf host: Make sure first object selected when conn connects
Previously it was dictated by what order we received conn
signals in.
2015-04-10 15:00:34 -04:00
Cole Robinson 838baf6946 connection: tick: Operate on combined object lists
Makes the flow a bit simpler, and allows us to break out polling without
having to pass around a ton of lists.
2015-04-10 15:00:34 -04:00
Cole Robinson 5357b91402 connection: Store all object lists in an external class
Simplifies list management and allows us to use real locking to prevent
list collisions.
2015-04-10 15:00:34 -04:00
Cole Robinson 2d25c920ea connection: Use consistent nodedev function names 2015-04-10 15:00:34 -04:00
Cole Robinson 3df02e8ee1 host: Fix a couple recently introduced issues 2015-04-10 15:00:34 -04:00
Cole Robinson cb5d075f50 libvirtobject: Unify a few APIs and conn tick handling 2015-04-10 15:00:34 -04:00