b746d919a9
virt-install: Add --install kernel_args=X,kernel_args_overwrite=yes|no
...
--install kernel_args=X acts like --extra-args. If
kernel_args_overwrite=yes is also specified, it overwrites whatever
default kernel args we would have used for the install method.
2019-06-13 14:00:04 -04:00
b50ecd2bf1
installer: Move location_* conflict validation to treemedia
...
That's where the values are handled, so move it there
2019-06-13 14:00:04 -04:00
69d5e62cbb
tests: Add an example of --extra-args with post install --boot cmdline=X
2019-06-13 14:00:04 -04:00
d85a9a4808
cli: Advertise --boot cmdline, that's the XML naming
2019-06-13 14:00:04 -04:00
216b1f2a2d
installer: Reject --unattended method=cdrom on remote connection
...
It's not wired up yet
2019-06-13 14:00:04 -04:00
69c20d5256
installer: install_{kernel,initrd} imply an install phase
2019-06-13 14:00:04 -04:00
b4cc9c7cea
uitests: Fix prefs XML editor flakeyness
2019-06-13 13:50:52 -04:00
2266b650a5
preferences: Disable XML editing by default
...
This adds a field in gsettings and preferences UI to enable
XML editing. It's off by default. The XML tab page is still visible,
but the textview is not editable, and there's a warning at the top:
XML editing is disabled in 'Preferences'.
Only enable it if you know what you are doing.
When the setting is enabled, the warning goes away and the textview
is editable. This puts a roadblock up for people that don't know what
they are doing, but still advertises the feature and keeps the
UI surface difference fairly small between on/off states.
2019-06-13 07:17:34 -04:00
2a1cf411dd
tests: Add XML editing UI tests
2019-06-13 07:17:34 -04:00
a5f4033493
details: add xmleditor UI
...
Handling this is a bit different from other bits, because:
1) the <device> editing paradigm is unique. We need to replace the
device in line in the XML which is a new operation
2) the New VM customize pattern is tricky and needs lots of
special handling
2019-06-13 07:15:46 -04:00
df80852952
addhardware: add xmleditor UI
2019-06-13 07:15:46 -04:00
0937c1e54b
createvol: add xmleditor UI
2019-06-13 07:15:46 -04:00
68b3cb16e5
createpool: add xmleditor UI
2019-06-13 07:15:46 -04:00
50d13d8c12
storagelist: add xmleditor UI
2019-06-13 07:15:46 -04:00
7d9d8d9237
createnet: add xmleditor UI
2019-06-13 07:15:46 -04:00
5f4510b4df
hostnets: add xmleditor UI
2019-06-13 07:13:43 -04:00
18af72212b
xmleditor: Add the shared code
...
The XML editor ui is a two tabbed notebook, one 'Details' tab
and one 'XML' tab. The latter has a gtksourceview and allows editing
the raw libvirt XML for whatever the selected object is.
API users will programmatically insert the xmleditor notebook into
their UI, with the existing UI under the details tab.
2019-06-13 07:13:43 -04:00
c88e492331
guest: Enable qemu-ga by default on s390x
...
It was disabled with commit 2aca20141e
2019-06-13 09:16:45 +02:00
1f4a5a1b43
cli: Add --install bootdev=X,kernel=X,initrd=Z
...
This is the beginning of a big --install option, which will be used
for tweaking less common elements of the install process
2019-06-11 17:55:09 -04:00
a4a577bd23
tests: Finish off installer and kernelupload coverage
2019-06-11 17:55:09 -04:00
436c471b15
virt-install: Drop the serial extra_args warnings
...
There's been multiple reports that these aren't really valid nowadays.
systemd is smart enough to make this work automagically. So just drop
it
2019-06-11 17:55:09 -04:00
de90716eb4
unattended: Choose a default profile name if none specified
...
We default to 'desktop' if none specified, otherwise we choose the
first alphabetical profile available. Make bare '--unattended' a
valid option
2019-06-11 17:55:09 -04:00
ecb60c3062
Drop use of logging.info
...
Just use logging.debug in these random places
2019-06-11 17:55:09 -04:00
034d112181
unattended: Finish off code coverage testing
2019-06-11 17:55:09 -04:00
13b3790829
virt-install: Print when we set default memory and disk
...
Since we never defaulted here before, print out the values we are
setting. Users can see right away if they actually want those values
or not.
2019-06-11 17:55:09 -04:00
cb0e37786f
tests: clitest: More infrastructure to skip default arguments
...
To allow testing virt-install without default --ram added for example
2019-06-11 17:55:09 -04:00
b3e6ebe28b
virt-install: Generate default --name
...
This uses the same logic as virt-manager. The name is mostly
derived from --os-variant naming, but we have fallback defaults too.
Print the name to stdout so users are informed about what we are
doing.
2019-06-11 17:55:05 -04:00
078348fbbf
create: move generate_name to Guest
...
This will be used by virt-install.
Tweak the logic a bit to not have 'generic' in the name
2019-06-11 17:54:45 -04:00
387614c641
generatename: Move libvirt collision handling to callers
...
Make every caller pass an explicit cb that handles libvirt
collision processing. Makes it easier to see exactly what is going
on at the call impls
2019-06-11 17:54:45 -04:00
4cdf2e4a78
generatename: Remove collidelist
...
Fold it in to the callback of the single remaining user
2019-06-11 17:54:45 -04:00
47a6f3a6d5
storage: Handle guest collision checking
...
This pattern is already used in two places. Formalize and centralize
it
2019-06-11 17:54:45 -04:00
58dfe05344
virtManager: Remove some unnecessary generatename collidelist usage
...
The libvirt callbacks will handle this for us already
2019-06-11 17:54:45 -04:00
6e6a0b8a6a
connection: Use shared default pool lookup logic
...
It wasn't abiding a different pool name pointing to our default
path
2019-06-11 17:54:45 -04:00
088657a2b8
storage: Kill get_default_dir
...
The last location is in virt-convert, which has weird local directory
creation semantics. Just have it use storage APIs like we do
everywhere else
2019-06-11 17:54:45 -04:00
e27202d178
createpool: Use StoragePool.default_target_path
...
Indirectly, rather than the less useful get_default_dir
2019-06-11 17:54:45 -04:00
abb4719cee
addstorage: Drop non-storagepool fallback code
...
This isn't tested, and the usecase will error later anyways when
we attempt to create storage.
2019-06-11 17:54:45 -04:00
8bfa04c230
storage: Split apart build_default_pool, and document it
2019-06-11 17:54:45 -04:00
01a07a1051
virt-install: Share required option logic for resources
...
There's some cases we were incorrectly setting osinfo defaults, when
mem or storage values had already been specified elsewhere
2019-06-11 17:54:45 -04:00
66fe00ddee
guest: Don't hardcode vcpus = 1
...
libvirt has set this as the default forever, we don't need to set it
2019-06-11 17:54:42 -04:00
17d157820f
guest: move libosinfo resource setting to virt-install
...
This puts all the default resource setting in one place, and the
only place that was depending on it, as virt-manager explicitly sets
the values on its own. This will be used in future patches to add
more default setup and report the values to the user
2019-06-11 17:51:25 -04:00
db4d348950
domain: cpu: Rework vcpus setting slightly
...
Move it to Guest, where we have a more hollistic view of the issues.
This will be needed in later patches
2019-06-11 17:51:25 -04:00
e859d17e1a
tests: Add an unattended netinst test case
2019-06-11 17:51:25 -04:00
cc366fff7d
cli: Add more code coverage
2019-06-11 17:51:25 -04:00
75101ce27b
tests: clitest: Remove some redundant argcomplete tests
2019-06-11 17:51:25 -04:00
c33eb562c2
devices: graphics: Test remaining code coverage
2019-06-11 17:51:25 -04:00
b0b3ba4e1c
devices: interface: Test remaining code coverage
2019-06-11 17:51:25 -04:00
f056798918
virtinst: Add a bunch of # pragma: no cover
2019-06-11 17:51:25 -04:00
ffcf713e06
cli: Drop warnings about video accel3d
...
Libvirt has provided explicit errors here for a while
2019-06-11 17:51:25 -04:00
203c0d4a6c
virt-install: Call install.get_search_paths
...
Similar to what we do via create.py
2019-06-11 17:51:25 -04:00
b7465fdcf8
installertreemedia: Move url() to is_network_url()
...
And then have callers just access location. It's more clear IMO
2019-06-11 17:51:25 -04:00
Cole Robinson