Commit Graph

4308 Commits

Author SHA1 Message Date
Cole Robinson 82e9684fa6 urlfetcher: Make debian treearch checking more generic
Use regex parsing rather than a whitelist
2015-03-27 13:06:26 -04:00
Mauricio Faria de Oliveira 0dc334fa58 Add ppc64el support for 'virt-install --location' (Debian/Ubuntu)
The installation of Debian/Ubuntu for ppc64el (a.k.a. ppc64le on Fedora/RHEL)
fails with 'virt-install --location', as the arch dir and kernel filename
are not correct for this arch/distros.

This patch fixes it by adding checks for 'treeArch' and 'hvm_kernel_paths'.

Signed-off-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
2015-03-27 12:30:04 -04:00
Cole Robinson e7666390ff test_inject: Add Fedora 22 URL 2015-03-26 19:37:17 -04:00
Cole Robinson ba95aa91e6 test_urls: Update fedora URLs 2015-03-26 19:28:53 -04:00
Dustin C. Hatch 7acbdd9bf3 preferences: Correct usbredir preference values
All of the gsettings values of the "prefs-add-spice-usbredir" combo box
result in the preference being set to true, causing all new VMs to have
USB redirection added. This commit corrects the value of the "No" row to
correctly disable the setting when selected.

Signed-off-by: Dustin C. Hatch <dustin@hatch.name>
2015-03-26 19:16:33 -04:00
Cole Robinson 606069b1f4 manager: Use case-insensitive sort for VM names (bz 1155227) 2015-03-26 19:13:29 -04:00
Cole Robinson b4a7c5e67d virt-manager: Refresh pools after VM/storage is created (bz 1146282)
After the caching changes over the past year, virt-manager's internal state
isn't accurate when virtinst creates new disk storage.

Manually update the pools at the two virtinst entry points: create.py and
addhardware.py
2015-03-26 19:08:04 -04:00
Cole Robinson 6a24eb9d30 createnet: Remove unused module 2015-03-26 18:05:38 -04:00
Cole Robinson e125aa69d8 nodedev: Handle busted 'system' XML
Libvirt can generated invalid XML for the system nodedev device:

https://bugzilla.redhat.com/show_bug.cgi?id=1184131

This hits at least two people, so catch this specific case, but the
real fix is libvirt not outputing busted XML.
2015-03-26 18:04:23 -04:00
Cole Robinson af562320a5 createnet: Drop incorrect domain name validation (bz 1195873)
Just let libvirt error if something is wrong
2015-03-26 17:11:23 -04:00
Cole Robinson dc1737e623 cpu: Drop vendor and features if setting host-model (bz 1190851)
Otherwise via virt-manager we can try to set a <cpu> with a <vendor>
but no <model>, and libvirt complains.
2015-03-26 17:08:15 -04:00
Cole Robinson 2c9d2a2360 virt-install: Don't print virsh command if VM is running (bz 1180558) 2015-03-26 16:43:28 -04:00
Cole Robinson 2f2ab1438f man: Use F21 URL for --location example (bz 1172818)
Because newer fedora has a different URL format
2015-03-26 16:18:25 -04:00
Cole Robinson 87c5094745 details: Don't access console.viewer directly
Add accessors for everything details.py needs. Makes separation clearer
2015-03-26 13:16:50 -04:00
Cole Robinson 26abb5a2b5 console: Drop _has_property
All these checks are redundant with modern deps
2015-03-26 13:10:38 -04:00
Giuseppe Scrivano 0aa200604a addhardware: default to an existing bus when adding a new disk
When a new disk is added, by default choose a bus that is already used
by an existing disk, if any.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1206097

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-26 15:25:16 +01:00
Cole Robinson 7866e291f6 guest: Never use vmvga if host is RHEL (bz 1147662)
We basically need to do this independent of whether the build is configured
for RHEL defaults or not
2015-03-25 09:04:51 -04:00
Cole Robinson af2aea8bbc tests: xmlconfig: Drop needless version limiting 2015-03-25 08:58:09 -04:00
Cole Robinson 4224772852 netlist: Streamline bridge and macvtap labels (bz 1147660) 2015-03-25 08:47:21 -04:00
Marc Deslauriers 8574eedd2e virt-manager: Don't clear all page visibilities during initialization
Since commit dfa23765, page_changed() sets page visibilities based on the
value of the newpage parameter. Calling the function without it being set
makes all pages invisible at once during initialization, resulting in a
weird scenario which prevents the window from getting proper focus events
when another window partially overlaps it, resulting in stuck grabs.
Message-Id: <55114787.6070401@canonical.com>
2015-03-24 12:36:16 -04:00
Cole Robinson cfe9e7dc7e virt-install: Make '--cpu none' work with aarch64 2015-03-23 17:46:09 -04:00
Cole Robinson 08a72a4aec connection: Clean up stable_defaults, improve test coverage 2015-03-23 16:49:32 -04:00
Cole Robinson 2a31ff0248 guest: Perform stable_defaults check using our emulator
Not passing an emulator is only for showing ideal defaults in the UI.
When doing internal checks, we only want to disable features if we know
the emulator doesn't support them.
2015-03-23 16:49:32 -04:00
Cole Robinson 590e4772eb connection: Fix error checking stable_defaults
This should fail when run against actual RHEL capabilities output
2015-03-23 16:39:49 -04:00
Cole Robinson 0273ee2fac tests: Move some test suite hacks into the code, increase coverage 2015-03-23 16:25:31 -04:00
Cole Robinson 8220e4c60f virtinst: Drop unused stable_defaults field 2015-03-23 16:17:07 -04:00
Cole Robinson 7a1b7b69e3 Drop non-ascii text from files
Seems to be tripping up coverage output on f22
2015-03-23 15:56:55 -04:00
Cole Robinson c6481f6c5d cli: Drop needless assignment that confuses pylint 2015-03-23 14:03:52 -04:00
Cole Robinson e1678df8f2 virt-convert: Make --printxml imply --noautoconsole
Makes test suite work regardless of whether virt-viewer is installed
2015-03-23 13:37:24 -04:00
Pavel Hrdina 1689677482 virtinst/cli: don't use hard-coded path for binaries
The binaries could be installed somewhere else and we should not
hard-code the binary paths.  This patch allows non-root user to build
their own virt-viewer/virsh, set the PATH env and run virt-manager
tests.

(crobinso: Fix check_output args, alphabetize imports)

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Message-Id: <ddf77f9519da580c8d5f3df0f56bdb36d5c000fa.1427117670.git.phrdina@redhat.com>
2015-03-23 13:31:49 -04:00
Chen Hanxiao 101ca3cef8 details: change duplicated short-key 'd' to 'e' on Overview tab
add hardware also use 'd' as its short-key.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-03-16 21:26:47 -04:00
Giuseppe Scrivano 61e06856a3 virt-manager: Allow to change SGIO with LUN disk devices
It is added only in the details window, and intentionally not added to
the addhardware UI to keep it simpler.  Users can edit this after a
new device is added.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-16 20:32:40 +01:00
Giuseppe Scrivano 31836e2b5d virtinst: add support for <disk> sgio attribute
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-16 20:32:40 +01:00
Giuseppe Scrivano ef286321f9 Fix an exception while a XEN domain is shutting-down
I've noticed twice today that 'guestcpus' was set to 0 while the
domain was shutting down.  Play safe and check that 'guestcpus' is > 0
before divide by it.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-26 11:08:57 +01:00
Giuseppe Scrivano 64264e8fa2 Disable domain events with XEN
When XEN is used, disable domain events and use polling.

On RHEL-5.9 virDomainInfo() seems to not report correctly the domain
status when called immediately after the event is received.

Solves: https://bugzilla.redhat.com/show_bug.cgi?id=1177207

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-26 11:08:57 +01:00
Giuseppe Scrivano 478ba6d885 Use virtio-net only when it is supported
Do not use the model specified by the OS if it is "virtio-net" and
virtionet is not supported.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1177113

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-25 15:32:54 +01:00
Giuseppe Scrivano 00aea929ef tests: check that vmvga is not used on RHEL
And fix typo in last commit

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-24 19:03:59 +01:00
Giuseppe Scrivano 6c61e66ff7 Do not use vmvga on RHEL
Fallback to VGA

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1179652

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-24 17:44:23 +01:00
Giuseppe Scrivano 7b630c00a0 Move stable_defaults from vmmConnection to VirtualConnection
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-24 17:44:23 +01:00
Cole Robinson 72324a8575 spec: Add pygobject3-base dep for virt-install (bz 1195794) 2015-02-24 11:23:46 -05:00
Giuseppe Scrivano 24e489e88a man: replace "--boot bootmenu=on" with "--boot menu=on"
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1192768

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-02-24 14:19:00 +01:00
Cole Robinson 9a5da6972a Remove test-autobuild support
I don't think anything is actually using it these days, and upstream
autobuild development seems dead. If someone is still using it, we
can revert this commit.
2015-02-22 11:32:02 -05:00
Cole Robinson 0befc54abe details: Handle libvirt reporting multiple firmware paths 2015-02-22 11:19:50 -05:00
Cole Robinson 4ee9fdf944 domcapabilities: Get arch from caps XML 2015-02-22 11:13:59 -05:00
Cole Robinson a5b3e2adab create: Try to default to UEFI for aarch64
If we detect AAVMF, set it up, and allow all install options.
If we don't find AAVMF, disable all options except import install (the
current behavior) and show a warning.
2015-02-22 10:25:51 -05:00
Cole Robinson 0ddec9199b details: Don't allow changing machine type for existing VM
But still allow it from the customize dialog. It's one of those things
that rarely can be changed for a working VM and things continue to work.
2015-02-22 10:25:51 -05:00
Cole Robinson c7c772b200 virt-install: Default to --boot uefi
Try to use --boot uefi if the user hasn't already specified loader params,
or a kernel to boot. If we can't determine a UEFI setup, just print a
warning.
2015-02-22 10:25:51 -05:00
Cole Robinson a04307cd70 virt-install: Add --boot uefi
Will enable UEFI if we know libvirt + hypervisor support it, and libvirt
is advertising a suitable UEFI binary.
2015-02-22 10:25:47 -05:00
Cole Robinson 760465fd2b support: Rename variable for easier debugging 2015-02-22 10:25:47 -05:00
Cole Robinson 4efc814d7f connection: Add domain caps handling for fake URIs
Allows us to pass in custom domcaps content for testing purposes
2015-02-22 10:25:47 -05:00