If we specify cpu model and apply once, we could not specify empty
cpu model again with following error.
"Error changing VM configuration: internal error Non-empty feature
list specified without CPU model"
That is not useful to restore default cpu model.
This patch fixes above issue.
Signed-off-by: Ken ICHIKAWA <ichikawa.ken@jp.fujitsu.com>
(crobinso: minor cleanup, add Ken to AUTHORS)
If users accidentally add whitespace to the beginning or end of a hostname their connection will fail, so strip it.
Fixes BZ 818438 - Whitespace in remote connection hostname field is not trimmed
(crobinso: Add Dave to AUTHORS)
As discussed in:
https://www.redhat.com/archives/virt-tools-list/2013-February/msg00154.html
There is a bug when creating disk image as qcow2, enable
fully allocating but get the minimal sparse image.
We should give users a notification which describing this.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
(crobinso: tweak message a bit)
virt-install already supports relabeling, but virt-manager doesn't and
in some cases, this can cause problems, for example when switching to
dynamic labeling with the relabeling turned off. I took the approach
of allowing the user to choose, with safe fallbacks to defaults.
Deals also with this:
https://bugzilla.redhat.com/show_bug.cgi?id=907390
We need to move the icon_theme lookup to after the fork. My guess is
that the looku ints inits some internal gtk dbus state which is then
no longer valid after we fork.
As a result of CVE-2011-4127, libvirt disabled generic SCSI
commands passed through to the underlying disk by qemu
from a guest to a virtio disk when device type is "disk"
afer commit 177db087757e4adb02c211de56336a5991c8eb20.
And libvirt introduce a new device type "lun"
to allow SG_IO commands passing through.
This patch allows VM admin to configure this via virt-manager.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
This patch will add virtio-scsi bus option on "Add New Virtual
Hardware" GUI page. It will support users to add a virtual disk
using SCSI bus with a controller model virtio-scsi.
If there is no SCSI controller existed, a new SCSI controller by
model 'virtio-scsi' will be added automatically.
Signed-off-by: ChenHanxiao <chenhanxiao@cn.fujitsu.com>
(crobinso: add Chen to AUTHORS, some cosmetic tweaks)
This patch changes the default checkbox-state of "Delete all
associated storage" to be checked, but adds a prompt with a warning
for users to be sure they notice this change and they know what they
are doing (hopefully).
(crobinso: confirm even if no gconf schema available, cosmetic spacing
fixup, add Martin to AUTHORS)
One of previous patches (96ce9ac0b1) invented this feature. However,
in options object it is called testfirstrun not test_first_run.
This produces a runtime error.
(crobinso: add Michal to AUTHORS)
Since 0.9.10 libvirt supports editing a domain's metadata using the
SetMetadata API. Using that API the description of a domain can be
edited as it is running.
Make virt-manager edit the description of a domain using SetMetadata
when available.
(crobinso: Add Markus to AUTHORS)
Hello,
Commit 68e78244e8 changed the HV_PACKAGES
variable to KVM_PACKAGES in src/virt-manager.py.in, but the
corresponding change was never made to src/Makefile.am.
Here is a patch to correct the issue.
Thanks,
Marc.
commit 93ba787355736733c189e6809b9108a70f0e02d4
Author: Marc Deslauriers <marc.deslauriers@ubuntu.com>
Date: Wed Aug 22 13:21:48 2012 -0400
Fix incorrect substitution variable
This is what vinagre and virt-viewer do, and what gtkvnc enables by default.
It has some weird symantics, namely that moving the mouse over the viewer
means alt-tab is only received by the guest. But it's the common mode
of operation, so let's be consistent.
Cole Robinson