Some ARM bits we are about to add would substantially complicate the
current setup, so move all the logic into guest.py where we can be
more flexible. I think this is closer to what libosinfo will give us
as well.
This is option is supposed to turn off Auto USB redirection feature
rather than USB redirection support. So adding 'auto' make it clearer.
And add its docs to manpage.
Some callbacks could try to access a domain that was just deleted and
not accessible anymore. Detect these cases and don't propagate the
exception.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
When a new volume is created for a storage, automatically select it;
most likely it is what the user will choose to use.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
(crobinso: util is gone now, replace with uihelpers)
It fixes this error:
Traceback (most recent call last):
File "virt-manager/virtManager/host.py", line 973, in copy_vol_path
clipboard.set_text(target_path)
File "/usr/lib/python2.7/site-packages/gi/types.py", line 113, in function
return info.invoke(*args, **kwargs)
TypeError: set_text() takes exactly 3 arguments (2 given)
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
It fixes this error:
Traceback (most recent call last):
File "virt-manager/virtManager/storagebrowse.py", line 271, in pool_selected
pool = self.current_pool()
File "virt-manager/virtManager/storagebrowse.py", line 238, in current_pool
return self.conn.get_pool(row[0])
File "virt-manager/virtManager/connection.py", line 645, in get_pool
return self.pools[uuid]
KeyError: 'bd9fd5ec-a35c-d84a-b9b2-2aca98f733c3'
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Set the connection used by vmmCreateVolume everytime the window is made
visible. This fixes a case where volumes could be added to the wrong
pool if the same vmmCreateVolume window was already used on a different
connection.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
The commit b044dd renamed vmmStoragePool.uuid to vmmStoragePool._uuid,
causing this error:
Traceback (most recent call last):
File "virtManager/storagebrowse.py", line 280, in refresh_current_pool
self.refresh_storage_pool(None, cp.get_uuid())
File "virtManager/storagebrowse.py", line 243, in refresh_storage_pool
if curpool.uuid != uuid:
AttributeError: 'vmmStoragePool' object has no attribute 'uuid'
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
_close_serial_tab triggers the switch-page event and that can provoke a
refresh of the window. This causes an error everytime the details window
is pointing to a domain that was just deleted.
Solves: https://bugzilla.redhat.com/show_bug.cgi?id=985291
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
- Unify looking up osdict values
- Have Guest.py pass in its defaults, not encoding them in osdict
- Explicitly specify every device parameter that osdict handles, rather
than have some psuedo magic dictionary format to handle it
Once upon a time solaris entries has typename="unix", but were moved to
typename="solaris". We maintained a link to the unix type for back compat,
but now the distinction doesn't matter at all, so drop it.
Cole Robinson