Last commit changing the default was de1695b2, but there was still one
place in man page left and the spec file was left dirty. This is
hopefully the last vnc->spice patch
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Kind of a maintenance pain, and it's just poorly duplicating info
from the git logs. We could autogenerate this but I don't really
have the interest in figuring it out. Patches welcome :)
The only bits were were using was the icon installation and
translation building, which amounted to about 70 lines of code.
Just steal it so we can avoid the dep which will cause trouble
for future RHEL.
Was originally added with hopes for being used in an ovirt related
product, but was more or less a code dump, and the author has been
allocated to other things. He confirmed it's okay to remove.
That, and it's currently broken, and we've had approximately 0 user
feedback since it was committed.
This unfortunately has a decent amount of fallout: add a wrapper class
in config.py that reduces much of the churn.
Another big piece is that gsettings can't accept arbitrary paths like
gconf would, everything needs to be described in the schema.
Also do a bunch more RPM spec modernizing
This is a "sanity" patch so that the version on the rpm
and the version at runtime are the same.
This patch depends on the patch which processes the spec.in
file into the spec file, the patch which adds pkgversion to
configure, and the snapshot patch.
.
Signed-off-by: Gene Czarcinski <gene@czarc.net>
This update renames virt-manager.spec to be
virt-manager.spec.in and changes the version-id to
@VERSION@ ... setup.py is modified to copy the
virt-manager-spec.in file to virt-manager.spec and
replace @VERSION@ with the current/actual version id.
.gitignore is updated to ignore virt-manager.spec
.
Signed-off-by: Gene Czarcinski <gene@czarc.net>
Despite being a known quantity, autotools is so overkill for our needs,
so let's drop it and replace it with a much simpler and easy to customize
system.
Switch over to use GObject introspection bindings for all python
modules related to GObject/GTK3/etc. It is not possible to mix
and match old pyggtk/pygobject manual bindings with new introspection
based bindings so it must be all changed in one go.
Imports like
import gtk
Change to
from gi.repository import Gtk
The vmmGObject class is changed to always inherit from GObject.GObject
There is no compelling reason to avoid a GObject dep for the
virt-manager TUI & it horribly messed up the code.
Signal declarations are changed from
vmmChooseCD.signal_new(vmmChooseCD, "cdrom-chosen", [object, str])
To
__gsignals__ = {
"cdrom-chosen": (GObject.SignalFlags.RUN_FIRST, None, [object, str])
}
which is required by new GObject bindings
Most of the rest of the change is simply dealing with renamed
constants / classes.
Alot of legacy compat code was removed - ie helpers which
check to see if certain GTK2 methods are available are no
longer required since we're mandating GTK3 only.
The event loop is replaced with LibvirtGLib's event loop.
Still todo
- Rip out all DBus stuff & make vmmEngine class inherit GtkApplication
which provides unique support & DBus method handling
- Switch to use LibvirtGConfig & LibvirtGObject for libvirt interaction
- Possibly switch to Python 3 too ?
- Figure out why GNOME keyring is missing Introspection support
My suggestion is that the standalone GIT repo for virt-install
only live on as a support branch for legacy platforms.
A stable-0.9 branch of virt-manager can be kept for legacy PyGtk2
based virt-manager releases.
The virt-manager master branch should exclusively use GObject
inspection and ideally Python3 and contain both the virt-manager
and virt-install codebases in one since they are intimately
related to each other & using separate GIT repos has needlessly
complicated life for everyone.
crobinso:
Some locking fixes
Misc cleanups and dropping now-useless code
Fix dbus usage
Fix graph cell renderer regression
Fix a couple tooltip issues
Cole Robinson