In commit 53796fc4, bitbake fails at parsing. It slipped through,
as I did not invoke any testing before submitting 53796fc4. This
commit resolves the obvious shortcoming.
The description is not indented after line breaks. All other
information, i.e., the dependencies and SRCURI, are indented with
four spaces after line breaks. Shell scripts are indented with
multiples of four spaces.
In recipes-ros, I located and checked for tabulators and spacing
with these bash commands:
egrep '^ [^ ]+' . --exclude *.patch -R
egrep '^ [^ ]+' . --exclude *.patch -R
egrep '^ [^ ]+' . --exclude *.patch -R
egrep '^ [ ]+[^ ]+' . --exclude *.patch -R
While going through the recipes and manually improving the layout,
I also adjusted the descriptions to use maximal 100 characters
per line.
After running oe-stylize.py on all recipes in recipes-ros, this
commit improves the formatting of some recipes.
To achieve this, I executed these commands in recipes-ros:
find . -name *.bb | sed 's#\(.*\)#./oe-stylize.py \1 > \1_sanitized#' | sh
find . -name *.bb | sed 's#\(.*\)#diff -Naur \1 \1_sanitized#' | sh > diffs
Then, I manually inspected the diffs file, and improved the
recipes.
For the DESCRIPTION line in the addressed recipes, the line width
of 100 characters was chosen, as the LIC_FILES_CHKSUM line and
SRC_URI line usually are also around about 100 characters long.
Hence, choosing a shorter line width, e.g. 80 characters, would
have only created more line breaks, but not reduced the need to
use a file viewer with which 100 characters line width can be
displayed. For the github file and diff viewer and most editors
on reasonably-sized screens, 100 character line width is no
problem.
In the commit 21f7799ee9, I manually
modified the patch, but it slipped my eyes to adjust the line
information in the patch accordingly.
This commit corrects the line information, so that the patch can
now be applied correctly.
When CATKIN_ENABLE_TESTING is deactivated, the ROS packages do not
require the rostest package.
This commit includes a number of patches to be submitted in the
upstream repositories and removes the rostest dependencies from
the recipes.
The native packages are not required anymore, because the needed
python scripts during compile time are also provided by the
cross-compiled packages and the python scripts are platform
independent. Only the catkin package is provided as native package.
The ros-comm recipes are updated to 1.9.48 to be in line with
4551e7c32d/hydro/release.yaml.
The previously applied patches have been included in 1.9.48 and are
removed from the recipe and this repository.
When updating from 1.9.41 to 1.9.47, the commit
c5dfa6305e
adds a routine in the CMakeLists.txt to find the pthread library.
This routine is not suitable for the use with our tool chain, i.e.,
it reports an error (cf. #125) when using roscpp-native.
This commit adds a patch that reverts that change in roscpp's
CMakeLists.txt.
The rostest package requires that the rostest executable can be
found by cmake's find during configure. Hence, rostest depends on
rostest-native.
To implement this, rostest and rostest-native are defined with
different dependencies.
This commit resolves issue #83.
| CMake Warning at /build/v2012.12/build/tmp-angstrom_v2012_12-eglibc/sysroots/x86_64-linux/usr/share/catkin/cmake/test/nosetests.cmake:90 (message):
| nosetests not found, Python tests can not be run (try installing package
| 'python-nose')
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
The topic-tools fails during the do_compile step at:
.../sysroots/x86_64-linux/usr/lib/libboost_thread-mt.so: could not read symbols: File in wrong format
The failure comes from the rostest-native package which delivers a
header file with boost dependencies and therefore add the relevant
library to the link path. Add rostest to the DEPENDS to use the
header and libraries from the cross sysroot and keep the native
rostest for the binary.
Fixed#51
Signed-off-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
For starting roscore, it requires a number of runtime dependencies.
At the moment, all runtime dependencies, even recursive runtime dependencies,
are added only in the roslaunch recipe. Hence, the recipe contains all
runtime dependencies.
At a later stage, one should move the recursive runtime dependencies into
the appropriate recipes.
Rostest depends on its own package and therefore needs to search
in the devel space for the rostestConfig.cmake during native
build.
| CMake Error at /.../usr/share/catkin/cmake/find_program_required.cmake:5 (message):
| rostest not found
|
Signed-off-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
All ROS packages with install tools in the bin directory or install
python code with is used by other packages should be used as native
version. Adapte the DEPENDS accordingly.
Signed-off-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
Lukas Bulwahn