Commit Graph

30191 Commits

Author SHA1 Message Date
Chih-Hung Hsieh 4354a33874 Add option to dump HTML warnings per project.
* Use --byproject flag to dump warnings in HTML file by projects.
* Add external/google and vendor/google projects, vs other
  external/non-google and vendor/non-google projects.
* Refactor code in dumpcategory to dump warnings by projects
  when --byproject is specified.
* Recognize new compiler -Wvarargs warning pattern.
* No change to default HTML output format.

Change-Id: I2406ad392ab18683357ff0ee0cf6c41f87cf399c
Test: run through current build.log files.
2016-07-26 14:53:28 -07:00
Chih-Hung Hsieh c868293abc Add performance* to default global tidy checks.
* This enables 5 performance related checks:
    performance-faster-string-find
    performance-for-range-copy
    performance-implicit-cast-in-loop
    performance-unnecessary-copy-initialization
    performance-unnecessary-value-param
* Recognize these new warnings in warn.py.

Bug: http://b/27779618
Change-Id: I7af3fdc262dd44db90d3b62eb37c5eac5a2eaa01
Test: build with WITH_TIDY=1 and run warn.py with build.log
2016-07-26 14:36:54 -07:00
Alex Deymo 21f2fda8ba Merge \"Remove unused libraries from otatools.\"
am: 4698a191e5

Change-Id: I6a1203c2c789d7f3e4e6c5d048c6ec766f172915
2016-07-26 00:45:46 +00:00
Treehugger Robot 4698a191e5 Merge "Remove unused libraries from otatools." 2016-07-26 00:36:57 +00:00
Alex Deymo 3c1075b2a5 Remove unused libraries from otatools.
libbrillo-http was actually never used but it was being liked into
delta_generator anyway.

Bug: None
TEST=`lddtree delta_generator` doesn't show librillo-http.

Change-Id: I69ac66c87847d925b5798cf261c79466a3ff432a
2016-07-25 16:10:14 -07:00
Dan Willemsen d136a4d7f2 Merge \"Revert \"Rename libevent-host to libevent\"\"
am: 79498a069a

Change-Id: Id2d9cc234438de271a5d83b44c77806fba32a5bf
2016-07-23 00:49:58 +00:00
Treehugger Robot 79498a069a Merge "Revert "Rename libevent-host to libevent"" 2016-07-23 00:40:35 +00:00
Dan Willemsen 8c2b6bb15e Revert "Rename libevent-host to libevent"
This reverts commit ef31fc6477.
It's now using unique_host_soname to use a different installed name,
but keeping the libevent module name.

Change-Id: I1cb6e8e670636089993054236b089da059629da1
2016-07-22 23:16:30 +00:00
Narayan Kamath e2d375f12c Merge \"Add java.lang.invoke to the package whitelist.\"
am: 900e9e6392

Change-Id: I5d25d40dc0b661ff1acaa957145f32c0f13da853
2016-07-22 09:40:35 +00:00
Narayan Kamath 900e9e6392 Merge "Add java.lang.invoke to the package whitelist." 2016-07-22 09:33:16 +00:00
Chih-Hung Hsieh d59fe53668 Merge \"Count warnings per project and dump out CSV format.\"
am: 053c54b554

Change-Id: I22315bc641d501e74b995ddde8d7624fa9a6b883
2016-07-22 01:02:47 +00:00
Chih-hung Hsieh 053c54b554 Merge "Count warnings per project and dump out CSV format." 2016-07-22 00:54:50 +00:00
Chih-Hung Hsieh 48a16ba709 Count warnings per project and dump out CSV format.
* No change to html output, except removing unused "PageTop" anchor.
* Add --gencsv flag to output a CSV file instead of html file.
  CSV files are combined to a table for dashboard charts.
* Count warnings from selected source project directories.
* CSV output lines are:
   num_of_warnings,project_name,warning_description
* project_name is empty for sum of warnings from all projects.
* warning_description could be:
  (1) "<severity>: <warning type description>"
      for one warning type, or
  (2) "<severity> warnings"
      for all warning types of the severity.

Change-Id: I1cf976ed0cf142091226b22665b7f28d383608fd
Test: run through current build.log files.
2016-07-21 14:43:02 -07:00
Colin Cross 768291a37c Merge \"Split -isystem headers into separate variables\"
am: 921be36569

Change-Id: Icd539e53caa9ad55e900b394c6005bb3606dce70
2016-07-21 17:58:10 +00:00
Colin Cross 921be36569 Merge "Split -isystem headers into separate variables" 2016-07-21 17:51:13 +00:00
Narayan Kamath 497c35c1a7 Add java.lang.invoke to the package whitelist.
Tracks libcore change that adds the first classes from this package
to core-oj.jar. Note that packages need to be whitelisted even if
the classes in question aren't public API.

Test: make checkbuild docs

Change-Id: I917dc63899124ca30bbeb2902787faea6754bb43
2016-07-21 15:27:09 +01:00
Colin Cross 23ba612aad Split -isystem headers into separate variables
Split the variables that contain header directories into ones that
should be prefixed with -isystem and ones that should be prefixed with
-I in preparation for moving some headers from -isystem to -I.

Add $(wildcard) around SRC_HEADERS to match the soong behavior, and move
users of SRC_HEADERS from config.mk to binary.mk so that the exported
soong value is present.

Test: no changes to build.ninja compile rules
Change-Id: Iadecbbf4351a01e53cb57e721d31f4f836bb82d9
2016-07-20 23:09:29 -07:00
Chih-Hung Hsieh bdcc181588 Merge \"Recognize new clang and clang-tidy warnings.\"
am: 6131119708

Change-Id: If307f868da5d961ad3c1cac371ca3e5a42a6b652
2016-07-20 23:08:36 +00:00
Treehugger Robot 6131119708 Merge "Recognize new clang and clang-tidy warnings." 2016-07-20 22:57:29 +00:00
Chih-Hung Hsieh c21ddbdcce Recognize new clang and clang-tidy warnings.
* Count new clang-tidy warnings:
    google-runtime-references
    google-runtime-operator
* Count new clang warnings:
    -Wconst-conversion similar to -Wliteral-conversion
    -Wundefined-var-template
* Modified static analyzer warning message about
    "Null passed to a callee that requires a non-null ..."
* Disable google-runtime-references by default and
  disable misc-macro-parentheses in vendor projects;
  too many old C/C++ code have this warning.

Change-Id: Ib35e0af85875aada17c92b0237b76cd5ae3bfcc8
Test: build with clang-tidy.
2016-07-20 14:45:01 -07:00
Colin Cross 17904fabbf Merge \"Factor out common include directories into helper\"
am: 95fa32b577

Change-Id: I720d7c02de3d11b4a5a3328946433aa7274f1bb6
2016-07-20 21:24:29 +00:00
Treehugger Robot 95fa32b577 Merge "Factor out common include directories into helper" 2016-07-20 21:11:22 +00:00
Fang Deng 9331f1c8ef Merge \"Remove GOMA_HERMETIC form goma.mk\"
am: 14df2ef4d0

Change-Id: Ie9612d77fd35fb25aaad6db1b8c690b139cc1764
2016-07-19 23:41:57 +00:00
Pirama Arumuga Nainar 8a39030c50 Merge \"Switch to prebuilt clang-3016494\"
am: b1beb6f274

Change-Id: Ic0cc4734481cddb87ed8c21d2079ab0645dbcc82
2016-07-19 23:40:37 +00:00
Pirama Arumuga Nainar adac150e40 Merge \"Disable warnings triggered in Clang r271374\"
am: 11e0e36462

Change-Id: I315936308c883352a195dc4aff0b9f42757019f1
2016-07-19 23:40:23 +00:00
Fang Deng 14df2ef4d0 Merge "Remove GOMA_HERMETIC form goma.mk" 2016-07-19 23:32:37 +00:00
Colin Cross e25fd79337 Factor out common include directories into helper
Refactor includes in transform-*-to-o to simplify future changes to the
default include paths.

Test: whitespace-only changes to the compile rules in build.ninja
Change-Id: I766af1f22a4838d933691b6df37530db3ba4e21d
2016-07-19 15:09:50 -07:00
Stephen Hines b1beb6f274 Merge "Switch to prebuilt clang-3016494" 2016-07-19 22:02:31 +00:00
Stephen Hines 11e0e36462 Merge "Disable warnings triggered in Clang r271374" 2016-07-19 22:02:31 +00:00
Fang Deng c0829a5899 Remove GOMA_HERMETIC form goma.mk
This CL removes the GOMA_HERMETIC setting from goma.mk so that
the default setting will be used. By default, GOMA will fallback
to local compiler if the exactly matched compiler is not available.

Change-Id: I22c83594f6bd30bc8ed1334ab7bb256ef218567b
2016-07-19 20:58:22 +00:00
Pirama Arumuga Nainar 1679c3649b Disable warnings triggered in Clang r271374
http://b/28149048
http://b/29823425

Disable -Wnull-dereference.  The second bug above tracks that this
warning gets re-enabled.

Test: Tested build, boot and common usage for Arm, Arm64, x86, x86_64,
Mips images in AOSP and internal branch.

Change-Id: Ie41a495dd9bb247d3609f4848d7669d1faaeeb79
2016-07-19 20:32:28 +00:00
Pirama Arumuga Nainar d1c2ff4f06 Switch to prebuilt clang-3016494
Test: Tested build, boot and common usage for Arm, Arm64, x86, x86_64,
Mips images in AOSP and internal branch.

Bug: http://b/29823425
Change-Id: I97299c8b41ff9d3ac7019a349aa569609a099233
2016-07-19 20:32:21 +00:00
Chih-Hung Hsieh 472589e1cb Merge \"Avoid matching the same warning line twice.\"
am: 0cbba3df2a

Change-Id: I641fa895ac7033056833107bf062015987965632
2016-07-18 23:38:24 +00:00
Treehugger Robot 0cbba3df2a Merge "Avoid matching the same warning line twice." 2016-07-18 23:18:47 +00:00
Chih-Hung Hsieh 5ecafd1260 Avoid matching the same warning line twice.
Used to skip only immediately followed identical warning lines.
Now classifywarning is called only once for each unique warning line.

Change-Id: Ie3b77ded70b41dafad91c042dbe15ad2be119e62
Test: run through build.log file
2016-07-18 15:27:02 -07:00
Dan Willemsen 6d1049454d Merge \"Rename libevent-host to libevent\"
am: 575a023039

Change-Id: Ia98511562db8071258101d38f83f4083db966357
2016-07-18 19:26:18 +00:00
Dan Willemsen 575a023039 Merge "Rename libevent-host to libevent" 2016-07-18 19:18:32 +00:00
Colin Cross 3721f184f2 Merge \"Only add linker_asan as dependency to shared executables\"
am: 458c0cd37b

Change-Id: I4c50d21b480200588d4581662d9fda86bb18ee3b
2016-07-17 23:45:02 +00:00
Colin Cross 458c0cd37b Merge "Only add linker_asan as dependency to shared executables" 2016-07-17 23:38:39 +00:00
Colin Cross d08699e464 Only add linker_asan as dependency to shared executables
linker_asan is only needed by shared exectuables, prevent adding it as a
dependency of anything else.  Avoids a dependency loop from
linker_asan -> linker -> linker_asan.

Change-Id: Id7744ad8a5901468518fac80741c75e764adb559
2016-07-17 15:30:46 -07:00
Colin Cross 4cca8a5573 resolve merge conflicts of 1e92cfb to stage-aosp-master
Change-Id: I1929d5c16ea0b8574372049ac7dffd30fd3e1db3
2016-07-15 14:49:45 -07:00
Treehugger Robot 1e92cfb9a0 Merge "Add support for LOCAL_MODULE_SYMLINKS" 2016-07-15 21:34:33 +00:00
Colin Cross 744d33b381 Add support for LOCAL_MODULE_SYMLINKS
Specifying LOCAL_MODULE_SYMLINKS will create symlinks to the installed
module in the same directory.

Change-Id: Idecb2b75f0c9999eb000eed9a79a989244ccf6c2
2016-07-15 12:22:39 -07:00
Badhri Jagan Sridharan 59c0529d6d Merge \"Add build variant to kernel command line\"
am: 70a9714625

Change-Id: I5e10a5375f50e9562af73407212fd4a800884b20
2016-07-15 17:10:40 +00:00
Badhri Jagan Sridharan 70a9714625 Merge "Add build variant to kernel command line" 2016-07-15 17:00:13 +00:00
Dan Willemsen ef31fc6477 Rename libevent-host to libevent
There's no need to use a different name for target and host modules, and
in Soong, it's better to use the same for both.

Change-Id: Ib2d8d0cc8a1e0f7f95d7c2795a360f02d946fa1a
2016-07-13 23:47:24 -07:00
Dan Willemsen d5c3e04c85 Merge \"Allow prebuilts to specify mini-debug-info\"
am: 4ea20be28b

Change-Id: I410014ad90800d78753f0c5c8cbb948aef369614
2016-07-14 04:09:47 +00:00
Dan Willemsen 4ea20be28b Merge "Allow prebuilts to specify mini-debug-info" 2016-07-14 04:04:43 +00:00
Dan Willemsen 4598fbc9dd Allow prebuilts to specify mini-debug-info
So that Soong can specify the default that's used by Make.

Change-Id: I0c1062ad8f21df8b9a483f99dce679a1434e4859
2016-07-13 17:39:56 -07:00
Gaelle Nassiet f464d8e7d4 Merge \"Fix root_filesystem_config.txt generation\"
am: 461a3283d9

Change-Id: I07ebb4520d02948bff90911d03692d7896dff89c
2016-07-13 23:15:12 +00:00