Commit Graph

33205 Commits

Author SHA1 Message Date
Tracy Zhou 25399db1e7 Merge "[DO NOT MERGE] Disable live tile in split mode for S" into sc-dev 2021-08-03 21:50:06 +00:00
Tracy Zhou 145bd74749 [DO NOT MERGE] Disable live tile in split mode for S
Recall link: https://recall.googleplex.com/projects/debb8388-5e38-42c5-99ab-20bdfb92d25e/sessions/655af962-b4bd-4dc4-93aa-178852c0d701

Bug: 193991436
Test: enter split screen and swipe up
Change-Id: I7adffcdefb12d225db207542716a436f29df0377
2021-08-03 20:50:27 +00:00
vadimt 21091ada88 Logging to figure out why first dump didn't result in assertion
Bug: 195319692
Test: presubmit
Change-Id: I4a80541a58eb8f630211de4b90836c435f6d41b2
2021-08-03 18:47:35 +00:00
Jonathan Miranda 4a17e66166 Merge "Add more restrictions on whether we increase the hotseat size for tall devices." into sc-dev 2021-07-30 20:37:29 +00:00
Alex Chau e20208e9d1 Merge "Always treat FallbackRecentsView as visible if isInLiveTileMode is true" into sc-dev 2021-07-30 17:53:34 +00:00
Alex Chau fb5ae9060d Always treat FallbackRecentsView as visible if isInLiveTileMode is true
- activity.hasBeenResumed is no longer an accurate indicator after live tile has been introduced, indeed it's always false
- Return recentsView regardless if there is a runningTask as well

Bug: 194286330
Test: In fallback Recents with 3 button, tap overview button from home screen, then tap overview button again. Try combination with back and home button
Change-Id: Ib2775a11f5466abc433763f24192e7bfdcf191a2
(cherry picked from commit 455718e842)
2021-07-30 08:22:03 +00:00
Bill Yi da8bf1142f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I13dab850677f614cab804cae0b3125c93c55eeed
2021-07-30 04:59:15 +00:00
Tracy Zhou dec3330a83 Merge "Clear command queue of OverviewCommandHelper on home tap" into sc-dev 2021-07-29 21:32:22 +00:00
Tracy Zhou 6842315605 Clear command queue of OverviewCommandHelper on home tap
Fixes: 194934483
Test: manual
Change-Id: Id83b341245793c38c305e6ada5581ac4e49527a7
Merged-In: Id83b341245793c38c305e6ada5581ac4e49527a7
2021-07-29 19:09:53 +00:00
Jon Spivack d317f17273 NIU Actions: Change AppTheme to LauncherTheme
Some theme attributes used for the NIU Actions Overview were originally defined in a theme that inherited from LauncherTheme. However, 3rd-party Launchers that also used themes derived from LauncherTheme were unable to access these attributes, leading to crashes when they tried to open the Recents screen on Go devices. Just adding the attributes to LauncherTheme solves this issue.

Bug: 194810415
Test: Manual (tried a couple 3rd-party launchers on Wembley)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: I7a2541f2a2ab3b39e0c6cf2fe40a4b096047df70
2021-07-28 19:14:03 -07:00
Jon Miranda 80dda30f49 Add more restrictions on whether we increase the hotseat size for tall devices.
Bug: 194688362
Test: test devices that should not be affected, ensure they are not affected
Change-Id: I0e027354dbafcce30cf616998d2a7bfab516b5de
2021-07-28 14:20:59 -07:00
TreeHugger Robot ce4bdd3561 Merge "Enables Enhanced Smartspace by default." into sc-dev 2021-07-28 00:01:31 +00:00
Andy Wickham 2afb784531 Enables Enhanced Smartspace by default.
Test: MemoryTests.java, manual
Bug: 187428578
Merged-In: Iffc6ae9b79db47d0585486529d2d8dfdf0a24692
Merged-In: I497523aa1be78e4d0890a7a74a1bd08d4ca50f50
Change-Id: I497523aa1be78e4d0890a7a74a1bd08d4ca50f50
2021-07-27 12:34:55 -10:00
TreeHugger Robot 0a5b66af2c Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-07-27 14:39:44 +00:00
Bill Yi 6fc1eae8d0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia2101dbfa85b65d3de87200f0fbaf5d09c25a7d9
2021-07-27 09:13:26 +00:00
Tracy Zhou 024749a1e0 Merge "Reset current task and dequeue overview commands when recents animation is cancelled" into sc-dev 2021-07-26 21:17:38 +00:00
Tracy Zhou 94e798bac1 Reset current task and dequeue overview commands when recents animation is cancelled
Fixes: 193925362
Test: manual
Change-Id: I792be003e5aabf34324075829d5381cba591892b
2021-07-26 12:17:01 -07:00
TreeHugger Robot aa4c71efa0 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-07-24 05:42:14 +00:00
TreeHugger Robot 19fc9302ba Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-07-24 05:36:43 +00:00
Bill Yi 38e18c295c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia201032e39017688795dd9082946690e7e77fd45
2021-07-24 03:07:29 +00:00
Bill Yi 818238558a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I47acd077e560f94d070da5dd2c9b66ac07950e49
2021-07-24 03:05:08 +00:00
TreeHugger Robot 6d9e866669 Merge "Update hotseat sizing for 4x5 grids." into sc-dev 2021-07-23 22:39:48 +00:00
Sunny Goyal e0e64b4851 Merge "Fixing touch events ignored in some cases" into sc-dev 2021-07-23 22:13:35 +00:00
Jonathan Miranda 0c7153bbdf Merge "Add more extra space to hotseat for taller devices." into sc-dev 2021-07-23 21:41:27 +00:00
Jon Miranda 80cddbccb6 Add more extra space to hotseat for taller devices.
Bug: 192520231
Test: manual test on taller devices
Change-Id: I3eccada67f0ba07d01f823c4156f02c3feb97f84
2021-07-23 20:01:16 +00:00
Jon Miranda 069f8c5ac9 Update hotseat sizing for 4x5 grids.
If the qsb bottom margin is smaller than the bottom insets,
we'll fall back to centering the qsb in the available freespace.

Bug: 194435265
Test: 4x5 grid
      multiple devices,
      with: gesture nav enabled
            3 button nav enabled

Merged-In: I9fd4f0da3f2bc9f0b38a621ad1192533260379e3
Change-Id: I711e7d168b80254e73df0d4e1854756d819a705b
2021-07-23 18:47:33 +00:00
TreeHugger Robot 3f062ab8b6 Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev 2021-07-23 18:10:48 +00:00
Jonathan Miranda adeb26b0dc Merge "Update size limits to match spec." into sc-dev 2021-07-23 06:46:27 +00:00
Jon Miranda f33f5b3fc5 Folder polish: unbold folder title, ensure icons not cropped in folder.
- Ensure folder items are scaled to fit within the height/width in 4x5 mode.
- This bug surfaced now since  we increased the icon size.

Bug: 194356039
Test: set display to large, set font to large
Change-Id: Ie360ca67c3c91649a471bce920b2fc6a82fb9661
2021-07-22 17:19:28 -07:00
Jon Miranda e4413cc6ae Update size limits to match spec.
Bug: 194124461
Test: Verified using screnshots over spec
      Only 4x5 grid is affected
      Tested on multiple devices, multiple display options

Change-Id: I301c512e416ed81f6d41f6f0ecbf5994d47d82bf
2021-07-22 16:26:18 -07:00
Sunny Goyal 58e81e5da1 Fixing touch events ignored in some cases
Bug: 160218103
Test: Manual
Change-Id: Ifa71e742451acecd8979a6833a202c6189b4df52
2021-07-22 15:27:43 -07:00
Adam Cohen ed82e0daef Fix widget drop preview outline on 4x5 grids
=> We were not account for mBorderSpacing in the outline calculation
=> This was fine in most cases as this value is 0, but 4x5 appears to be the exception

Bug: 194227752

Test: manual, see video in bug.
Change-Id: Ib590bc142a0f65e75f92ee057f8b4f4b0f81521b
2021-07-22 12:31:21 -07:00
TreeHugger Robot 6a01fe49a5 Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev 2021-07-22 18:53:32 +00:00
Steven Ng a606d344a6 Measure WidgetsFullSheet before estimating the recommended table
size

Issue: The header view height was obtained before any measurement.

Test: On Pixel 5 4x5 gird with Photo widget shown in recommended
      table, make the device in landscape. Then open the full widgets
      picker. The widgets picker can be scrolled. Before this fix,
      scrolling is not possible.
Fix: 194172597
Change-Id: Ib30cf4b95d2ed23ff28f3d24e103f0e919b3a551
2021-07-22 16:08:15 +01:00
Jason Chang 1b3f5d3883 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev 2021-07-22 09:43:13 +00:00
Jonathan Miranda 46378eb881 Merge "Folder icon polish." into sc-dev 2021-07-22 00:15:29 +00:00
Brian Isganitis ec4a56a311 Support overriding All Apps EDU animation on drag
Test: Dragging during All Apps EDU animation overrides the animation.
Bug: 160218103
Change-Id: I1c0a2d047bcb43ea7ce30cf87182b392dac313e4
2021-07-21 17:39:00 +00:00
TreeHugger Robot 3a7df28e8d Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-07-21 12:46:42 +00:00
Bill Yi ae99b65b1f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I828bb455fd6ce0c8e5552cac3bf2090f29021ccd
2021-07-21 05:55:06 +00:00
Jason Chang edc7917521 Fix unable to swipe up to exit one-handed mode under
2 button navigation

Remove redundant condition checking when consuming One-handed mode
gesture events.

Bug: 193761450

Test: manual
Test: atest WMShellUnitTests
Change-Id: Id4687cb579c17d7de1a08b32c003e656cbbce820
2021-07-21 11:54:52 +08:00
Brian Isganitis d9d525236a Merge "Revert "Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev"" into sc-dev 2021-07-21 00:37:36 +00:00
Lucas Dupin 8d43e46261 Merge "Revert "Apply depth even when surface is null"" into sc-dev 2021-07-21 00:20:30 +00:00
Jon Miranda 92c1b5d3ab Folder icon polish.
- Increase the overlap between the preview items and the background
  so that it appears more intentional (lots of reports of users
  thinking that its a bug)
- Fix bug where clip path was still clipping icons when
  dragging and swiping to home.

Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
      close folder on 2nd page, ensure clipping
      ensure no preview items are clipped in drag view
      ensure no preview items are clipped in swipe up to home
      test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
      of folder icons
      drag and drop folder in and out of hotseat
      create folders (2 icon, 3 icon, 4 icon)

Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
Change-Id: Ic3708bd402704f0a6f57ae5315ef602e2bbc6d82
2021-07-20 22:16:21 +00:00
Lucas Dupin ee9099af7f Revert "Apply depth even when surface is null"
This reverts commit a6c38be150.

Fixes: 193333562
Test: manual
Change-Id: I4fae079e0cd056fc800e5a15389f4795c77e17fb
2021-07-20 14:14:50 -07:00
Hyunyoung Song 56c33c3cb8 Merge "Fix fast scroller issues / remove fast thumb access / fix wrong popup location" into sc-dev 2021-07-20 19:06:36 +00:00
Sunny Goyal c3f56d7628 Merge "Fixing quickswitch window not properly aligned in split-screen" into sc-dev 2021-07-20 07:03:51 +00:00
Hyunyoung Song 02e5d63fc7 Fix fast scroller issues / remove fast thumb access / fix wrong popup location
(1) Remove jumping to arbitrary fast scroller position
because back gesture can trigger arbitrary fast scrolling
(2) Pop up would show up in random location when user combines
touching the track and scrolling. This was because thumb
location was not updating when user was scrolling on the main
container.

Bug: 193177670
Bug: 191562400

Test: manual
Change-Id: I129aaa37ca911666453a8c98e24eaac33827238f
2021-07-19 23:44:14 -07:00
Brian Isganitis b684c1b59b Revert "Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev"
This reverts commit 7de95d6767, reversing
changes made to 0a70a5a690.

Lints have been added to fix errorprone.

Test: Widgets should adapt to wallpaper colors in launcher preview.
Bug: 192205054
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586
Change-Id: I6866f8521ed427d096f27da0a92d8b40e1099187
2021-07-19 21:03:26 -04:00
Jonathan Miranda 7de95d6767 Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev 2021-07-20 00:45:57 +00:00
Jonathan Miranda f5fee1a7d3 Revert "Use wallpaper colors for widgets in wallpaper change preview"
Revert "Implement generateColorsOverride from LocalColorExtractor"

Revert submission 15331418-colorcp

Reason for revert: Broke the build
Reverted Changes:
Ife80b07f9:Use wallpaper colors for widgets in wallpaper chan...
I1371eb787:Implement generateColorsOverride from LocalColorEx...

Bug: 194138049

// Using original change's merged-in tag to avoid clashing
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586

Change-Id: I3835dfb8efe745dc0a654712a5b1f68c4946f446
2021-07-20 00:44:42 +00:00