Commit Graph

35522 Commits

Author SHA1 Message Date
Vinit Nayak 09a822a6fe Schedule OverviewCommandHelper callbacks for GroupedTaskView
* Schedule runnables to clear pending queue in
OverviewCommandHelper similar to how TaskView does it.
* End callbacks get run when recents animation finishes in
RecentsView in the case of live tile when recents animation
is still running
OR
in directly when the split remote animation finishes

Bug: 207845542
Change-Id: I7e858ce55b08cde6436d44f2e857e28b73458f0b
2021-11-30 20:18:50 -08:00
Vinit Nayak b997930afc Treat RTL split placeholder animation same as LTR
* Since we're doing all transformations in screen
coordinates we don't need to account for RTL.

Bug: 202156862
Change-Id: Ibcbf698dbc5b8fabf2647949de6d2718937832d5
2021-11-30 19:58:00 -08:00
Vinit Nayak 570653346f Add task unpinning support for 3 button taskbar
Bug: 199544447
Test: Tested on small and large screen
Change-Id: Ib7785992ef11825cd07a929e2cb623d02ef246f1
2021-11-30 17:18:09 -08:00
Jon Miranda 5040335e35 Remove keepWindowOpaque and have the window always fade out.
We built this method so that the window would have
something to fade out on top of. But with longer icon loading times,
this causes a buggy experience since the window is opaque
for the entire duration of the animation.

Having the window always fade out is a better UX for now.
Next step is to always init the FloatingIconView with the
in-memory icon, and then possibly caching both layers
of AdaptiveIcon.

Test: restart phone, swipe up to home
      restart phone, back swipe to home (This flow never called keepWindowOpaque)
Bug: 207389002

Change-Id: Ida64829c60881786ed91e8641cdf7a278b37e201
2021-11-30 16:55:07 -08:00
TreeHugger Robot 96f3f2214c Merge "Fix potential memory leak by setting mControllers = null" into sc-v2-dev 2021-12-01 00:49:56 +00:00
Jerry Chang 36eb818600 Merge "Remove stage type from split screen APIs" into sc-v2-dev 2021-12-01 00:41:10 +00:00
Tracy Zhou d1f9fde371 Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-v2-dev 2021-12-01 00:34:00 +00:00
Vinit Nayak 6e906f3436 Align OverviewActionsView for 3 button taskbar
Bug: 189807374
Change-Id: I3c7ec5f8c7b588032ff83ca7ab461d2aac7bfa35
2021-11-30 16:24:12 -08:00
Brian Isganitis be388b8933 Merge "Make action optional for snackbar." into sc-v2-dev 2021-12-01 00:18:40 +00:00
Tony Wickham f6c28a4381 Fix potential memory leak by setting mControllers = null
Test: N/A
Bug: 202511986
Change-Id: Iad7cc89e0e68ce09ebe4ca3ab89392b50b6a82c7
2021-11-30 14:37:36 -08:00
TreeHugger Robot b78cbf29e5 Merge "Possible fix for NullPointerException b/206040100." into sc-v2-dev 2021-11-30 19:58:24 +00:00
TreeHugger Robot 2280f3d5fc Merge "Close task menu scrim when pressing home button" into sc-v2-dev 2021-11-30 19:08:18 +00:00
Jonathan Miranda 199644c397 Merge "Fix NPE in FloatingIconView" into sc-v2-dev 2021-11-30 18:43:29 +00:00
TreeHugger Robot 96f34af124 Merge "Fling to close tasks in the GestureNav can be too small." into sc-v2-dev 2021-11-30 18:34:09 +00:00
Sebastian Franco 8afeba605a Possible fix for NullPointerException b/206040100.
There is a NullPointerException when trying to get the
length of the array.

Test: Manually tested
Fix: 206040100
Change-Id: I69a03fd3658094655eaf97fa21039fd373ee37d5
2021-11-30 10:09:02 -06:00
Prabir Pradhan 53ae5d85a6 Tapl Widgets: Don't use container width as gesture margin
The test used margin that was equal to the width of the container when
injecting a backward swipe. This means the swipe was injected at an x
value of 0 in the View's local coordinates. When injecting such events
into the system, the coordinates will undergo several transformations,
at which point floating point precision errors could accumulate. This
could result in the event being dispatched outside the boundary of the
view.

Change the injection margin so that the swipe is injected in the middle
of the View instead of at its edge.

Bug: 201777251
Bug: 207146693
Test: atest TaplTestsLauncher3
Change-Id: I4082c2845aef033a6fbe41070061866d6048e21d
2021-11-30 15:06:42 +00:00
Alex Chau a8fc7e03fd Close task menu scrim when pressing home button
- Generally close all floating view when starting home from Recents

Bug: 193432925
Test: with 3 button, open task menu, then press home
Change-Id: Ic99c50333c797f222fc8e682fd0f3fcc4d641d47
2021-11-30 14:27:36 +00:00
Jerry Chang 8176366f54 Remove stage type from split screen APIs
Bug: 198438631
Test: manual check
Change-Id: Ic4f41e39013e4d49585da4cda9b28151c549357a
2021-11-30 17:15:40 +08:00
Tracy Zhou 260b90c7ad Merge "Reset live tile params along with resetTaskVisuals" into sc-v2-dev 2021-11-30 04:41:40 +00:00
Adam Bookatz cbafa6803b Merge "Revert "Fix issue with Shell listeners being unbound if SysUI is restarted"" into sc-v2-dev 2021-11-30 03:44:30 +00:00
Tracy Zhou bb594548bb [DO NOT MERGE] Make the cutout slightly smaller
Temporary fix for S. Leaving the bug open for a proper fix in T.

Since we reverted the z order back (launcher on top), we should apply this fix from S and find a proper solution in T

Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
(cherry picked from commit 26f47c711a)
2021-11-30 01:01:59 +00:00
Tracy Zhou a56dc760dd Reset live tile params along with resetTaskVisuals
The dismissal animation doesn't return the translationY to 0, but resetTaskVisuals does.

Fixes: 207782306
Test: Drag live tile to dismiss lightly so it doesn't succeed. When it comes back, make sure it matches the cutout.
Change-Id: I64ee06ad72c403ab4fdd4671d08b1843a3e89253
2021-11-30 00:49:02 +00:00
Adam Bookatz 3d34f94784 Revert "Fix issue with Shell listeners being unbound if SysUI is restarted"
This reverts commit 34e384d2e1.

Reason for revert: Multiuser performance (b/208276322)

Change-Id: Icd27ab3095c446895360f8e2faa7f9c92ab2cf01
Bug: 208276322
2021-11-30 00:19:05 +00:00
Thiru Ramasamy 24fbda5448 Set default value for rank field in launcher logs to ItemInfo.rank.
Bug: 188222480
Test: wwdebug & wwlogcat
Change-Id: I16786eb2e6f1d4ce44dbda5eff27b1cd7f50ee8e
2021-11-29 16:14:02 -08:00
TreeHugger Robot ed05712f04 Merge "Handle configuration changes in floating rotation button" into sc-v2-dev 2021-11-29 19:41:26 +00:00
Nick Chameyev ed6b29f211 Merge "Add WRITE_SECURE_SETTINGS permission to Launcher" into sc-v2-dev 2021-11-29 17:14:09 +00:00
Nick Chameyev c52ec89e1b Add WRITE_SECURE_SETTINGS permission to Launcher
We reused a code that handles rotation suggestion button
from SysUI in Launcher. It requires WRITE_SECURE_SETTINGS
permission to write how many times we have shown this button
to show ripple only the first 3 times.
AOSP Launcher didn't have this permission and it was crashing.

Bug: 205491152
Test: tap on rotation suggestion button when in AOSP launcher
Change-Id: I216abb86d43cc505aec1ff581c1f332ae3ad0db4
2021-11-29 12:21:35 +00:00
TreeHugger Robot c5f18aa980 Merge "Resets taskSplitTranslation of inactive orientation" into sc-v2-dev 2021-11-26 18:23:43 +00:00
Alex Chau 9ead9ca226 Fix switch access for overview grid
- Removed overscroll checking in switch access, as overscroll isn't supported via snapToPage
- Don't show forward/backward action if no further scroll is possible
- When scrolling right in overveiw grid, snap to the next non-fully visible task
- When scrolling left in overview grid, snap to a position that next non-fully visible task is on the left of the screen

Fix: 204162346
Test: Use switch action in Workspace/Recents with and w/o RTL
Change-Id: I0d4f201edf2da543703e88420e6f3255fb2ba16f
2021-11-26 17:51:32 +00:00
Thales Lima d9d7f7214a Merge "launcher: use same icon size for all apps drawer in foldables" into sc-v2-dev 2021-11-26 15:10:03 +00:00
Thales Lima 6e0005af6b launcher: use same icon size for all apps drawer in foldables
For foldables, no matter the grid size, we use 60dp for icons sizes.
This also fix a bug where the icon size was always the minimum between
default and all apps, which means that for foldables it would always be
default.

Bug: 202708085
Test: visual, using HSV and Window
Change-Id: I315718a8ba7a0aaed2204ad12e6b184dda2be48e
2021-11-26 10:03:43 -03:00
Alex Chau 9a5f99bfe6 Resets taskSplitTranslation of inactive orientation
Fix: 204185003
Test: manual

Change-Id: I10e49994e8a9723f39d7f9159de7c1f8216ea77f
2021-11-26 12:04:47 +00:00
Nick Chameyev 71eed5ca35 Handle configuration changes in floating rotation button
Update resources in floating rotation button
when configurations such as screen density, screen size,
current locale have changed.

Bug: 200103245
Test: change display size, locale, fold/unfold
 -> check that floating rotation button resources
    are updated
Change-Id: Ia69f4f8b393a686012e286a1e39822650c562d52
2021-11-26 11:38:28 +00:00
Jerry Chang 71b7d1537d Merge "Support to launch app pair from overview with recorded split ratio." into sc-v2-dev 2021-11-26 05:43:34 +00:00
Alex Chau eace1ba76d Merge "Use alternative way to fix split select page snapping issue" into sc-v2-dev 2021-11-25 19:13:23 +00:00
Alex Chau 22d7524f53 Merge "Fix tapl tests for overview actions in fallback recents." into sc-v2-dev 2021-11-25 17:58:02 +00:00
Alex Chau b3a9386556 Use alternative way to fix split select page snapping issue
- Reverted to before ag/16095449 where reset() is called after state transition completed
- Call pageBeginTransition in dismiss animation to make sure onPageEndTransition is triggered to clear mCurrentPageScrollDiff properly
- Fixed a condition in resetFromSplitSelectionState ot use DeviceProfile.overviewShowAsGrid, as when state is in transition, showAsGrid() would be false

Fix: 207744890
Test: manual
Change-Id: I5a812a7ee26df2f953f7fed0155880620d2c4e66
2021-11-25 16:48:39 +00:00
TreeHugger Robot da014976cd Merge "Revert "Migrate workspace item adding tests to kotlin"" into sc-v2-dev 2021-11-25 15:40:06 +00:00
Pat Manning 4433db800c Fix tapl tests for overview actions in fallback recents.
Note: fallback recents test may still fail manual testing if using flag SEPARATE_RECENTS_ACTIVITY

Test: FallbackRecentsTest.java
Bug: 197630182
Change-Id: Id18184e1f6271337adceacc9bac583d84e83afed
2021-11-25 15:39:47 +00:00
Alex Chau 4075f17c2d Revert "Migrate workspace item adding tests to kotlin"
This reverts commit e77eafc263.

Reason for revert: b/207684378
Bug: 207684378
Bug: 199160559

Change-Id: I4a35fea423f1cd7afae4603fd1185150763f8bf0
2021-11-25 11:54:26 +00:00
TreeHugger Robot 32ebd9f94f Merge "Fix ClassCastException in QuickstepModelDelegate" into sc-v2-dev 2021-11-25 04:00:37 +00:00
Jerry Chang 279c3b7fa2 Support to launch app pair from overview with recorded split ratio.
Bug: 207479945
Test: Quickswitch back to app pair keep split ratio
Change-Id: Id24195c15fe59053cc51515a942f72c3b8e87ba7
2021-11-25 11:38:14 +08:00
TreeHugger Robot 79132556f7 Merge "Add TaskbarControllers#runAfterInit()" into sc-v2-dev 2021-11-25 00:08:08 +00:00
Tony Wickham a143500a69 Add TaskbarControllers#runAfterInit()
And use it in TaskbarModelCallbacks#commitItemsToUI(), which in rare cases can run during init() before other controllers (namely TaskbarStashController) have been initialized.

Test: call commitItemsToUI() in TaskbarModelCallbacks#init(), ensure no crash
Fixes: 204847702
Change-Id: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
Merged-In: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
2021-11-24 23:14:06 +00:00
Schneider Victor-tulias 380f8fd890 Fix ClassCastException in QuickstepModelDelegate
- Added a casting check as an immediate fix to b/173838775
- Added logging to help debug the corrupt state where an item of type other than FolderInfo is used as an other item's container.
- Added LoaderMemoryLogger for adding large logs that are only conditionally printed.

Bug: 173838775
Test: manually checked logs
Change-Id: I9491cb421b9fb807d5fb110b04ad069481de768f
2021-11-24 14:26:45 -08:00
Fedor Kudasov 4e678ff6d5 Separate getTaskViewAt usage
getTaskViewAt is used in two different contexts with different
assumptions:
1. In the context of iterating over the all TaskViews, where
the valid tasks indices are know.
2. In the context of requesting some TaskView by index, where
the caller expects null when the input index is invalid.
The nullability status of the method differs in these contexts
and therefore getTaskViewAt usage can be separated into two
different methods.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I42c04c115c309f1849f9dfbb05c74b9b080acf13
(cherry picked from commit 4da3b4bdddbbff7a0dee1f57b3a74c616231e100)
2021-11-24 21:19:22 +00:00
Alex Chau 376b09ade2 Merge "Consider two panel in home to overview transition" into sc-v2-dev 2021-11-24 20:33:32 +00:00
Alex Chau 6095333370 Consider two panel in home to overview transition
- Get the value from DeviceProfile directly

Fix: 202444558
Test: manual
Change-Id: Ifadbbf34c8103d7275b8b4043dcae47d1168ae83
2021-11-24 18:11:45 +00:00
Tony Wickham b4aefc1277 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev 2021-11-24 17:54:18 +00:00
Alex Chau 226bd5b973 Merge "Fix grid layout problem after going back from split select" into sc-v2-dev 2021-11-24 10:32:46 +00:00